Bug in floating rules since 2.4.5-RELEASE-p1


  • Hello,
    Is it already known that since 2.4.5-RELEASE-p1 the visualization of floating rule is broken when in conjunction with separators?

    The Interface column was added but the separators don't take it into consideration so they don't extend till the end of the table.

    Screen Shot 2020-09-07 at 6.35.56 PM.png

    Also, do you think it make sense to include an option to collapse/comma-separate/change-visualization of the interfaces if you want? If you have a lot of them, looking at the floating rules has become impossible (since they are very tall and the interfaces are listed one per line).

    Thanks


  • FYI, this is a bug fix which I really needed to deploy to look at my floating rules, maybe can help other users or could be considered as a starting point to enhance this:

    $ diff /usr/local/www/firewall_rules.php_old /usr/local/www/firewall_rules.php
    336c336
    < $columns_in_table = 13;
    ---
    > $columns_in_table = ('FloatingRules' == $if) ? 14 : 13;
    689c689
    < 					echo implode('<br/>', $selected_descs);
    ---
    > 					echo implode(', ', $selected_descs);
    
  • LAYER 8 Rebel Alliance


  • Thanks Rico! Good to see it has been addressed already.

    Do you/anyone think it makes sense to also improve the way the interfaces are listed? If so I can open an enhancement in redmine.

    Cheers & thanks


  • Well, I went ahead and created https://redmine.pfsense.org/issues/10892 for the interfaces display issue