New Shaper grammar patch
One of the 2.0 todo items is to go over the shaper wizards with an english bat. I started going through the shaper php files first to see what I could find. Here are some minor fixes. (Just ignore the fact that I can't spell grammar please.)
If this isn't an appropriate way to submit patches please let me know.
Forgot to add this, not sure if pfsense requires this but other projects I have worked on do.
Developer's Certificate of Origin Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or © The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it. (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. Signed-off-by:Josh Stompro firstname.lastname@example.org
Unbreaking the English there has been on my todo list for a while. Committed, thanks!
Looks correct but if you can verify it'd be appreciated.
You can submit merge requests in git, patches are fine too though.
I spoke to my wife about the line "The sum of children bandwidth exceeds that of the parent." which I don't think I got quite right. Her suggestion is "The sum of the children's bandwidth exceeds that of the parent." Other than that it looks good. I don't think I can break much as long as I stick with comments and quoted strings.
I can just add that change to a future patch, I'll probably look through it all again and see if I can clean up anything else. Thanks for merging it.
It looks to me like someone already went through the shaper wizards, or they were done well in the first place, because I cannot find much to fix there.