Selected firewall rules no more highlighted
I upgraded several machines from 2.1 to 2.1.2 and 2.1.3 (i386 and amd64).
Did anyone else notice that selected firewall and NAT rules are no more highlighted? I think that was still working on 2.1.
Is that now a feature that can be enabled/disabled somewhere, or is it a bug?
I replaced /usr/local/www/firewall_rules.php with the version BEFORE this commit:
and the highlighting works.
So something in that commit has broken the highlighting.
I haven't got time right now to spot the cause - in transit at KL airport!
Note: Done on a 2.1.2 system. So the problem is in 2.1.2 (and presumably 2.1.3 also).
I also realized that "black bar" showing up in the rows above/below a rule when trying to move a rule up/down disappeared.
Maybe that is related
But no hurry. Have a good flight ;-)
Redmine issue https://redmine.pfsense.org/issues/3646 logged so this does not get forgotten.
Edit: and fixed by Renato https://github.com/pfsense/pfsense/commit/7e736f3850624668182d5204865e8805f21a7577
Duplicate id attributes are violation of html standard.
The id attribute specifies a unique id for an HTML element (the value must be unique within the HTML document).
See attached row_toggle.js file for 3 method examples for handling the unique id values.