PfBlockerNG-devel 2.1.2

f34rinc

https://github.com/pfsense/FreeBSD-ports/pull/515

+105,966 lines added
−7,906 lines removed

Thank you BBCan177 cant wait to see the changes.

felda

BBCan177 is bae ( ͡° ͜ʖ ͡°)

BBcan177

Thanks ;)

jacotec

Awesome Project, @BBcan17 ! A ton of thanks!
Short question: Even when changing to the DEV update stream I'm not seeing this update ... any idea how to update the package?

RonpfS

@jacotec It's only available for 2.4.x devel
It should become available for the other branches at some point.

jacotec

@ronpfs Ahm, that's what I'm talking about. Changing my update settings to 2.4.x Devel, go to package manager then ... a couple of packages are showing updates now, but pfBlockerNG is still at 2.1.2_3

mtarbox

@jacotec Did you delete your current pfblockerng install, and save the settings before changing your update branch?

jacotec

@mtarbox said in PfBlockerNG-devel 2.1.2:

@jacotec Did you delete your current pfblockerng install, and save the settings before changing your update branch?

Ah, nope ... I've expected that it'll update as usual ...
Other plugins also are showing updates after changing to the DEV branch ...

mtarbox

@jacotec
https://www.reddit.com/r/PFSENSE/comments/8lnugz/pfblockerng_devel_version_released/

"Before Installing this version, you must first uninstall the pfBlockerNG Release version (2.1.2_3).

Ensure that you have "Keep Settings" ENABLED so that you do not loose your existing Settings!"

jacotec

@mtarbox said in PfBlockerNG-devel 2.1.2:

@jacotec
https://www.reddit.com/r/PFSENSE/comments/8lnugz/pfblockerng_devel_version_released/

"Before Installing this version, you must first uninstall the pfBlockerNG Release version (2.1.2_3).

Ensure that you have "Keep Settings" ENABLED so that you do not loose your existing Settings!"

Thanks for the link ... clear now!

Need to think if I try or wait ... I guess the update of the release will work as usual, and that's my main production router here and usually I'm staying at stable ... just the new things are soooooo cool

Forsaked

DNSBL keeps beeing async after the upgrade to 2.1.2.
A force reload and disabling the live sync feature won't help.

Does anyone have an idea?

RonpfS

Did you inspect the logs ?
Maybe go to General Tab and click save, do the same with IP tab and DNSBL tab. This might detect errors in your configuration.

Last thing you could try, in General tab, is to untick PfblockerNG Enable and Keep settings then Save, this will clear your database.
Tick the boxes back, Save, then do a Force Reload All.

Forsaked

This won't work, im still out of sync.
The log can be found here.

RonpfS

This is because you have twice the Samedi_SecureMecca URL defined in your DNSBL table.

[ Samedi_SecureMecca ]		 Downloading update [ 05/27/18 10:12:55 ] .. 200 OK.
. . .
[ Samedi_SecureMecca ]		 Reload [ 05/27/18 10:13:00 ] . completed ..
. . .
  ----------------------------------------------------------------------
  Orig.    Unique     # Dups     # White    # TOP1M    Final                
  ----------------------------------------------------------------------
  25263    25263      23422      157        0          1684                 
  ----------------------------------------------------------------------
. . .
*** DNSBL update [ 1530059 ] [ 1528375 ] ... OUT OF SYNC ! *** [ 05/27/18 10:14:30 ]

1530059 - 1528375 = 1684

Header/Label have to be different.

Forsaked

Thank you!
I will check this, when i'm at home.

Edit:

You where right, somehow i managed to use the same Header/Label on 2 different lists, which caused the error.
Now everything is fine, thank you!

Quarkz

I’m getting the following error on a semi-regular basis which seems to completely lock up PHP

PHP ERROR: Type: 1, File: /usr/local/pkg/pfblockerng/pfblockerng.inc, Line: 3990, Message: Call to a member function fetchArray() on boolean

Any ideas? Thanks for the great package

RonpfS

This post is deleted!

RonpfS

@quarkz

Did you uninstall the 2.1.2_3 Version before install the 2.1.2 Dev version?
Did you run a Force Reload All ?

What is the status of the pfBlockerNG firewall filter & pfBlockerNG DNSBL service ? Restart the services.

Did you look at the logs files ?

Quarkz

@ronpfs

Yes. BBCan sent me a git fix to test.

Forsaked

Did the package name changed from "2.1.2_2" to 2.2.1"?
I have an update available.

RonpfS

https://github.com/pfsense/FreeBSD-ports/pull/526

Forsaked

Thank you @RonpfS!

RonpfS

pfBlockerNG-devel 2.2.1 is now available under 2.3.5-RELEASE-p2

bbrendon

Any idea when this new version is going to be a "non-devel" version?

netgate-james

@BBcan177 Hitting this on a pretty consistent basis:

Crash report begins. Anonymous machine information:

amd64
11.2-RELEASE
FreeBSD 11.2-RELEASE #24 5bbe95e97b4(factory-RELENG_2_4_4): Mon Jul 2 12:46:48 EDT 2018 root@buildbot3:/builder/crossbuild-master/pfSense/tmp/obj/builder/crossbuild-master/pfSense/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[05-Jul-2018 12:59:04 America/New_York] PHP Warning: SQLite3::exec(): database is locked in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3842
[05-Jul-2018 13:00:48 America/New_York] PHP Warning: SQLite3::exec(): database is locked in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3845
[05-Jul-2018 13:00:48 America/New_York] PHP Warning: SQLite3::query(): Unable to prepare statement: 5, database is locked in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3923
[05-Jul-2018 13:02:33 America/New_York] PHP Warning: SQLite3::exec(): database is locked in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3842
[05-Jul-2018 13:04:18 America/New_York] PHP Warning: SQLite3::exec(): database is locked in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3845
[05-Jul-2018 13:04:18 America/New_York] PHP Warning: SQLite3::prepare(): Unable to prepare statement: 5, database is locked in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3957
[05-Jul-2018 13:04:18 America/New_York] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3958
[05-Jul-2018 13:06:04 America/New_York] PHP Warning: SQLite3::exec(): database is locked in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3842

No FreeBSD crash data found.

netgate-james

@netgate-james Also this in Alerts

PHP ERROR: Type: 1, File: /usr/local/pkg/pfblockerng/pfblockerng.inc, Line: 3958, Message: Call to a member function bindValue() on boolean @ 2018-07-05 13:11:20

BBcan177

@netgate-james said in PfBlockerNG-devel 2.1.2:

@netgate-james Also this in Alerts
PHP ERROR: Type: 1, File: /usr/local/pkg/pfblockerng/pfblockerng.inc, Line: 3958, Message: Call to a member function bindValue() on boolean @ 2018-07-05 13:11:20

I have only seen this on a few systems. So far the solution has been to change the SQLite3 PRAGMA journal_mode from "wal" to "delete". I haven't had much time to investigate the reason. Before I post a fix, I want to do some additional testing, however; you can test the following:

If you can edit the file:

/usr/local/pkg/pfblockerng/pfblockerng.inc

and change the following line 3842
https://github.com/pfsense/FreeBSD-ports/blob/devel/net/pfSense-pkg-pfBlockerNG-devel/files/usr/local/pkg/pfblockerng/pfblockerng.inc#L3842

From:

$db_handle->exec("PRAGMA journal_mode = wal;");

To:

$db_handle->exec("PRAGMA journal_mode = delete;");

netgate-james

@bbcan177 patch applied, will follow-up with results. Thank you BBcan177!!

netgate-james

@BBcan177 been looking good since applying the change. Apparently this popped up

Crash report begins. Anonymous machine information:

amd64
11.2-RELEASE
FreeBSD 11.2-RELEASE #28 5bbe95e97b4(factory-RELENG_2_4_4): Thu Jul 5 00:38:07 EDT 2018 root@buildbot3:/builder/crossbuild-master/pfSense/tmp/obj/builder/crossbuild-master/pfSense/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[06-Jul-2018 10:41:38 America/New_York] PHP Warning: SQLite3::exec(): database is locked in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3842

No FreeBSD crash data found.

No adverse behavior observed thus far.

Edit: Had another two of these same crash reports generate.

Edit: make that three .. still no adverse side-effects though.

vladimirlind

Pfsense (latest dev snap) keeps crashing with this warning on "Update" webgui tab :

Warning: Use of undefined constant pfb_status - assumed 'pfb_status' (this will throw an Error in a future version of PHP) in /usr/local/www/pfblockerng/pfblockerng_update.php on line 385 Warning: Use of undefined constant pfb_output - assumed 'pfb_output' (this will throw an Error in a future version of PHP) in /usr/local/www/pfblockerng/pfblockerng_update.php on line 392

vladimirlind

Here is the crashreport I caught:

Crash report begins. Anonymous machine information:

arm
11.2-RELEASE
FreeBSD 11.2-RELEASE #2 3f33035c36f(factory-RELENG_2_4_4): Tue Jul 10 15:36:43 EDT 2018 root@buildbot3:/builder/crossbuild-master/obj/armv6/C5dYt69Q/arm.armv6/builder/crossbuild-master/pfSense/tmp/FreeBSD-src/sys/pfSense-SG-3100

Crash report details:

PHP Errors:
[11-Jul-2018 15:33:20 Europe/Moscow] PHP Warning: Illegal string offset 'vip' in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 1128
[11-Jul-2018 15:33:21 Europe/Moscow] PHP Warning: Illegal string offset 'vtype' in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 6320
[11-Jul-2018 15:33:21 Europe/Moscow] PHP Warning: Illegal string offset 'key' in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 6321
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 6995
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 6995
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 6995
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 7000
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 7000
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 7000

No FreeBSD crash data found.

RonpfS

https://forum.netgate.com/topic/132659/php-warning-illegal-string-offset-vip-in-usr-local-pkg-pfblockerng-pfblockerng-inc-on-line-1128

Okijames

@bbcan177

amd64
11.1-RELEASE-p10
FreeBSD 11.1-RELEASE-p10 #13 r313908+293707af843(RELENG_2_4): Thu May 10 15:09:24 CDT 2018 root@buildbot2.netgate.com:/builder/ce-243/tmp/obj/builder/ce-243/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[11-Jul-2018 17:37:26 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 4053
[11-Jul-2018 17:37:28 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3958
[11-Jul-2018 17:37:28 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3958

No FreeBSD crash data found.

Details: This is on an APU2 and corresponds with (Jul 11 17:37:23 kernel pid 41538 (php), uid 0 inumber 6266 on /var: filesystem full) . I used default pfsense partitioning during installation and /var is 58MB. This on a 256GB mSATA SSD with >200GB free in /. Good times! :)

@netgate-james Did changing wal to delete fix the issue for you?

netgate-james

@okijames said in PfBlockerNG-devel 2.1.2:

@bbcan177

amd64
11.1-RELEASE-p10
FreeBSD 11.1-RELEASE-p10 #13 r313908+293707af843(RELENG_2_4): Thu May 10 15:09:24 CDT 2018 root@buildbot2.netgate.com:/builder/ce-243/tmp/obj/builder/ce-243/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[11-Jul-2018 17:37:26 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 4053
[11-Jul-2018 17:37:28 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3958
[11-Jul-2018 17:37:28 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3958

No FreeBSD crash data found.

Details: This is on an APU2 and corresponds with (Jul 11 17:37:23 kernel pid 41538 (php), uid 0 inumber 6266 on /var: filesystem full) . I used default pfsense partitioning during installation and /var is 58MB. This on a 256GB mSATA SSD with >200GB free in /. Good times! :)

@netgate-james Did changing wal to delete fix the issue for you?

See: https://forum.netgate.com/post/775962

The crashes are fewer and farther between, on a recent (not current) 2.4.4 snap (before php56 went to php72).

BBcan177

@okijames said in PfBlockerNG-devel 2.1.2:

@netgate-james Did changing wal to delete fix the issue for you?

If you have already changed "wal" to "delete" and are still experiencing those issues, can you try the following:

Delete the sqlite dbs and run a Force Reload - All to rebuild them.

rm /var/db/pfblockerng/dnsbl.sqlite*
rm /var/db/pfblockerng/dnsbl_cache.sqlite*
rm /var/db/pfblockerng/dnsbl_levent.sqlite*

Okijames

I have 4GB RAM so increasing /var RAMDISK to see what happens.

Okijames

Holding strong and working great at 26% of 250GB on /var.

bbrendon

@bbrendon said in PfBlockerNG-devel 2.1.2:

Any idea when this new version is going to be a "non-devel" version?

I ask because 2.1 has some really annoying bugs. I'm trying to decide how long I should hold out or just install the devel version.

jacotec

@bbrendon said in PfBlockerNG-devel 2.1.2:

I ask because 2.1 has some really annoying bugs. I'm trying to decide how long I should hold out or just install the devel Version

Same here, I went for the devel 2 weeks ago and I'm happy so far.
Take care to switch the update branch to "unstable" first and grab the devel from there, then you can switch the update branch back to stable (no need to go to unstable with pfSense itself).

Uninstall the 2.1 first, your settings will be preserved. I made a snapshot of my pfSense VM first so I felt really safe ;-)

4ROMANY

I've been having similar issues with this error:
/usr/local/pkg/pfblockerng/pfblockerng.inc: New alert found: PHP ERROR: Type: 1, File: /usr/local/pkg/pfblockerng/pfblockerng.inc, Line: 3958, Message: Call to a member function bindValue() on boolean.

Been happening for some time - not sure when it started - but I'm currently running 2.4.4-Dev. I made the change that was suggested - changing "wals" to "delete" - so I'll try to report back in a few days. When this PHP issue occurred CPU load for the PHP process would be very high - to the point you could not log in even via serial console. Most of the time you could log in but could not do anything - even reboot seems to hang.