2.4.4-RC - SquidGuard issue - Blacklist

[fabricioguzzy]

Gentlemen,
I just found an issue with the squidguard configuration using the 2.4.4-RC.
The squidGuard is not saving the blacklist categories on Web GUI, but it is still working (see image to understand)

How to reproduce it:
1- Install squid/squidguard packages and download/install your favorite blacklist.
2- After install/configure squid/squidguard at all, go to squidguard menu and create the first "Target Category" as required here --> https://forum.pfsense.org/index.php?topic=94312.0
3- Create the specific Default or Group_ACL rules using your Blacklist categories.
4 - Save it.
5- Exit the ACL screen, SAVE it again.
6- Go back to ACL screen (Group or Default) and you will see that the Target Rules List is all clear/empty. (as marked in yellow on the image), although the "Target Rules" is keeping the name of the categories and SquidGuard is working fine, blocking the categories as expected.

It seems like a "cosmetic" error due to new PHP version (maybe?) - IMPORTANT to say that it's only happening on 2.4.4-RC - 2.4.3-Release is working fine.

Regards
Fabricio.

[ProxyMoron]

Where did you get the RC from? Is it available yet?

[fabricioguzzy]

OK, I just found that someone else already reported the issue on redmine.

Bug #8752
https://redmine.pfsense.org/issues/8752

Thanks,
Fabricio

[ivor]

@ProxyMoron they've probably done a gitsync. We're working hard on RC, hopefully it's going to happen within the next few days.

[Carlos Renato Monteiro]

The problem is not specifically in the pfsense version, because I also have the problem with version 2.4.3_1 after upgrading the squidguard. It looks like the problem is in the file read code. Squidguard can write the files and apply the rules, but can not read the files to retrieve the rules for the interface.

[fabricioguzzy]

@Carlos-Renato-Monteiro -
Hello Renato, good to know. I didn't try it with 2.4.3 (production environment).

Thanks,
Fabricio.

[Carlos Renato Monteiro]

I'm trying to find the codes to analyze them. Maybe I can make a temporary fix until a release comes out. Probably must be a silly detail, like apostrophes. Some discrepancy between the recorded formats and what is expected in the reading.

[fabricioguzzy]

@Carlos-Renato-Monteiro
You can find the codes under Github:

https://github.com/pfsense/FreeBSD-ports/tree/RELENG_2_4_4/www/pfSense-pkg-squidGuard

[Carlos Renato Monteiro]

In my case the Target Rules field is filled out. The problem is with the Target Rules List. I tested the variable $ upt_val, which should contain the value of the rule, but it comes empty. In summary, the rules seem to be read from the file, but there is some problem filling in the variables passed to or in make_grid_controls. I'm having some difficulty because php is not the "my native language".

[Carlos Renato Monteiro]

I found and fixed the problem:

in the /usr/local/pkg/squidguard.inc file
on line 558
change: if (!empty ($val) && is_array ($val)) {
to: if (!empty ($val)) {

[fabricioguzzy]

@Carlos-Renato-Monteiro
Sounds good. I will test it here Renato.

[Carlos Renato Monteiro]

Save a backup of the file before editing it.

As a bonus, I changed the grid to show the rule name before the description, because I think it's better:

Line 799: $tbl .= "<td $color> [$name] $description </ td>";

if you use Target Categories for off-time (overtime), remove rows 580, 581, and 582.

[Carlos Renato Monteiro]

This post is deleted!

[fabricioguzzy]

@carlos-renato-monteiro it didn't work. Maybe because you are using 2.4.3 with the old php version. We got different behaviors.
i am also investigating from here.

Fabricio.

[Carlos Renato Monteiro]

If you want to post the file (changed), I'll help you check other things.

[skala]

This post is deleted!

[skala]

@fabricioguzzy

Estou com o mesmo problema, atualizei, funcionou tudo direitinho, porém quando vou em GroupACL na parte das Target Rules não aparecem as listas, e quando coloco na mão a regra simplesmente não é salva, e sempre fica no campo como "!all". Ou seja! não consigo usar as Groups ACL do SquidGuard.

Alguém ai com o mesmo problema?

[fabricioguzzy]

@skala - Sim, é um BUG que aconteceu depois da mudança de versão do php.
Já está postado lá no Forum em Português - Este aqui é só Inglês.

[Carlos Renato Monteiro]

Por isso não atualizei ainda o Pfsense. Só corrigi o bug do SquidGuard novo no 2.4.3.

[aguilaz55]

some update of this?
because is impossible to use squidGuard in 2.4.4 16 days ago!!!

[jimp]

Fixed in squidGuard pkg v 1.16.18 which is up now for 2.4.4-RELEASE and will show up with the next snapshots for 2.4.5-DEV

[Zilzir]

It was released version 1.16.18 that corrects this problem, it worked out right here for me pfsense 2.4.4, Thanks to all