24.03-DEVELOPMENT - PHP Fatal error: Uncaught ValueError: range(): Argument #3

[N0m0fud]

And:

PHP ERROR: Type: 1, File: /usr/local/www/pfblockerng/pfblockerng_category_edit.php, Line: 391, Message: Uncaught ValueError: range(): Argument #3 ($step) must be greater than 0 for increasing ranges in /usr/local/www/pfblockerng/pfblockerng_category_edit.php:391
Stack trace:
#0 /usr/local/www/pfblockerng/pfblockerng_category_edit.php(391): range(1, 17, -1)
#1 {main}
thrown

This is on the latest build

[N0m0fud]

Here is the actual line of code that is throwing the error:

$options_suppression_cidr = [ 'Disabled' => 'Disabled' ] + array_combine(range(1, 17, -1), range(1, 17, -1));

[N0m0fud]

And this line:

$list = array('Disabled' => 'Disabled') + array_combine(range(1, 17, -1), range(1, 17, -1));

Changing both instances to:

$list = array('Disabled' => 'Disabled') + array_combine(range(1, 17, 1), range(1, 17, 1));

Fixed the issue and allows editing, etc,

[N0m0fud]

And the DNSBL block stats are working as expected!!!

[DefenderLLC]

@N0m0fud Thanks. Unfortunately I'm running into the same problem with the newest 24.03 build and this fix did not work for me - even after a fresh pfBlockerNG or pfBlockerNG-dev install with no previous saves settings. The minute I try to add an IP category I get those same two errors - both on lines 391.

[pst]

@N0m0fud I can confirm that the problem still exists in "24.03-RC (amd64) built on Tue Apr 16 2:05:00 CEST 2024" with pfBlockerNG-devel 3.2.0_9

but the suggested fix on lines 391 and 1517 still works fine.

[Bob.Dig]

Problem still exists after the final Plus release. Is someone capable to create or show a system patch?

[pst]

@Bob-Dig In System Patches, add a new patch with these fields

Description:

pfblockerng_category_edit.php

Patch content:

--- pfblockerng_category_edit.php.orig  2024-04-24 09:39:00.112790000 +0200
+++ pfblockerng_category_edit.php       2024-04-21 13:48:03.625881000 +0200
@@ -388,7 +388,7 @@
                                        'disabled'      => 'Null Blocking (no logging)' ];
 }

-$options_suppression_cidr      = [ 'Disabled' => 'Disabled' ] + array_combine(range(1, 17, -1), range(1, 17, -1));
+$options_suppression_cidr      = [ 'Disabled' => 'Disabled' ] + array_combine(range(1, 17, 1), range(1, 17, 1));

 $interfaces_list               = get_configured_interface_list_by_realif();
 $src_interfaces                        = array('lo0' => 'Localhost');
@@ -1514,7 +1514,7 @@

 if ($gtype == 'ipv4') {

-       $list = array('Disabled' => 'Disabled') + array_combine(range(1, 17, -1), range(1, 17, -1));
+       $list = array('Disabled' => 'Disabled') + array_combine(range(1, 17, 1), range(1, 17, 1));
        $section->addInput(new Form_Select(
                'suppression_cidr',
                'Suppression CIDR Limit',

Path Strip Count:

0

Base Directory:

/usr/local/www/pfblockerng/

[Bob.Dig]

@pst At first sight, this seems to work. Thank you so much!

[SwissSteph]

Hello everyone,

I have the same problem. Just a question for the patch creation, is it necessary to copy ALL the text or only a part ... because I have the same problem if I put the totality of the text above.

Help!

[pst]

@SwissSteph I have updated my post, is it clearer now?

[SwissSteph]

@pst

Thank you for your reply.

I was right... BUT I have a big spit next if I want to edit

With or without the patch I get the same error

[24-Apr-2024 11:22:58 Europe/Zurich] PHP Fatal error: Uncaught ValueError: range(): Argument #3 ($step) must be greater than 0 for increasing ranges in /usr/local/www/pfblockerng/pfblockerng_category_edit.php:391
Stack trace:
#0 /usr/local/www/pfblockerng/pfblockerng_category_edit.php(391): range()
#1 {main}
thrown in /usr/local/www/pfblockerng/pfblockerng_category_edit.php on line 391
[24-Apr-2024 11:25:46 Europe/Zurich] PHP Fatal error: Uncaught ValueError: range(): Argument #3 ($step) must be greater than 0 for increasing ranges in /usr/local/www/pfblockerng/pfblockerng_category_edit.php:391
Stack trace:
#0 /usr/local/www/pfblockerng/pfblockerng_category_edit.php(391): range()
#1 {main}
thrown in /usr/local/www/pfblockerng/pfblockerng_category_edit.php on line 391
[24-Apr-2024 11:28:32 Europe/Zurich] PHP Fatal error: Uncaught ValueError: range(): Argument #3 ($step) must be greater than 0 for increasing ranges in /usr/local/www/pfblockerng/pfblockerng_category_edit.php:391
Stack trace:
#0 /usr/local/www/pfblockerng/pfblockerng_category_edit.php(391): range()
#1 {main}
thrown in /usr/local/www/pfblockerng/pfblockerng_category_edit.php on line 391

EDIT

I finally followed the very clear information from "graphene" in this post

https://forum.netgate.com/topic/187604/24-03-r-20240416-0005-unable-to-add-an-ipv4-entry-to-the-pfblockerng-configuration/6

and manually edited the two lines by removing the "-" before the "1".

It's all good, no more crashes when editing a line.

[Bob.Dig]

@pst said in 24.03-DEVELOPMENT - PHP Fatal error: Uncaught ValueError: range(): Argument #3:

I have updated my post

That looks perfect.

[pst]

@SwissSteph said in 24.03-DEVELOPMENT - PHP Fatal error: Uncaught ValueError: range(): Argument #3:

With or without the patch I get the same error

Did you press Apply after adding the patch in System Patches? It doesn't get applied just by adding it. The patch is the same code as you manually edited so it should have worked, if applied. The system patch works for me, and others.

[SwissSteph]

@pst

precisely ... no "apply" button, very strange indeed

[pst]

@SwissSteph Two of the fields are not correct, change to

Path Strip Count: 0

Base Directory: /usr/local/www/pfblockerng/

[SwissSteph]

@pst

I really suck ... and am very sorry to have taken up your time unnecessarily by poor handling and understanding on my part!!!!

Thank you for understanding my error put forward where I had made a mistake.

[pst]

@SwissSteph No worries :)

[SwissSteph]

@pst

To make something "clean", I re-edited the two lines, put all the "-" in front of the "1".

Created a "patch" with YOUR very clear instructions (thanks again!) and "applied" this patch.

So I confirm that your corrections also work very well for me.

THANKS

[N0m0fud]

@SwissSteph just wish the code would get fixed permanently.