DHCPd with multiple ipv4 subnets outside of local interface network. (300US$)

doktornotor · Jun 27, 2015, 9:07 AM

I have been reading this with interest, and checked the updates on the repository https://github.com/pfsense/pfsense/pull/816

Have you had a chance to resubmit Marcelloc?

While I cannot speak for marcelloc, let me note this: when you let something rot for ages and then close the pull req with "oh shit, it no longer applies" half year later, you generally do not get the contributor excited. When you do it twice in a row, getting the guy pissed off is almost guaranteed.

I find closing the pull request with "Patch has conflicts and cannot be merged." rather insulting, to put it mildly. No shit Sherlock, you've been sitting on it for 1,5 years. Now, do the legwork yourself, since it's your damned fault.

:(

bennyc · Jun 27, 2015, 7:43 PM

Bummer. So back to square one ::)

I'm finding it difficult to understand why it isn't present as a standard functionality, and also why it seems difficult to get it integrated.

Marcello, anything we (I) can do in helping to get this code ported to whatever version is needed? Seriously. I'm willing to spend some time on it.

– yes... edited own post... It had no added value in its original state :-X --

bennyc · Jul 20, 2015, 2:11 PM

Took me a while to find some time to check this out in depth, and found another "open" merge request:
https://github.com/pfsense/pfsense/pull/1406

Confused now. So it is still ongoing business? (hoping I'm right :) )

pedymaster · Aug 31, 2015, 12:55 PM

Hi,
Iam also watching the pull request and am interested in any news regarding this. I just hope, this work will not go to waste.

doktornotor · Aug 31, 2015, 1:01 PM

Those patches no longer apply. It'd need to be done yet again.

haddock · Sep 2, 2015, 9:19 AM

@doktornotor:

Those patches no longer apply. It'd need to be done yet again.

Jeez! Again, really? :o

I feel bad for Marcelloc.

How many times must he redo the same thing because of core team not merging?

Does anyone know why pfsense coreteam are so reluctant to merge this request?

I mean, its a really nice feature that only makes pfsense a better and more competetive product.

bennyc · Sep 2, 2015, 4:08 PM

Last version I got from Marcello works on 2.2.4.
Not sure what the problem is or why it is difficult to merge.
I too feel bad for the guy, 3 or 4 attempts, lost count in meantime ::)

bennyc · Oct 14, 2015, 11:54 AM

update: the latest version of the patch breaks IPSec. You'll end up with a nice error when you try to enable IPSec:```
Fatal error: Call to undefined function gen_subnetv4() in /etc/inc/vpn.inc


This is due to the modified util.inc, where the part gen_subnetv4() is missing in total. Haven't had this error earlier on previous ipsec activations, suspecting it originates or in the latest version of Marcello's patch (post pfSense2.2) or with StrongSwan implementation of IPSEC. (Racoon worked fine)

So now I have to decide on either have the good working dhcpd (which I need), or the IPSec (which I need)

why o why me  >:(

doktornotor · Oct 14, 2015, 12:47 PM

As already noted, that patch is (yet again) no longer applicable and I very much doubt marcelloc will bother with rewriting it for the zillionth time. The developers probably absolutely hate the idea of using pfSense as a DHCP server. Never seen such retarded handling of a contributed no-brainer feature.

mtisza · Feb 2, 2016, 8:12 PM

Marcello,

Are you interested in updating your changes in https://github.com/pfsense/pfsense/pull/1406 such that they can be merged to master? I'm willing to pay an additional bounty for the update. I tried doing it myself, but there was one conflicting commit in particular https://github.com/pfsense/pfsense/commit/b5f6e690d40d0e0b7e16fd4adddb92d04c402ad6 that threw me off.

Thanks.

haddock · Feb 3, 2016, 1:04 PM

I could also pay an additional bounty to see this get merged in 2.3. I'm still using this in 2.2.6 and would hate to lose the functionality when 2.3 is released.

However, I would like the "Additional BOOTP/DHCP Options" to be included in the additional subnets.

Currently its not visible at all, and options from primary interface does not get propagated.

I can pledge an additional 50 US$ from my end.

marcelloc · Feb 4, 2016, 9:32 PM

I'll pull the code once more to get merged on 2.3 .

haddock · Feb 8, 2016, 11:31 AM

@marcelloc:

I'll pull the code once more to get merged on 2.3 .

Great news! Thanks for not giving up.

Any update on a dhcp-options related fix to the code for 2.3?

Let us know when it is merged and I'll transfer the funds.

mtisza · Feb 10, 2016, 11:42 PM

@marcelloc:

I'll pull the code once more to get merged on 2.3 .

Awesome! I'll send $50 as well when it's ready for merge again.

CNLiberal · Feb 11, 2016, 4:26 PM

What can we do to get the devs to actually put this into pfSense instead of relying on a bounty?

kapara · Feb 22, 2016, 10:31 AM

Have you tried calling them? PfSense? I am sure someone at Netgate…etc might be able to get a response...

mtisza · Apr 2, 2016, 12:57 PM

Any luck getting the changes made?

Sylos · Sep 5, 2016, 6:53 AM

Any luck getting the changes made?

csutcliff · Sep 6, 2016, 7:13 PM

I'm still interested and willing to pay.

mphilippi · Mar 31, 2017, 10:53 PM

Any news on the pull request?

https://github.com/pfsense/pfsense/pull/1406

rbgarga commented on 4 Feb 2016
After discuss privately with @marcelloc he agreed to submit a fresh patch, tested on 2.3, and I'll review it as soon as it lands here

Is the "fresh patch" going to be integrated in 2.4?