DHCPd with multiple ipv4 subnets outside of local interface network. (300US$)

[bennyc]

I can hereby confirm the feature is working as requested in the bounty.
Tested the mod in following environment: x1250e running 2.1 & a couple of dhcp scopes configured outside of interface's subnet, c3560x doing L3 routing & ip-helper configured on some vlans pointing to pfsense.

• all config (pfsense anyway) can be done in gui
• dhcpd replies to correct (ip-helper) gateway, hands out IP in correct scope
• dhcp leases are visible, sorted on IP ascending, in same page (room for improvement here, if more scopes are used the list can get long/crowded)
• dhcp log page displays relevant information from all scopes (same here; leaves room for improvement)

example from dhcp log:
Sep 26 12:48:41 dhcpd: DHCPACK on 192.168.3.1 to 3x:cx:4x:cx:dx:8x (Win8Phone) via 192.168.3.254
Sep 26 12:48:41 dhcpd: DHCPREQUEST for 192.168.3.1 (192.168.1.254) from 3x:cx:4x:cx:dx:8x (Win8Phone) via 192.168.3.254

(yes my log is in reverse order  ;D)

Great work Marcelloc!

[shade]

Marcelloc:

We have tested the mod on a OPNsense Quad appliance box, running 2.1 with 2 scopes configured outsite the lan interface's subnet, a5406ZL handling the L3 routing & ip-helper pointing.

It took some time since we have alot of static dhcp entries that we need transfered to PFsense, and our finding is so far.

• dhcpd hands out the correct IP scopes, to the right vlans.
• config in sub scope (that used by os) are working.
• dhcp leases are shown, but buttons/links are not working*

• If you try to send a wake-on-lan by cliking the MAC it selects a wrong interface a says:

The following input errors were detected: A valid interface must be specified.

I can just correct the interface to LAN and press send then it works.

If we try to make a static by clicking the "add button", it just return to the start page of the dhcpd, that is not possible.

• logging of sub scopes works.

Sep 27 13:23:21 dhcpd: DHCPACK on 10.1.5.70 to 00:23:14:94:6e:bc (EUCBTPR-Pc) via em0
Sep 27 13:23:21 dhcpd: DHCPREQUEST for 10.1.5.70 from 00:23:14:94:6e:bc (EUCBTPR-Pc) via em0

(ours in also in reverse)

[shade]

@ermal:

You would probably have that development done from pfSense devs through support channel with the amount of 1600$.
For this feature it would not require more than that.

Please explain, won't it be possible for us to get the patch from marcelloc included upstream ? or….

[xbipin]

@shade:

@ermal:

You would probably have that development done from pfSense devs through support channel with the amount of 1600$.
For this feature it would not require more than that.

Please explain, won't it be possible for us to get the patch from marcelloc included upstream ? or….

+1

[marcelloc]

I will push it to 2.2 code since I have a positive feed from you. Core team will check the code and if it's ok, it can be merged.

[bennyc]

• If you try to send a wake-on-lan by cliking the MAC it selects a wrong interface a says:

Don't know about the button, but the "Wake on lan" as a feature inside those scopes but outside your interface subnet will not work I think. That also uses broadcast, and thus remains within your vlan…. or you need to do some additional configuration on your router by forwarding the broadcasts...

The buttons (like add static mapping) does a redirect to the main dhcp page, but the mapping is not present as you say (did not test that, don't use static mappings).

[shade]

@marcelloc:

I will push it to 2.2 code since I have a positive feed from you. Core team will check the code and if it's ok, it can be merged.

Sound great  :D

[shade]

@bennyc:

The buttons (like add static mapping) does a redirect to the main dhcp page, but the mapping is not present as you say (did not test that, don't use static mappings).

That we use alot :/ So it is important for me..

@bennyc:

Don't know about the button, but the "Wake on lan" as a feature inside those scopes but outside your interface subnet will not work I think. That also uses broadcast, and thus remains within your vlan…. or you need to do some additional configuration on your router by forwarding the broadcasts...

You can configure that in your core so WOL packets can get from one vlan to another…

[marcelloc]

@shade:

That we use alot :/ So it is important for me..

I'll check it today.

[shade]

@marcelloc:

@shade:

That we use alot :/ So it is important for me..

I'll check it today.

Thanks :)

[marcelloc]

I've sent you modified files including dhcp leases update.

Please test and feedback.

[bennyc]

as already confirmed through pm  :)

I already updated my system with your code, and can confirm it works.

Test sequence:

• add device on the network
• obtained lease from additional pool
• go to the DHCP leases page, select "+" next to the address of interest
• arrived on the "Services: DHCP: Edit static mapping" page, where you can edit/save the mapping
• entry is added in the dhcpd.conf file as follows:

host s_lan_0 {
	hardware ethernet 3c:c2:43:ca:xx:xx;
	fixed-address 192.168.3.1;
	option host-name "Win8Phone";
}

• afterwards, this host shows as static in "Status: DHCP leases", and the "+" sign is red and inactive

[shade]

Marcelloc:

I have updated my PFsense with your patch, and can confirm that it works.

Now static leases on subnet and WOL works.

Looking forward to see it in upstream - Excellent work, two thumbs up :)

WetWilly: Have you tried it ?

[marcelloc]

Pull request sent. ;D

I had to change some parts for 2.2 but it's done again!

https://github.com/pfsense/pfsense/pull/816

[shade]

Marcelloc:

I have now added several "sub" scopes, and alot of static leases and everything works as excepted :)

It is first time I have tried a bounty and are also a "new" pfsense user, so I have a few mabee newbie questions:

• When 2.1.1 are leases, are the patch still active ? or shall it be reapplied ? or is it even compatible ?
• Will that be the same for each release up to 2.2 when is it included upstream ?
• I have read the guidelines about payment and are a little confused  ? Can I just sent you a paypal payment, or is that against policy ?

To the other creators of this bounty, I feel the bounty is solved, how about you ?

[marcelloc]

@shade:

• When 2.1.1 are leases, are the patch still active ? or shall it be reapplied ? or is it even compatible ?

If there is no changes to files I've modified between 2.1 and 2.1.1 it will work fine.

@shade:

• Will that be the same for each release up to 2.2 when is it included upstream ?

Since pull request is merged. It will be part of pfsense 2.2

@shade:

• I have read the guidelines about payment and are a little confused  ? Can I just sent you a paypal payment, or is that against policy ?

Just send to my paypal account. marcellocoutinho@gmail.com

[bennyc]

I agree with Shade, the bounty is completed I think. (though I'm not an autor)
If Marcelloc gets all his payments, the bounty can be moved to the "completed" section…

[marcelloc]

@bennyc:

If Marcelloc gets all his payments, the bounty can be moved to the "completed" section…

Not yet. I received only from you and shade.

Total bounty US$ 1.100 received US$ 550

[bennyc]

Hi Marcelloc,

I know it's already been a while, but I think I encountered  a couple of things we missed.
Sub-pools work fine… but when adding a static mapping for a client in a sub-pool, it does not hand out WINS/DNS: not the default, not the ones I put there. (not so good  ::) )
It also doesn't complain if I use an ip within the pool range? (can live with that)
When removing the static mapping (but leaving it in the sub-pool), the dhcp deamon hands out both fine.

So the issue is on the static mapping creation. (writing to the dhcpd.conf to be more precise, at least I think it is)

When looking to the dhcpd.conf, it gets written correctly except for the option "domain-name-server", that part is missing even if I update it in the static mapping (it does not add it to the part "host s_lan_0":

(partial code)

host s_lan_0 {
	hardware ethernet 00:50:56:ad:6f:c1;
	fixed-address 192.168.9.11;
	option host-name "REMOTE-7";
	option routers 192.168.9.254;
}
subnet 192.168.9.0 netmask 255.255.255.0 {
	pool {
		option domain-name-servers 192.168.1.254;
		option routers 192.168.9.254;
		range 192.168.9.1 192.168.9.10;
	}

Went through the code from services_dhcp.php (quickly) as I suspect the issue is there (might be wrong), but it seems my coding knowledge is still too limited, can't point it out yet  :-[

Can you still check this please?

tnx & br, Benny.

[marcelloc]

Sorry for the late response.
I'm really busy these days but I'll take a look as soon as possible.