Crash report after upgrading to 2.6 yesterday

mbentley

@gertjan We are talking about https://github.com/jaredhendrickson13/pfsense-api as that is probably where the file is being modified from to specifically see this behavior, at least it was in my case - unsure about everyone else. I understand the update process and files being overwritten. The pfsense-api package also replaces the system.inc file with a custom one to support the package. Replacing the file from source would break the pfsense-api package which is not what is wanted here.

So it is likely that nothing went wrong during upgrade, the pfsense-api package hasn't included all of the changes since 2.6.0 was released as I am pretty sure the 2.6.0 package was just sort of a best effort, built for 2.6.0 package that wasn't really fully vetted.

Gertjan

@mbentley said in Crash report after upgrading to 2.6 yesterday:

https://github.com/jaredhendrickson13/pfsense-api

Dono who or what that is.
That is not a Netgate Official source. Just some guy who tries to implement an "Rest API" (good initiative btw, but it will take him years if he works 24/24h on it).

Now I fully understand the why part of the issue.
https://github.com/jaredhendrickson13/pfsense-api/issues/199

What I don't understand : if you install and use a native - non modified - pfSense, the issue doesn't exist.
When you install X, pfSense breaks.
My advise will be : repair X, or don't use it.

camelsaq

@gertjan although I did have that api package installed, I received the error from outside of the API and inside pfsense. In fact I couldn't even access DHCP services under that menu with similar errors.

I also uninstalled the API before reverting and still received error above

mbentley

@camelsaq So did you upgrade pfsense with the API installed the pfsense-api package and still received the error? If so, I am guessing that it would be because of how the install and removal functions - looks like it takes a backup of the original on install and on removal of the package, it copies it back which would align with your experience as it would be putting back the 2.5.2 file on top of 2.6.0 if I understand the process.

camelsaq

@mbentley yes when I upgraded to 2.6 the API was installed.

camelsaq

@mbentley when I reverted I did a factory reset back to the USB image. When restoring config backup from before I upgraded to 2.6 this did have the API and possibly had some API stuff in it. I did not receive error on 2.5.2 after restoring config, but did need to install the API back in order to get that working again.

Thanks so much for the insights here.

mbentley

@camelsaq Sure thing - helpful to get your experience to see how it aligns with mine. Upon closer inspection, I see that there isn't an override file specific for 2.6.0 yet which I missed when installing the 2.6.0 pfsense-api package which explains why it uses what is the default "older" version of of the system.inc file:

pkg add https://github.com/jaredhendrickson13/pfsense-api/releases/download/v1.3.3/pfSense-2.6-pkg-API.txz && /etc/rc.restart_webgui
Fetching pfSense-2.6-pkg-API.txz: 100%  230 KiB 235.2kB/s    00:01
Installing pfSense-pkg-API-1.3_3...
Extracting pfSense-pkg-API-1.3_3: 100%
Saving updated package information...
done.
Loading package configuration... done.
Configuring package components...
Custom commands...
Menu items... done.
Writing configuration... done.
Creating backups of files to override... done.
Checking pfSense version... done.
WARNING: No overrides exist for 2.6.0-RELEASE, it may be unsupported. Using default overrides.
Installing default file overrides... done.
...

So yeah, that aligns a bit more with staying on 2.5.2 if you need a functional pfsense-api package without hacking it.

Gertjan

@camelsaq said in Crash report after upgrading to 2.6 yesterday:

back to the USB image. When restoring config backup

At that comment, you have the original /etc/inc/system.inc
If this file is broken, or or does't contain what it should contain, your pfSense wouldn't even boot up. Ir's pretty critical.

Also, the function "check_dnsavailable" was added in 2.6.0 - and used since then in several other places. The API software changes core files on a pfSense ? ( ?? ! ???? ) I tend to say that you are not using pfSense any more.
So why even considering posting question here ;))

Be careful, guys, when you use an external piece of software not written for the current pfSense software, you have a shoot in the foot situation.
This is valid for pfSense packages, and everything else.

Edit : the subject of this thread is wrong - please edit it.
pfSense 2.6.0 didn't crash.
This is a "don't do this" issue that didn't end well.
Happens.
Tried X - X didn't work out. Ditched X for the time being. NeXt.

lizznl

@mbentley I removed the pfsense-api package for now and all works fine again after rebooting.

Hope there will come a patch on the pfsense-api side since I started to like pfsense even more when able to use API commands.. Else maybe consider something else which does support API natively.

camelsaq

@lizznl good to hear. For some reason I did not reboot after I removed API package and instead reverted pfsense version. May try to upgrade again and uninstall API first.

mbentley

@lizznl Looks like the author of pfsense-api just released a patched version (1.3.4) that adds support for 2.6.0. Here he mentioned that he tends to aim for adding the new API version within a few weeks of a release.