The firewall encountered an error after upgrading to 23.01

hugoeyng

@yaw I noticed, readind anothers topics, that pfBlocker, Snort and some others are affected in the same way.

matyi.szabolcs

Hello Everyone!
I am experiencing the same error:

>>> Upgrading pfSense-pkg-squidGuard... 
Updating pfSense-core repository catalogue...
pfSense-core repository is up to date.
Updating pfSense repository catalogue...
pfSense repository is up to date.
All repositories are up to date.
Checking integrity... done (0 conflicting)
The following 1 package(s) will be affected (of 0 checked):

Installed packages to be REINSTALLED:
	pfSense-pkg-squidGuard-1.16.18_20 [pfSense]

Number of packages to be reinstalled: 1
[1/1] Reinstalling pfSense-pkg-squidGuard-1.16.18_20...
[1/1] Extracting pfSense-pkg-squidGuard-1.16.18_20: .......... done
Removing squidGuard components...
Menu items... done.
Services... done.
Loading package instructions...

Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1124
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1045): convert_pfxml_to_sgxml_destination(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(1068): require_once('/usr/local/pkg/...')
#3 /etc/rc.packages(80): delete_package_xml('squidGuard', 'deinstall')
#4 {main}
  thrown in /usr/local/pkg/squidguard.inc on line 1124
PHP ERROR: Type: 1, File: /usr/local/pkg/squidguard.inc, Line: 1124, Message: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1124
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1045): convert_pfxml_to_sgxml_destination(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(1068): require_once('/usr/local/pkg/...')
#3 /etc/rc.packages(80): delete_package_xml('squidGuard', 'deinstall')
#4 {main}
  thrownpkg-static: DEINSTALL script failed
Saving updated package information...
overwrite!
Loading package configuration... done.
Configuring package components...
Loading package instructions...

Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1124
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1045): convert_pfxml_to_sgxml_destination(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(868): require_once('/usr/local/pkg/...')
#3 /etc/rc.packages(76): install_package_xml('squidGuard')
#4 {main}
  thrown in /usr/local/pkg/squidguard.inc on line 1124
PHP ERROR: Type: 1, File: /usr/local/pkg/squidguard.inc, Line: 1124, Message: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1124
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1045): convert_pfxml_to_sgxml_destination(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(868): require_once('/usr/local/pkg/...')
#3 /etc/rc.packages(76): install_package_xml('squidGuard')
#4 {main}
  thrownpkg-static: POST-INSTALL script failed
>>> Cleaning up cache... done.
Success

matyi.szabolcs

Could this be a PHP bug?

[23.01-RELEASE][root@unix.fw]/root: /usr/local/bin/php -f /etc/rc.packages pfSense-pkg-squidGuard DEINSTALL
Removing squidGuard components...
Menu items... done.
Services... done.
Loading package instructions...

Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1124
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1045): convert_pfxml_to_sgxml_destination(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(1068): require_once('/usr/local/pkg/...')
#3 /etc/rc.packages(80): delete_package_xml('squidGuard', 'deinstall')
#4 {main}
  thrown in /usr/local/pkg/squidguard.inc on line 1124
PHP ERROR: Type: 1, File: /usr/local/pkg/squidguard.inc, Line: 1124, Message: Uncaught TypeError: Cannot access offset of type string on string in /usr/local/pkg/squidguard.inc:1124
Stack trace:
#0 /usr/local/pkg/squidguard.inc(1045): convert_pfxml_to_sgxml_destination(Array)
#1 /usr/local/pkg/squidguard.inc(93): convert_pfxml_to_sgxml()
#2 /etc/inc/pkg-utils.inc(1068): require_once('/usr/local/pkg/...')
#3 /etc/rc.packages(80): delete_package_xml('squidGuard', 'deinstall')
#4 {main}
  thrown[23.01-RELEASE][root@unix.fw]/root

yaw

Not sure.. probably need to open a new bug for squidguard on redmine. I tried creating an account this evening, but I'm having issues with the confirmation email.

Edit: I opened a new bug report on redmine. Maybe that will help get some attention on this issue.

hugoeyng

@matyi-szabolcs I don't think It os a PHP bug. It seems, to me, one from this:

some type pra funtion that the current verison of PHP does not support
the installattion/updating process conflicts with some other running process that is using the resource/file.

JonathanLee

@hugoeyng I have the same issue, when ever I try to save the Squid configuration it give this error.

JonathanLee

@yaw I have removed and reinstalled as soon as you save the configuration it fails

JonathanLee

@yaw

I have the same issue with I save Squid config changes. Thanks for opening the redmine ticket. Everything works until I save the proxy config

PHP_errors.txt

JonathanLee

@yaw should I open a pfSense ticket and reinstall from a USB or will this result in the same issue?

(Image: error when you try to save the Squid config changes)

yaw

@jonathanlee I don't think reinstalling from USB will help. I think the developers are going to need to fix this and update the squid and squidguard packages. You can try opening a ticket if you have a support agreement.

JonathanLee

@yaw I opened a TAC ticket with Netgate. I cannot do a reinstall right now, my family will be mad at me.

https://forum.netgate.com/topic/178036/23-01-squid-issue/3?_=1676773067228

I have a thread open also same issue.

TAC had me perform a BareMetal install via USB drive and reinstall the configuration after, and it cleared up a lot of my issues. The in-place upgrade did not fully install from what their team said last night, it never fully completed.

With the fresh install it is working fine for now.

hugoeyng

@jonathanlee When I open the webGUI a warning message, about the crash error, is showed to me.

And if I try to reinstall the Squid Proxy Filter the crash error message is showed in the "installation progress box"

JonathanLee

@hugoeyng do you have the error? I had to resave reverse proxy because it was blank before the update and save the config as that was missing for me, after update it.

Dobby_

Upgrade from 22.05 (zfs) to 23.01 (zfs)
-- reboot
-- go in console (8) and type pfSense-upgrade
-- reboot again
-- go in console type in pkg update and pkg upgrade
-- reboot again

All failures went away (my settings) only higher cpu, ram and swap usage was there for a while. Perhaps, it could help you out of your situation. I must restart the ClamD, snort and unbound once, but after reboot they were working automatically again.

matyi.szabolcs

@dobby_

It is unnecessary because PHP8.1 is not compatible with the current code.

hugoeyng

@jonathanlee I read about this above and I did it. No success.

hugoeyng

@dobby_ thank you, but did not work for me.

Dobby_

@matyi-szabolcs
There for it is an 23.01 RC release candidate I think

At my upgrade it went one times wrong with two pkg´s
and after rebooting and upgrading over the console with
pfSense-upgrade and a reboot I must even type in the
admin and password by hand, but after pkg upgrade the
two packets were upgraded and rebooting again brought
me no errors again and it was like before showing the console without typing in something by hand.

The only one I got is now this one, but not related to this topic

Crash report begins.  Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #0 plus-RELENG_23_01-n2xxxxx-6xxx487xxxx: Fri Feb 10 20:30:29 UTC 2023     root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/obj/amd64/VDZvZksF/var/jenkins/workspace/pfSense-Plus-snapshots-23_01-main/sources/FreeBS

Crash report details:

PHP Errors:
[16-Feb-2023 21:45:51 Europe/Berlin] PHP Fatal error:  Uncaught TypeError: Unsupported operand types: string / float in /usr/local/www/widgets/widgets/ntp_status.widget.php:90
Stack trace:
#0 {main}
  thrown in /usr/local/www/widgets/widgets/ntp_status.widget.php on line 90



No FreeBSD crash data found.

matyi.szabolcs

@dobby_

I wrote earlier that the code is not compatible with PHP 8.1.

This is causing all the errors at the moment.
Tt's not just SquidGuard that has a problem.

A major code update is needed here.

hugoeyng

@matyi-szabolcs Did you read something about if /when that "major code update" will be avaliable ?