pfBlockerNG-devel v3.2.0 crashing repeatedly on pfSense 23.01

mcury

Got some errors too, while changing the MaxMind Localized Language and setting the MaxMind License Key:

PHP ERROR: Type: 1, File: /usr/local/www/pfblockerng/pfblockerng.php, Line: 1980, Message: Uncaught TypeError: sort(): Argument #1 ($array) must be of type array, null given in /usr/local/www/pfblockerng/pfblockerng.php:1980
Stack trace:
#0 /usr/local/www/pfblockerng/pfblockerng.php(1980): sort(NULL, 2)
#1 /usr/local/www/pfblockerng/pfblockerng.php(229): pfblockerng_get_countries()
#2 {main}
thrown @ 2023-02-16 14:36:30

xpxp2002

@bbcan177 My apologies. I did not see your post earlier.

It is breaking my /24s out into individual addresses, so the output is quite long. I will send you a PM in a minute.

xpxp2002

@BBcan177 dug in and identified the behavior is coming from code outside of pfBlockerNG and forwarded that info to a pfSense dev.

I have several IPv6 VIPs that were in the short form (e.g. along the lines of fd00:0:0:1::1/64). The :: abbreviation seems to trigger the issue when pfb_local_ip() function runs.

I changed those VIPs to a more expanded string (fd00:0:0:1:0:0:0:1/64, for example) to see if that works around the issue. So far, I have not encountered an error, but I'll know for sure after an hour or so passes.

paoloest

@bbcan177
Just updated and pfblockerng-devel is not starting anymore.


PHP ERROR: Type: 1, File: /usr/local/www/pfblockerng/pfblockerng.php, Line: 1980, Message: Uncaught TypeError: sort(): Argument #1 ($array) must be of type array, null given in /usr/local/www/pfblockerng/pfblockerng.php:1980
Stack trace:
#0 /usr/local/www/pfblockerng/pfblockerng.php(1980): sort(NULL, 2)
#1 /usr/local/pkg/pfblockerng/pfblockerng_install.inc(40): pfblockerng_get_countries()
#2 /etc/inc/pkg-utils.inc(781) : eval()'d code(1): include_once('/usr/local/pkg/...')
#3 /etc/inc/pkg-utils.inc(781): eval()
#4 /etc/inc/pkg-utils.inc(899): eval_once('include_once('/...')
#5 /etc/rc.packages(76): install_package_xml('pfBlockerNG-dev...')
#6 {main}

Thanks for your work and commitment delivering such a wonderful package

dotOne

After reboot issue persists…

Uncaught ValueError: str_repeat(): Argument #2 ($times) must be greater than or equal to 0 in /usr/local/share/pear/Net/IPv6.php:684

slever

My error seems to have gone away. Reboot perhaps?

NightlyShark

@paoloest I have a suspicion that something is not getting set correctly by the install script from the browser because of a lack of a check for it, or, part of the installer page is not updated in browser (loaded from cache from a previous version)? Maybe try with another browser (one that has never connected to pfsense) or clear cache and cookies in browser? Just a thought.

SteveITS

@paoloest said in pfBlockerNG-devel v3.2.0 crashing repeatedly on pfSense 23.01:

#1 /usr/local/pkg/pfblockerng/pfblockerng_install.inc(40): pfblockerng_get_countries()

Per https://redmine.pfsense.org/issues/13950, will be fixed in v3.2.0_2.

William 0

Out of curiosity….those having issues, did you uninstall pfblocker before the upgrade? If not make sure you do. You will avoid these issues.

paoloest

@william-0
nope, have not installed any package.

Deleted pfblockerng-devel and installed the non-devel, but no change. I hope for next version to fix this

dotOne

@william-0 Unfortunately that is not the case.
I did my other firewalls, removed the package before upgrading and reinstalled afterwards.
Same issue.

Hope this will be resolved quickly

xpxp2002

@dotone said in pfBlockerNG-devel v3.2.0 crashing repeatedly on pfSense 23.01:

After reboot issue persists…

Uncaught ValueError: str_repeat(): Argument #2 ($times) must be greater than or equal to 0 in /usr/local/share/pear/Net/IPv6.php:684

Did you happen to check for any short-form IPv6 addresses or VIPs in your environment? In my post above, it was the collapsed (::) format in some VIPs I had configured that the code didn't like. Expanding those to a full 8 segments resolved the issue for me.

https://forum.netgate.com/post/1087014

dotOne

@xpxp2002 I changed all CARP IPv6 address to full notation.
That did the job.

Although, I see pfBlockerNG inserts an incorrect formatted IPv6 address.
The leading double colon is correct, 2nd part of the address is dotted notation.

Thanks

BBcan177

@dotone I have a fix for this now. Working on packaging this for the next version:

curl -o /usr/local/pkg/pfblockerng/pfblockerng.inc "https://gist.githubusercontent.com/BBcan177/b735258a1267995046aab45aeaedc210/raw"

paoloest

@bbcan177

the new version fixed my issue

thanks a lot. Great and super duper fast job