edit icmp firewall rule nat generated failed

[tim4532]

hi all,

i found this bug (maybe) when i am trying to setup syslog client and enable logging on all my firewall rules. i found out when trying to edit the ICMP firewall rule on WAN tab generated by NAT rule. pfsense crashed with php error:

PHP ERROR: Type: 1, File: /usr/local/www/firewall_rules_edit.php, Line: 485, Message: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /usr/local/www/firewall_rules_edit.php:485

firewall_rules_edit.php line 485:
if (($_POST['proto'] == "icmp") && count($_POST['icmptype'])) {

Rule details (generated by NAT rule):
Action: Pass
Interface: WAN_VLAN
Protocol: ICMP
ICMP type: Any
Source: allowedHost_alias
Destination: [MY WIRELESS ROUTER]
No Logging

I wonder if this is a bug or any misconfiguration? anyone happening the same?

[marcosm]

An issue report is available here:
https://redmine.pfsense.org/issues/14267