Any ICMP syntax error bug
-
Using 2.3.3.a.20170112.0746 I think I have found a bug:
While adding an ICMP rule to an interface I get this error only if I select ICMP Subtypes any, if I manually select the ICMP Subtypes its fine:
There were error(s) loading the rules: /tmp/rules.debug:257: syntax error - The line in question reads [257]: pass in quick on $WLANG inet proto icmp from 192.168.14.0/24 to 192.168.14.1 icmp-type any tracker 1484561787 keep state label "USER_RULE: Allow Gateway Ping"
-
That is a problem. It was fixed for 2.4-BETA a few days ago. The fix needs to be back-ported to 2.3.3-DEVELOPMENT.
You can find the matching place in /etc/inc/filter.inc from this commit and make the same change in you 2.3.3 code:
https://github.com/pfsense/pfsense/commit/007cfb6ab6d7733c7a98d8fc5baae59028753107 -
Brilliant thanks, its not a big issue for me just though I would let you guys know.
-
Merged to RELENG_2_3. Thanks!