Error after upgrade to RC 23.05 (13May)
-
Dashboard not working: no widgets displayed apart from RSS which shows this message:
Fatal error: Uncaught TypeError: array_slice(): Argument #3 ($length) must be of type ?int, string given in /usr/local/pfSense/include/vendor/simplepie/simplepie/src/SimplePie.php:3165 Stack trace: #0 /usr/local/pfSense/include/vendor/simplepie/simplepie/src/SimplePie.php(3165): array_slice(Array, 0, '3') #1 /usr/local/pfSense/include/vendor/simplepie/simplepie/src/SimplePie.php(2997): SimplePie\SimplePie::merge_items(Array, 0, '3', 0) #2 /usr/local/www/widgets/widgets/rss.widget.php(109): SimplePie\SimplePie->get_items(0, '3') #3 /usr/local/www/index.php(430): include('/usr/local/www/...') #4 {main} thrown in /usr/local/pfSense/include/vendor/simplepie/simplepie/src/SimplePie.php on line 3165 PHP ERROR: Type: 1, File: /usr/local/pfSense/include/vendor/simplepie/simplepie/src/SimplePie.php, Line: 3165, Message: Uncaught TypeError: array_slice(): Argument #3 ($length) must be of type ?int, string given in /usr/local/pfSense/include/vendor/simplepie/simplepie/src/SimplePie.php:3165 Stack trace: #0 /usr/local/pfSense/include/vendor/simplepie/simplepie/src/SimplePie.php(3165): array_slice(Array, 0, '3') #1 /usr/local/pfSense/include/vendor/simplepie/simplepie/src/SimplePie.php(2997): SimplePie\SimplePie::merge_items(Array, 0, '3', 0) #2 /usr/local/www/widgets/widgets/rss.widget.php(109): SimplePie\SimplePie->get_items(0, '3') #3 /usr/local/www/index.php(430): include('/usr/local/www/...') #4 {main} thrown
-
@pst fixed by changing file /usr/local/www/widgets/widgets/rss.widget.php on line 49, adding the int cast:
$max_items = (int)$user_settings['widgets'][$widgetkey]['rssmaxitems'];
-
@pst on version 23.05.r.20230513.0132
-
@pst this still occurs with 23.05.r.20230513.1527. Can easily be reproduced by configuring the number of stories shown in the RSS widget (3 in my case)
-
@pst
I wonder if you have hit this, Regression #14365? PHP error in RSS widget after saving settings -
-
It is that issue. It's already fixed. There are three places that needs to be applied. See the change-set on the bug report.
Steve
-
That change was only in the master branch for 23.09, but I've picked it back for 23.05 now since we have to do another round of builds.
