haproxy broken after update to 2.8.0: nbproc is not supported any more...
-
@eduardomozart said in haproxy broken after update to 2.8.0: nbproc is not supported any more...:
@Darkk I was facing the issue stated at https://forum.netgate.com/topic/180409/can-t-update-pfsense-or-install-packages/ so I was unable to install packages from webUI but was able to install them through CLI.
Ok, there might be some differences because I am running the pfsense plus version 23.05.1-RELEASE (amd64) .
-
What is nbproc 1?
I feel iffy editing without knowing the full impact. Im glad there’s a fix. Would prefer a package fix of course -
@Darkk it’s the processor count (cores) you want haproxy using.
-
@michmoor nbproc was deprecated in HAProxy. For more information on what it is, you can go here: http://cbonte.github.io/haproxy-dconv/1.7/configuration.html#nbproc
Hopefully, this gets fixed soon.
-
@davidi Maybe this update should be pulled till it's fixed?
-
@Darkk Ya, maybe the pfSense devs should pull this package. If you go here: https://github.com/pfsense/FreeBSD-ports/pull/1153
It looked liked it was fixed in pfSense+. Doesn't look like those changes made it to the package being offered for pfSense 2.7
I'm sure the devs will fix it in no time. At least it's running for me right now when I do it manually.
-
@davidi Awesome! didn't know about the Diagnostics->Edit File, thanks for sharing
-
@davidi Ya, not sure why the update didn't get put in because I updated it like couple of hours ago on 23.05.1-RELEASE (amd64) which broke it. Ah well. Least it was an easy fix.
-
@nartn thanks for your workaround, it works!
-
This problem still happens in pfsense+ 23.05.1-RELEASE (arm64) built on Wed Jun 28 03:57:42 UTC 2023 FreeBSD 14.0-CURRENT,
with package HAProxy net 0.62_1 / haproxy-2.7.6.The fix presented in this thread works fine.
-
Hi,
Today I updated the HAPROXY package as it was informing to update. After updating the package all my addresses are not accessible any more and the service stopped. It is not possible to start the service. When saving the config I get the following:
Errors found while starting haproxy
[NOTICE] (47115) : haproxy version is 2.7.8-58c657f
[NOTICE] (47115) : path to executable is /usr/local/sbin/haproxy
[ALERT] (47115) : config : parsing [/var/etc/haproxy_test/haproxy.cfg:8] : nbproc is not supported any more since HAProxy 2.5. Threads will automatically be used on multi-processor machines if available.
[ALERT] (47115) : config : Error(s) found in configuration file : /var/etc/haproxy_test/haproxy.cfg
[ALERT] (47115) : config : Fatal errors found in configuration.I tried commenting out the nbproc in the .cfg but still not able to start the service.
Anyone any idea how to fix this and where?
Thanx in advance
-
-
Hi,
Today I updated the HAPROXY package as it was informing to update. After updating the package all my addresses are not accessible any more and the service stopped. It is not possible to start the service. When saving the config I get the following:
Errors found while starting haproxy
[NOTICE] (47115) : haproxy version is 2.7.8-58c657f
[NOTICE] (47115) : path to executable is /usr/local/sbin/haproxy
[ALERT] (47115) : config : parsing [/var/etc/haproxy_test/haproxy.cfg:8] : nbproc is not supported any more since HAProxy 2.5. Threads will automatically be used on multi-processor machines if available.
[ALERT] (47115) : config : Error(s) found in configuration file : /var/etc/haproxy_test/haproxy.cfg
[ALERT] (47115) : config : Fatal errors found in configuration.I tried commenting out the nbproc in the .cfg but still not able to start the service.
Anyone any idea how to fix this and where?
Thanx in advance
-
Ok, found a temporary solution:
ssh to pfsense edit /var/etc/haproxy/haproxy.cfg and delete the line "nbproc 1" run haproxy from command line: haproxy -f /var/etc/haproxy/haproxy.cfgShould be good to go for the time being.
Chris
-
Ok,
temporary solution found:
ssh to pfsense edit /var/etc/haproxy/haproxy.cfg and delete the line "nbproc 1" run haproxy from command line: haproxy -f /var/etc/haproxy/haproxy.cfgWould be nice if there will be a permanent solution.
Cheers,
Chris
-
@Pierre-0 Ditto for me. But when will this be properly patched?
-
Can you tell me how you applied the update from above? I'm in the haproxy.inc file, but I am not sure exactly "where" I should place that information. Perhaps if you have a screenshot of how you placed it so I have something to reference? I appreciate the help!
-
The fix with the edit of the .cfg didnt work for me. I tried restarting the service and got the following error
This is a very bad package update...edit: i was expecting to re-apply my changes again which breaks the package. So after i run haproxy -f /var/etc/haproxy/haproxy.cfg then everything works but you cannot make any further changes in the GUI until theres a fix
haproxy: startup error output!: [NOTICE] (94268) : haproxy version is 2.7.6-4dadaaa[NOTICE] (94268) : path to executable is /usr/local/sbin/haproxy[ALERT] (94268) : config : parsing [/var/etc/haproxy/haproxy.cfg:9] : nbproc is not supported any more since HAProxy 2.5. Threads will automatically be used on multi-processor machines if available.[ALERT] (94268) : config : Error(s) found in configuration file : /var/etc/haproxy/haproxy.cfg[ALERT] (94268) : config : Fatal errors found in configuration. -
I just came to report this also. I couldn't get the fix mentioned to work. I'm just running defaults for threading so I removed the lines that wrote out nbproc and nbthread. So I removed these starting at 1495.
// Set numprocs if defined or use system default (#cores) $numprocs = $a_global['nbproc'] ? $a_global['nbproc'] : "1"; $numthread = $a_global['nbthread'] ? $a_global['nbthread'] : "1"; fwrite ($fd, "\tnbproc\t\t\t{$numprocs}\n"); if (haproxy_version() >= "1.8") { fwrite ($fd, "\tnbthread\t\t\t{$numthread}\n"); } -
To bad its also dead at my end after the update.
haproxy: startup error output!: [NOTICE] (74851) : haproxy version is 2.7.6-4dadaaa[NOTICE] (74851) : path to executable is /usr/local/sbin/haproxy[ALERT] (74851) : config : parsing [/var/etc/haproxy/haproxy.cfg:8] : nbproc is not supported any more since HAProxy 2.5. Threads will automatically be used on multi-processor machines if available.[ALERT] (74851) : config : Error(s) found in configuration file : /var/etc/haproxy/haproxy.cfg[ALERT] (74851) : config : Fatal errors found in configuration.Workarround
For those that do not want to SSH, you can do it from the pfSense GUI by going to Diagnostics->Edit File, make the change manually, then go to Diagnostics->Command Prompt and run: haproxy -f /var/etc/haproxy/haproxy.cfg@stephenw10 is the team aware of this bug? Do you want a redmine bug report?
