Acme DNS-NSupdate / RFC 2136 issue

Gertjan

Here :

Thats between :

https://github.com/acmesh-official/acme.sh/blob/1d59d43286103daf7a91e5c47f1be18eef707844/dnsapi/dns_nsupdate.sh#L35

and

https://github.com/acmesh-official/acme.sh/blob/1d59d43286103daf7a91e5c47f1be18eef707844/dnsapi/dns_nsupdate.sh#L53

where the nsupdate instruction file is created. The executed ... and fails to authenticate.
The parameters look fine.
So, as always, your secret key is wrong.
This one is mine :

key "update" {
    algorithm hmac-sha512;
    secret "eYQiVAutEEAF......./
    ....................DCaJwzkuZp0w==";
};

Make sure bind is using the key, mine is called 'update'. That encoding is correct both sides etc

And : look at your bind debug log. You will see the update (add) request - and why it fails.

VioletDragon

@Gertjan Yeah that is how i've configured it, HMAC has been removed from dnssec, the key i am specifying to Acme is the same key for certbot which works for Certbot but not Acme on pfSense.

Now the big question is, does the name server require DNSSec to be enabled for this to work?

This is the config I have on the master Name server the config that handles the HMAC key is as follows,

key "api." {
        algorithm hmac-sha512;
        secret "private key from the file Kcertbot.+165+?????.private";
};

zone "_acme-challenge.mydomain.com" {
        type master;
        file "/var/lib/bind/db._acme-challenge.mydomain.com";
        check-names warn;
        update-policy {
                grant certbot. name _acme-challenge.mydomain.com. txt;
        };
};

To me it feels like the Acme package isn't picking the key up although Certbot does. I tested with a wrong HMAC key on Acme and it fails to connect with the correct key the logs on the Name Server show's acme is communicating and it does create the TXT Record but I get the error with Acme on pfSense

Regards

Gertjan

@VioletDragon said in Acme DNS-NSupdate / RFC 2136 issue:

Now the big question is, does the name server require DNSSec to be enabled for this to work?

DNSSEC has nothing to do with "RFC 2136".

RFC 2136 or 'nsupdate' is an (my words) access method to the master domain name server so you can add or delete zones like

www.your-domaine.TLD A 1.2.3.4;

or

www.your-domaine.TLD TXT "a text here";

Btw : all my domains have DNNSEC - and all my domains uses acme.sh to get certificates from LE.

edit :

zone "bhf.tld" {
	type master;
	file "/etc/bind/zones/db.bhf.tld";
	allow-transfer { "ns-internal-net"; };
	masterfile-format text;
	notify-source 1.2.3.4;
	notify explicit; 
	allow-update { key "update";};
};

where bhf.tld is the domain name.
"ns-internal-net" is the list with my domain name slave servers, as these are allowed to sync with the master.
1.2.3.4 is the IP 'A' of my domain name.
I use the imho easier to use "allow-update" method. I've already shown the key called 'update' above.

I'm debug-logging the nsupdate methods anyway, and have a fail2ban looking at the log lines. If some attack (abuse) is detected, the attacking IP will get fire-walled for a while.

VioletDragon

@Gertjan I will give your config you attached ago and see what happens. I will post back in a few hours

Just out of interest. Have you tried this with certbot?

Regards

Gertjan

@VioletDragon said in Acme DNS-NSupdate / RFC 2136 issue:

Have you tried this with certbot?

Why would I ?
pfSense isn't a "install whatever app or package you want" device, it has a 'pfSense' package (that uses acme.sh) that makes it possible to obtain a cert.

Btw :

pfSense will score a 0 (wrong ! it has ssh if you activate it) out of 100 here.

edit : I'm not saying certbot is any good. I actually used it in the early years of 'LE' on my public servers.

VioletDragon

@Gertjan With the config you attached it is the same problem,

[Mon Sep  2 14:39:57 BST 2024] Adding txt value: OhjjaFGykQB6NOmc4aclaxSc3JrEKBTILGG9-DChOOA for domain:  _acme-challenge.domain.uk
[Mon Sep  2 14:39:57 BST 2024] adding _acme-challenge.domain.uk. 60 in txt "OhjjaFGykQB6NOmc4aclaxSc3JrEKBTILGG9-DChOOA"
dns_request_getresponse: expected a TSIG or SIG(0)
[Mon Sep  2 14:39:57 BST 2024] error updating domain
[Mon Sep  2 14:39:57 BST 2024] Error add txt for domain:_acme-challenge.domain.uk
[Mon Sep  2 14:39:57 BST 2024] Please check log file for more details: /tmp/acme/Route94/acme_issuecert.log

Log from BIND,

Sep 02 14:38:07 ns1.uk named[2868]: client @0x7f1bf0007cf8 172.70.84.154#26600 (_acme-challenge.domain.uk): query: _acme-challenge.domain.uk IN A -E(0)D (10.5)
Sep 02 14:38:19 ns1.domain.uk named[2868]: client @0x7f1be8002318 49.12#58200 (domain.uk): query: domain.uk IN SOA -E(0) (10.)
Sep 02 14:39:57 ns1.domain.uk named[2868]: client @0x7f1bf818bdb8 172.70.84.152#22383 (ns1.domain.uk): query: ns1.domain.uk IN A -E(0)D (10.5)
Sep 02 14:39:57 ns1.domain.uk named[2868]: client @0x7f1be8002318 172.70.84.152#35214 (ns1.domain.uk): query: ns1.domain.uk IN A -E(0)D (10.5)
Sep 02 14:39:57 ns1.domain.uk named[2868]: client @0x7f1bf0007cf8 172.69.43.40#10557 (ns1.domain): query: ns1 IN A -E(0)D (10.5)
Sep 02 14:39:57 ns1.domain.uk named[2868]: client @0x7f1be8002318 172.69.43.40#39038 (domain.uk): query: ns1.domain.uk IN AAAA -E(0)D (10.5)
Sep 02 14:39:57 ns1,domain.uk named[2868]: client @0x7f1bf4005058 172.69.43.40#41326 (domain.uk): query: domain.uk IN DNSKEY -E(0)D (10.5)
Sep 02 14:39:58 ns1.domain.uk named[2868]: client @0x7f1bf818bdb8 23.178.112.107#11581 (_aCMe-CHALlenGE.domain.UK): query: _aCMe-CHALlenGE.domin.UK IN TXT -E(0)DC (10.5)
Sep 02 14:39:58 ns1,domain.uk named[2868]: client @0x7f1bf4005058 23.178.112.107#36831 (ns1.domain.UK): query: ROSA.Ns1.domain.UK IN AAAA -E(0)DC (10.5)
Sep 02 14:39:58 ns1.domain.uk.uk named[2868]: client @0x7f1bf818e788 23.178.112.107#55833 (ns1.domain.UK): query: ns1.domain.UK IN AAAA -E(0)DC (10.5)

Screenshot from 2024-09-02 14-41-29.png

Gertjan

@VioletDragon

My logs are somewhat different :
First : as I ask for a wild card certificate, so two TXT records to add :

07-Aug-2024 07:53:10.411 update-security: client @0x7ff5325d5070 82.127.xx.108#55966/key update: signer "update" approved
07-Aug-2024 07:53:10.411 update: client @0x7ff5325d5070 82.127.xx.108#55966/key update: updating zone 'domain.tld/IN': adding an RR at '_acme-challenge.domain.tld' TXT "JLJQnIUFDoiQKHfN6iyFvHIuMMhF_-h7I5-mWcaZGX4"
07-Aug-2024 07:53:10.719 update-security: client @0x7ff5325d5070 82.127.xx.108#65112/key update: signer "update" approved
07-Aug-2024 07:53:10.719 update: client @0x7ff5325d5070 82.127.xx.108#65112/key update: updating zone 'domain.tld/IN': adding an RR at '_acme-challenge.domain.tld' TXT "Rmcf8iJ7-R7joIpa_hEMgfYBm9jpt_YuSP3eyBjSfq4"

Then, a dnssleep of 3 minutes.
During this time LE checks the "_acme-challenge.domain.tld' TXT" on the master, or one of my DNS slaves, or all of them ?

When done, it's clean up time:

07-Aug-2024 07:55:17.432 update-security: client @0x7ff5325d5070 82.127.xx.108#57576/key update: signer "update" approved
07-Aug-2024 07:55:17.432 update: client @0x7ff5325d5070 82.127.xx.108#57576/key update: updating zone 'domain.tld/IN': deleting rrset at '_acme-challenge.domain.tld' TXT
07-Aug-2024 07:55:17.596 update-security: client @0x7ff528513520 82.127.xx.108#55196/key update: signer "update" approved
07-Aug-2024 07:55:17.596 update: client @0x7ff528513520 82.127.xx.108#55196/key update: updating zone 'domain.tld/IN': deleting rrset at '_acme-challenge.domain.tld' TXT

where 82.127.xx.108 is my pfSense WAN IP, from where the acme.sh pfSEnse package runs.

Also : in "named.conf.options" I have this animal :

logging {
	 category "lame-servers" { lame; };
	
	 channel "lame" {
		file "/var/log/bind9/lame.log" versions 10 size 5m;
		print-time yes;
		print-category yes;
		severity dynamic;
	};

	category "default" { "debug"; };
	category "database" { "debug"; };
	category "security" { "debug"; };
	category "config" { "debug"; };
	category "resolver" { "debug"; };
	category "client" { "debug"; };
	category "unmatched" { "debug"; };
	category "network" { "debug"; };
	category "update" { "debug"; };
	category "dispatch" { "debug"; };

	channel "debug" {
		file "/var/log/bind9/debug.log" versions 10 size 5m;
		print-time yes;
		print-category yes;
		severity dynamic;
	};

	category "dnssec" { "dnssec"; };
	channel "dnssec" {
		file "/var/log/bind9/dnssec.log" versions 10 size 5m;
		print-time yes;
		print-category yes;
		severity dynamic;
	};

	channel "xfer" {
		file "/var/log/bind9/xfer.log" versions 10 size 5m;
		print-time yes;
		print-category yes;
		severity debug;
	};
	category "xfer-in" { "xfer"; };
	category "xfer-out" { "xfer"; };
	category "notify" { "xfer"; };

	channel "general" {
		file "/var/log/bind9/general.log" versions 10 size 5m;
		print-time yes;
		print-category yes;
		severity dynamic;
	};
	category "general" { "general"; };
		
	channel "b_query" {
		file "/var/log/bind9/query.log" versions 10 size 5m;
		print-time yes;
		print-category yes;
		severity dynamic;
	};
	category "queries" { "b_query"; };
};

which throws all the update (RFC1236 ?) stuff into the debug log

VioletDragon

@Gertjan Can you post the Zones you use ?

I don't believe the latest version of BIND i am running is using these Keys that is the issue here because Acme on pfSense keeps complaing about dns_request_getresponse: expected a TSIG or SIG(0), even though I have specified the key it doesn't seem to be in use.

Regards

Gertjan

@VioletDragon

root@ns311465:~# named -v
BIND 9.16.50-Debian (Extended Support Version) <id:acf2ba4>
root@ns311465:~# cat /etc/debian_version
11.11

Debian 11.11 isn't the latest, I have to jump to 12.x soon.

My zone info : see above.

@VioletDragon said in Acme DNS-NSupdate / RFC 2136 issue:

ven though I have specified the key it doesn't seem to be in use.

My zone mentions:

zone "bhf.tld" {
type master;
file "/etc/bind/zones/db.bhf.tld";
allow-transfer { "ns-internal-net"; };
masterfile-format text;
notify-source a.b.c.d;
notify explicit;
allow-update { key "update";};
};

and also, atbtyhe top of the file :

// For /root/.acme.sh/acme.sh - the "update" key
include "/etc/bind/le-acme-keys/le-acme.key";

and this file "le-acme.key" contains :

key "update" {
    algorithm hmac-sha512;
    secret "eYQiVAutExxxxxxxxxx/
    xxxxxxxxxxxxxxxxxxxCaJwzkuZp0w==";
};

VioletDragon

@Gertjan Yours is a older version, mines running BIND 9.18.28-0ubuntu0.22.04.1-Ubuntu (Extended Support Version)

Gertjan

@VioletDragon

Ubuntu ? What is that ?

But ok, I take note : when I upgrade to Debian 12, which contains bind 9.18.x, and I do work out the tedious "what will be better, and what will utterly break" list, I'll keep an eye on RFC 2136 support.

VioletDragon

@Gertjan everything i try and do doesn't work, its either a problem with Acme or BIND9 itself. Strange how Certbot works though.

VioletDragon

I generally think Acme Package on pfSense is broken.

Gertjan

@VioletDragon

I use the acme.sh nsupdate method to do some RFC2136 manually.

I've created a file called /root/server

server 1.2.3.4 53
update add blabla.bhf.tld. 60 in txt "yahoo"
send

Where 1.2.3.4 is your master name server.
Be careful of "blabla.bhf.tld." should be your domain name and has an ending dot .

Now, for some action :
Have a look at your /tmp/acme/ folder - it should contain a folder that represent your domain.
In that folder, you will find a file that ends with .net.key.
Look at what in it :
Surprise :

key "update." {
	algorithm HMAC-SHA512;
	secret "eYQiVAutEExxxxxxxxx/
        xxxxxxxxxxxxxxxxxxxxhO9zDCaJwzkuZp0w==";
};

( you wonder where did came from ^^)

Show time :

Type

nsupdate -d -k / /tmp/acme/DOMAIN/DOMAINnsupdate_acme-challenge.DOMAIN.net.key server

I saw :

Creating key...
Creating key...
namefromtext
keycreate
Reply from SOA query:
;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id:  22473
;; flags: qr aa; QUESTION: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 1
;; QUESTION SECTION:
;blabla.bhf.tld.   IN      SOA

;; AUTHORITY SECTION:
bhf.tld.   0       IN      SOA     ns1.bhf.tld. postmaster.bhf.tld. 2023020845 14400 3600 1209600 10800

;; TSIG PSEUDOSECTION:
update.                 0       ANY     TSIG    hmac-sha512. 1725292457 300 64 WcOM9s/w29Hken6Bmzg3exxxxxxxxxeaz3+1SheVSw46NJ7E1isSEg== 22473 NOERROR 0

Found zone name: bhf.tld
The primary is: ns1.bhf.tld
Sending update to 5.196.xx.182#53
Outgoing update query:
;; ->>HEADER<<- opcode: UPDATE, status: NOERROR, id:  54168
;; flags:; ZONE: 1, PREREQ: 0, UPDATE: 1, ADDITIONAL: 1
;; UPDATE SECTION:
blabla.bhf.tld. 60 IN      TXT     "yahoo"

;; TSIG PSEUDOSECTION:
update.                 0       ANY     TSIG    hmac-sha512. 1725292457 300 64 tHWwUToJ6uM4S4OrbNxxxxxx72YPC54EKG0UKSYFwuIg== 54168 NOERROR 0


Reply from update query:
;; ->>HEADER<<- opcode: UPDATE, status: NOERROR, id:  54168
;; flags: qr; ZONE: 1, PREREQ: 0, UPDATE: 0, ADDITIONAL: 1
;; ZONE SECTION:
;bhf.tld.          IN      SOA

;; TSIG PSEUDOSECTION:
update.                 0       ANY     TSIG    hmac-sha512. 1725292457 300 64 XAyLf3RacccccccccccccccccccccccccccceCunW95a2Dl1oQD+jql0g== 54168 NOERROR 0

So, you also, should be able to do RFC 2136 'by hand'.
As RFC 2136 can't be broken of course.

VioletDragon

@Gertjan The file you mention with .net.key doesn't exist.

VioletDragon

@Gertjan nsupdate -d -k works on my workstation to the Name Server but Acme doesn't work, certbot work.

I think this package is broken personally.

VioletDragon

@Gertjan Just an update, the config I have the HMAC key isn't work at all, running nsupdate -k allows me to send the change but HMAC key isn't even working not sure what is wrong though

VioletDragon

@Gertjan Give up with this, It's either ACME that has the issue or it's just BIND that's the issue,

All I get now is

TSIG error with server: tsig verify failure
update failed: NOTIMP

Did a fresh install with Debian, when running nsupdate -k on the physical name server I get the same error,

dns_request_getresponse: expected a TSIG or SIG(0)

Gertjan

@VioletDragon said in Acme DNS-NSupdate / RFC 2136 issue:

HMAC key

HMAC**-SHA512**, right ?

The nsupdate tool that acme.sh uses isn't from acme.sh, but from the OS ( ? ).

The acme.sh update method called "DNS-NSupdate" uses the nsupdate binary, that should be able to talk to bind, on the other side.

@VioletDragon said in Acme DNS-NSupdate / RFC 2136 issue:

Did a fresh install with Debian, when running nsupdate -k on the physical name server I get the same error,

You mean you couldn't even run nsupdate on the debian server itself ?
The nsupdate tools that comes with the bind package can't 'talk' to bind ?

VioletDragon

@Gertjan update. The configuration for Acme and Certbot is different. Will report back when I’ve done the configuration.