Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    25.03.b.20250306.0140 - if_pppoe kernel module chap failure

    Scheduled Pinned Locked Moved Plus 25.03 Develoment Snapshots
    13 Posts 4 Posters 529 Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • K
      kprovost @femtosize
      last edited by

      @femtosize There's nothing obvious in the code. I'd expect long challenges to just work.

      Can you share this capture to https://nc.netgate.com/nextcloud/s/Am58nWPJSZyf9JJ? Perhaps there's still something else to see in it.

      F 1 Reply Last reply Reply Quote 1
      • F
        femtosize @kprovost
        last edited by

        @kprovost OK. I've uploaded the capture.

        K 1 Reply Last reply Reply Quote 1
        • stephenw10S
          stephenw10 Netgate Administrator
          last edited by

          Thanks, we are checking...

          1 Reply Last reply Reply Quote 0
          • K
            kprovost @femtosize
            last edited by

            @femtosize I've tried to reproduce this locally, and found that this challenge length just works.
            I've also tweaked the test setup to resemble yours a bit more by using the same username.

            Here's the capture for that: https://www.codepro.be/files/197026.pcap
            That just worked.

            Just about the only thing I can think right now is that the password is actually wrong. It may be worth trying with this pppoe package: https://www.codepro.be/files/if_pppoe-kmod-2.8.0.b.20250404.1200.1500029.pkg . This one will copy the password back to userspace so pppcfg pppoe0 will show the password, allowing you to check if it actually has the correct password.

            F 1 Reply Last reply Reply Quote 1
            • F
              femtosize @kprovost
              last edited by

              @kprovost Sorry, I can't try that pkg as I'm on arm64. Could that be the problem? Different alignment requirements?
              The password should be correct as I'm not changing any config when flipping between mpd5 and if_pppoe and back again. Always works with mpd5, always fails with if_pppoe.

              K 1 Reply Last reply Reply Quote 1
              • K
                kprovost @femtosize
                last edited by

                @femtosize Ah, yeah, an amd64 (and CE) kernel module won't work on arm64, of course.

                I don't expect there to be alignment issues in this particular code. That's one thing that might be going wrong, but it's also possible there are issues in how the PHP passes the password via pppcfg, so it's worth checking this anyway.

                I'll make an arm64 build, but that might not happen until Monday.

                F 1 Reply Last reply Reply Quote 1
                • F
                  femtosize @kprovost
                  last edited by femtosize

                  @kprovost I've figured it out. There's been a space at the start of the password since I entered it years ago. The mdp5 code path writes it to a config file with no quotes around it so it just worked.
                  The if_pppoe path uses it on a command line surrounded by quotes and so it fails until I remove the space.

                  This does make me think it might be interesting if my username or password had / " or ; in it.

                  M K 2 Replies Last reply Reply Quote 2
                  • M
                    Mission-Ghost @femtosize
                    last edited by

                    @femtosize said in 25.03.b.20250306.0140 - if_pppoe kernel module chap failure:

                    @kprovost I've figured it out. There's been a space at the start of the password since I entered it years ago. The mdp5 code path writes it to a config file with no quotes around it so it just worked.
                    The if_pppoe path uses it on a command line surrounded by quotes and so it fails until I remove the space.

                    This does make me think it might be interesting if my username or password had / " or ; in it.

                    Seems like a bug to me for pfSense to inconsistently handle non-printing characters at the beginning or end of any string.

                    1 Reply Last reply Reply Quote 2
                    • K
                      kprovost @femtosize
                      last edited by

                      @femtosize Ah, thanks for figuring that out.

                      I'll add a Redmine for this, and a reminder to check for escaping things like " and ' and .

                      1 Reply Last reply Reply Quote 1
                      • stephenw10S
                        stephenw10 Netgate Administrator
                        last edited by

                        For reference: https://redmine.pfsense.org/issues/16128

                        1 Reply Last reply Reply Quote 0
                        • First post
                          Last post
                        Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.