Traffic Shaper (limiters) fixed

shinzo

2.4.4-DEVELOPMENT (amd64) built on Wed Apr 25 09:14:05 CDT 2018

Looks like Limiters took a hit. Tried rebuilding the limiters but as soon as i would set the 2nd Limiter was saved, it would just overwrite the previous one.

intrusdave

I can confirm - shaper is broken in most recent snapshot.

GentleJoe

Confirmed.
2.4.4-DEVELOPMENT (amd64)
built on Thu Apr 26 14:32:50 CDT 2018

Tons of errors, like this one.
/rc.filter_configure_sync: New alert found: There were error(s) loading the rules: /tmp/rules.debug:56: errors in queue definition - The line in question reads [56]: queue qLink on re1 bandwidth 20% qlimit 500 hfsc ( ecn , default )

jake

Same here. It really messed up my shapers. After the update I could not route out to the internet from my LAN. I had to remove all the shaper info to do so. When I ran the shaper wizard again I ended up with the same result.

GentleJoe

@jake:

Same here. It really messed up my shapers. After the update I could not route out to the internet from my LAN. I had to remove all the shaper info to do so. When I ran the shaper wizard again I ended up with the same result.

Same exact issue.

w0w

I think it's the result of those changes related to preparation for transition to PHP7.
https://github.com/pfsense/pfsense/commit/e33c96162a33b52a9152ce0b05dba8b25f1dc2b4#diff-c215f6ed59dffd959b2b800fe86181d2

GentleJoe

Still no good on:

2.4.4-DEVELOPMENT (amd64)
built on Mon Apr 30 09:16:01 CDT 2018
FreeBSD 11.1-STABLE

w0w

It would not be good, until somebody reports it on redmine and someone else will fix it.
https://redmine.pfsense.org/projects/pfsense/issues?query_id=104

jwt

We're working on it.

GentleJoe

Thnks jwt

matt_

I noticed the same behavior when I was working on a PR for limiters to add FQ_CODEL/FQ_PIE support. Array references are all weird because now there's a little too much referencing. I thought it was my fault ;D

shinzo

Limiters seem to be fixed in the latest version, thank you.