Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Traffic shaper changes [90% completed, please send money to complete bounty]

    Scheduled Pinned Locked Moved Completed Bounties
    375 Posts 72 Posters 468.7k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S
      sai
      last edited by

      $100.

      Multi-wan is interesting, but what do you mean by that? If you mean 1 shaper with multiple WANs then I dont remember seeing it in any of the HFSC docs (not that I studied too hard). It would probably be very difficult to visualise and use  - most unlikely anyone would want it.
      If you mean a separate shaper for each WAN then that makes more sense. Should be possible to fit it into the gui without complications.

      Time line: are we talking 6 months, 1 year (+/- x months)?  I know that this is open source so no release dates set in advance, but some sort of ETA ?

      1 Reply Last reply Reply Quote 0
      • B
        billm
        last edited by

        @sai:

        $100.

        Multi-wan is interesting, but what do you mean by that? If you mean 1 shaper with multiple WANs then I dont remember seeing it in any of the HFSC docs (not that I studied too hard). It would probably be very difficult to visualise and use  - most unlikely anyone would want it.
        If you mean a separate shaper for each WAN then that makes more sense. Should be possible to fit it into the gui without complications.

        Yep, multiple WANs.  It's all about queue definition and how traffic get's assigned to the queue.  I'm not 100% sure I can make it work in our case.  Policy based multi-wan routing would likely be possible, but based on how we assign traffic to queues (which won't be changing…it's the only way we can do it without major pf hacks) it's likely that load balanced WANs won't be able to shape.  There are some other items I have in the works as I get to them (kernel side is done...I think) that will allow for layer7 requeueing of traffic (ie. traffic starts off in the default queue or something and get's moved to HTTP once it recognizes HTTP in the packet payload).  I'm not including that as part of this bounty/feature enhancement.

        @sai:

        Time line: are we talking 6 months, 1 year (+/- x months)?  I know that this is open source so no release dates set in advance, but some sort of ETA ?

        We're planning on starting work on RELENG_2 shortly and I'm (personally) hopeful that we'll be able to push a 6 month release cycle out (but depending on bugs in new features, that might stretch).  With that said, you'll be able to see the new code in the alpha releases as soon as it's commited.  I don't expect that it'll take me more than a week or two to get the new shaper code to a point where I can commit it and get people pounding on it.

        –Bill

        pfSense core developer
        blog - http://www.ucsecurity.com/
        twitter - billmarquette

        1 Reply Last reply Reply Quote 0
        • W
          wcoolnet
          last edited by

          $200

          1 Reply Last reply Reply Quote 0
          • M
            mrt_ok
            last edited by

            $500

            1 Reply Last reply Reply Quote 0
            • A
              aldo
              last edited by

              bill the changes you are proposing sound very interesting. if interfaces could be extended to support all the ng interfaces loaded on the pppoe server we have another 200 for your bounty.

              it can nearly do it now. with a bit of a hack to it but gets it's white spacings wrong.

              would you think this is supportable in the multiple interfaces area of your plan

              1 Reply Last reply Reply Quote 0
              • B
                billm
                last edited by

                @aldo:

                bill the changes you are proposing sound very interesting. if interfaces could be extended to support all the ng interfaces loaded on the pppoe server we have another 200 for your bounty.

                it can nearly do it now. with a bit of a hack to it but gets it's white spacings wrong.

                would you think this is supportable in the multiple interfaces area of your plan

                I think so - do PPPOE server interfaces show up as individual interfaces in the Rules (or even interfaces) screen?  I'm thinking it doesn't, but I haven't really seen how the PPPoE server works either.  I'll try and spend some time tonight, I agree, it's likely possible, but I don't know enough about how that section of code works to be able to say for sure.  If it comes up as individual interfaces that rules can be created on, then I'm reasonably confident that it'll "just work".

                –Bill

                pfSense core developer
                blog - http://www.ucsecurity.com/
                twitter - billmarquette

                1 Reply Last reply Reply Quote 0
                • S
                  sullrich
                  last edited by

                  Only major problem is ngX is dynamic.  The ordering may shift.

                  1 Reply Last reply Reply Quote 0
                  • B
                    billm
                    last edited by

                    @sullrich:

                    Only major problem is ngX is dynamic.  The ordering may shift.

                    Good point.  Although I don't think ngX necessarily has to be dynamic.  But making major interface changes, while on my own personal list of things to do, aren't necessarily compatible within the scope of this change.  If these are truly dynamic and not tied to the standard rules editor, then I don't think we'll be able to make it part of this change.  Although this change should set the stage for this feature in the future.

                    –Bill

                    pfSense core developer
                    blog - http://www.ucsecurity.com/
                    twitter - billmarquette

                    1 Reply Last reply Reply Quote 0
                    • S
                      sullrich
                      last edited by

                      Nope, its not associated unfortunately.

                      1 Reply Last reply Reply Quote 0
                      • A
                        aldo
                        last edited by

                        ok that was confusing could you clarify these points.
                        is it possible?
                        would you include it?
                        all i am trying to do is hfsc with them no other gaurentees all have equal preferance.

                        well look forward to the clarification

                        1 Reply Last reply Reply Quote 0
                        • B
                          billm
                          last edited by

                          @aldo:

                          ok that was confusing could you clarify these points.
                          is it possible?

                          Possible, yes.  With the current way interfaces are configured, no.  The shaper changes I'm working on won't directly help here, but would be considered a prereq to being able to do this.

                          @aldo:

                          would you include it?

                          One thing at a time :)  If PPPoE server 'nics' (all the ng interfaces) were already individually assignable for rule management in pfSense, you'd get the shaper changes "for free" so to speak.  The changes I'm looking at would just come along for the ride.  As it sits, I'd consider this a different project, but one that relies on this change before it can be seriously thought of.  Depending on how the code ends up getting written, it may be possible to hack up a config.xml that'll create the correct rules - not sure, I'm still researching the proper way to do the queues as it is (it's looking like we'll have a number of nasty recursive loops).

                          @aldo:

                          all i am trying to do is hfsc with them no other gaurentees all have equal preferance.

                          well look forward to the clarification

                          Hope that helps.

                          –Bill

                          pfSense core developer
                          blog - http://www.ucsecurity.com/
                          twitter - billmarquette

                          1 Reply Last reply Reply Quote 0
                          • S
                            sullrich
                            last edited by

                            Not sure that we can accept Pakistan funds without Big Bubba getting down and angry with us.

                            1 Reply Last reply Reply Quote 0
                            • E
                              eric
                              last edited by

                              i too would be willing to throw some money your way for this, however seeing as I'm pretty close to broke it wouldn't be much.

                              1 Reply Last reply Reply Quote 0
                              • D
                                Delphinus
                                last edited by

                                I'll donate $100. Let me know when you need it.

                                1 Reply Last reply Reply Quote 0
                                • M
                                  msamblanet
                                  last edited by

                                  Just sent in $100 to Paypal…while I would like you to consider it part of this bounty, please use it as/when the project needs...you've earned it with or without a multi-interface traffic shaper!

                                  1 Reply Last reply Reply Quote 0
                                  • P
                                    Perry
                                    last edited by

                                    Bill what paypal account do i send my donation to?

                                    /Perry
                                    doc.pfsense.org

                                    1 Reply Last reply Reply Quote 0
                                    • A
                                      aldo
                                      last edited by

                                      @billm:

                                      @aldo:

                                      ok that was confusing could you clarify these points.
                                      is it possible?

                                      Possible, yes.  With the current way interfaces are configured, no.  The shaper changes I'm working on won't directly help here, but would be considered a prereq to being able to do this.

                                      @aldo:

                                      would you include it?

                                      OK i think i understand what are the overall thoughts on this. should i start up a bounty on it.
                                      we use pppoe server for all our wireless concentration. if this change looks achievable outside of the shaper scope i will make a bounty for it.

                                      maybe you or scott can clarify the scope of the change a little more clearly and i can brief it

                                      One thing at a time :)  If PPPoE server 'nics' (all the ng interfaces) were already individually assignable for rule management in pfSense, you'd get the shaper changes "for free" so to speak.  The changes I'm looking at would just come along for the ride.  As it sits, I'd consider this a different project, but one that relies on this change before it can be seriously thought of.  Depending on how the code ends up getting written, it may be possible to hack up a config.xml that'll create the correct rules - not sure, I'm still researching the proper way to do the queues as it is (it's looking like we'll have a number of nasty recursive loops).

                                      @aldo:

                                      all i am trying to do is hfsc with them no other gaurentees all have equal preferance.

                                      well look forward to the clarification

                                      Hope that helps.

                                      –Bill

                                      1 Reply Last reply Reply Quote 0
                                      • B
                                        billm
                                        last edited by

                                        @Perry:

                                        Bill what paypal account do i send my donation to?

                                        paypal at chrisbuechler.com if you want pfSense to hold onto it until I'm done, or billm at pfsense.org if you wish to send it direct to me sooner.

                                        –Bill

                                        pfSense core developer
                                        blog - http://www.ucsecurity.com/
                                        twitter - billmarquette

                                        1 Reply Last reply Reply Quote 0
                                        • B
                                          billm
                                          last edited by

                                          Aldo, didn't see any content in that post…did I miss something?

                                          --Bill

                                          @aldo:

                                          @billm:

                                          @aldo:

                                          ok that was confusing could you clarify these points.
                                          is it possible?

                                          Possible, yes.  With the current way interfaces are configured, no.  The shaper changes I'm working on won't directly help here, but would be considered a prereq to being able to do this.

                                          @aldo:

                                          would you include it?

                                          OK i think i understand what are the overall thoughts on this. should i start up a bounty on it.
                                          we use pppoe server for all our wireless concentration. if this change looks achievable outside of the shaper scope i will make a bounty for it.

                                          maybe you or scott can clarify the scope of the change a little more clearly and i can brief it

                                          One thing at a time :)  If PPPoE server 'nics' (all the ng interfaces) were already individually assignable for rule management in pfSense, you'd get the shaper changes "for free" so to speak.  The changes I'm looking at would just come along for the ride.  As it sits, I'd consider this a different project, but one that relies on this change before it can be seriously thought of.  Depending on how the code ends up getting written, it may be possible to hack up a config.xml that'll create the correct rules - not sure, I'm still researching the proper way to do the queues as it is (it's looking like we'll have a number of nasty recursive loops).

                                          @aldo:

                                          all i am trying to do is hfsc with them no other gaurentees all have equal preferance.

                                          well look forward to the clarification

                                          Hope that helps.

                                          –Bill

                                          pfSense core developer
                                          blog - http://www.ucsecurity.com/
                                          twitter - billmarquette

                                          1 Reply Last reply Reply Quote 0
                                          • B
                                            billm
                                            last edited by

                                            Just wanted to update the thread.  I'm still working on this, had some issues with some of the new gui libraries that we needed to get fixed as well as some VM issues that are now resolved.  I'm hoping to spend some time during my vacation to get a new wizard completed which should allow me to generate configs that I can use to create the backend :)  Due to the use of the new gui library, I can pretty easily say that this won't appear in the RELENG_1 branch at all, but I'll attempt to backport it for those that have pledged and donated for this so it can get tested and have some eyes on it earlier (and of course so you can have a new toy :)).

                                            –Bill

                                            pfSense core developer
                                            blog - http://www.ucsecurity.com/
                                            twitter - billmarquette

                                            1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post
                                            Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.