Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    CP Status does not show usernames

    Captive Portal
    4
    36
    16.2k
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • A
      alexus
      last edited by

      ok thanks for the file link ;-)

      spell cheker slows me down yes, but i dont like it

      1 Reply Last reply Reply Quote 0
      • S
        sullrich
        last edited by

        @alexus:

        ok thanks for the file link ;-)

        spell cheker slows me down yes, but i dont like it

        Half the time your unintelligible due to the amount of spelling typos.

        One minute more of your time will save a minute off everyone that reads this thread!

        1 Reply Last reply Reply Quote 0
        • A
          alexus
          last edited by

          ok i will write in Russian :-P
          Now I’m having trouble with the drain in my house so have to stop at this point,
          but so far i found that CP is not debugable :-( so maybe some one has any ideas how to debug it?

          and also while reviewing the CP files i found tha accounting itself could be more specific.

          Anyway as of now the only thing i know is that accounting script  is called twice, this could be doe either by direct call (highly unlikely) or via user access authorization function that brings up the accounting. The user access authorization function is called 3 times 1) for MAC pass through and 2 other times a would assume a) for new access b) returning user

          That’s it,,,, i dono what to do next

          1 Reply Last reply Reply Quote 0
          • A
            alexus
            last edited by

            Ok, i got bored not knowing what users are loged in on CP (Not talking about Radius Acc)
            So I did the fix so that we still can  see the loged in username!!!

            See code below.

            Also there is a probem with not writing traffic usege by users to the db file. That should be fixed somewhere but I dono where yet, and there is another problem with redundant radius accounting packets.

            
            /* $Id: status_captiveportal.php,v 1.7.2.4 2006/04/03 21:05:12 sullrich Exp $ */
            /*
            	status_captiveportal.php
            	part of m0n0wall (http://m0n0.ch/wall)
            
            	Copyright (C) 2003-2004 Manuel Kasper <mk@neon1.net>.
            	All rights reserved.
            
            	Redistribution and use in source and binary forms, with or without
            	modification, are permitted provided that the following conditions are met:
            
            	1\. Redistributions of source code must retain the above copyright notice,
            	   this list of conditions and the following disclaimer.
            
            	2\. Redistributions in binary form must reproduce the above copyright
            	   notice, this list of conditions and the following disclaimer in the
            	   documentation and/or other materials provided with the distribution.
            
            	THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
            	INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
            	AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
            	AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
            	OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
            	SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
            	INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
            	CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
            	ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
            	POSSIBILITY OF SUCH DAMAGE.
            */
            
            require("guiconfig.inc");
            
            $concurrent = `cat /var/db/captiveportal.db | wc -l`;
            
            $pgtitle = "Status: Captive portal ({$concurrent})";
            
            include("head.inc");
            
            ?>
            
            if ($_GET['act'] == "del") {
            	captiveportal_disconnect_client($_GET['id']);
            }
            
            flush();
            
            function clientcmp($a, $b) {
            	global $order;
            	return strcmp($a[$order], $b[$order]);
            }
            
            $cpdb = array();
            captiveportal_lock();
            $fp = @fopen("{$g['vardb_path']}/captiveportal.db","r");
            
            if ($fp) {
            	while (!feof($fp)) {
            		$line = trim(fgets($fp));
            		if ($line) {
            			$cpent = explode(",", $line);
            			//Alexus: lets cout last element of new array cpnetp[] and use it for last activity
            			if ($_GET['showact'])
                                                  //Alexus: Created additional array entry as a buffer to free 4
            			$cpent[11]=captiveportal_get_last_activity($cpent[1]);
            			$cpdb[] = $cpent;
                                                  }
            		}
            	}
            
            	fclose($fp);
            
            	if ($_GET['order']) {
            		if ($_GET['order'] == "ip")
            			$order = 2;
            		else if ($_GET['order'] == "mac")
            			$order = 3;
            		else if ($_GET['order'] == "lastact")
            			$order = 4;
            		else
            			$order = 0;
            		usort($cpdb, "clientcmp");
            	}
            }
            captiveportal_unlock();
            ?>
            
            | Username | [IP address](?order=ip&showact=<?=$_GET['showact'];?>) | [MAC address](?order=mac&showact=<?=$_GET['showact'];?>) |	 [Session start](?order=start&showact=<?=$_GET['showact'];?>) | [Last activity](?order=lastact&showact=<?=$_GET['showact'];?>) |	 [Session start](?order=start&showact=<?=$_GET['showact'];?>) |	  |
            |  |  |   |  |	  |		 
            	[![](./themes/<?= $g['theme']; ?>/images/icons/icon_x.gif)](?order=<?=$_GET['order'];?>&showact=<?=$_GET['showact'];?>&act=del&id=<?=$cpent[1];?>) |</mk@neon1.net> 
            

            PS: I think something wrong w/ closing if (copy and paste error) … the forum not allowing me to attach php file

            1 Reply Last reply Reply Quote 0
            • S
              sullrich
              last edited by

              Please provide a unified diff.

              http://wiki.pfsense.com/wikka.php?wakka=SubmittingPatches

              1 Reply Last reply Reply Quote 0
              • A
                alexus
                last edited by

                did I eve say I'm lazy?

                1 Reply Last reply Reply Quote 0
                • S
                  sullrich
                  last edited by

                  Fine, then your code will sit in this forum to no attention.

                  Seriously, if you are this lazy please dont bother submitting anything in the future.

                  Thanks.

                  1 Reply Last reply Reply Quote 0
                  • A
                    alexus
                    last edited by

                    ok
                    if u wanna me to do that thing I wanna know what exactly going to happen?

                    fetch -o /usr/bin/diff http://www.pfsense.com/~sullrich/extra/diff∞                  <<what this="" line="" does?<br="">fetch -o /usr/bin/patch http://www.pfsense.com/~sullrich/extra/patch∞          << what this line does?
                    chmod a+rx /usr/bin/*                                                                          < <what this="" line="" does?<br="">Are there any files wtiten to the system?
                    Does this thing sends the diference of all modifications on the system or just specific file? How do I specify the file?</what></what>

                    1 Reply Last reply Reply Quote 0
                    • S
                      sullrich
                      last edited by

                      No offense, but I am growing tired of all your questions to only hear how lazy you are.  If you are serious about helping us then figure it out.

                      1 Reply Last reply Reply Quote 0
                      • A
                        alexus
                        last edited by

                        grrr

                        1 Reply Last reply Reply Quote 0
                        • D
                          DanielSHaischt
                          last edited by

                          RTFM  ;D

                          http://www.freebsd.org/cgi/man.cgi?query=fetch&apropos=0&sektion=0&manpath=FreeBSD+6.2-RELEASE&format=html

                          Mit freundlichen Gruessen / With kind regards
                          DAn.I.El S. Haischt

                          1 Reply Last reply Reply Quote 0
                          • S
                            sullrich
                            last edited by

                            @DanielSHaischt:

                            RTFM  ;D

                            http://www.freebsd.org/cgi/man.cgi?query=fetch&apropos=0&sektion=0&manpath=FreeBSD+6.2-RELEASE&format=html

                            He is "too lazy" to read a manual.  He wants everyone to spoon feed him so he doesn't have to "lift a finger"

                            :rolls eyes:

                            1 Reply Last reply Reply Quote 0
                            • First post
                              Last post
                            Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.