Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    {Complete} Timebased Rules

    Scheduled Pinned Locked Moved Completed Bounties
    187 Posts 10 Posters 144.0k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • B
      BuddhaChu
      last edited by

      Since I can't get the rules to load with a schedule associated with it, I can't test this so I'll ask it here…

      If a client on the LAN is using Squid in either normal or transparent mode, will they be able to surf the internet even if I have a rule in place to block them?  (This was an issue in ClarkConnect at one time when using the Squid proxy bypassed firewall block rules)

      Now that I re-read this, it isn't really a time-based rule question.  But, I'll leave it anyways and you can call me "stupid".  :\

      1 Reply Last reply Reply Quote 0
      • S
        sullrich
        last edited by

        #3 fixed now.  Thanks!

        #1 and #2 are being fixed as I type this.

        1 Reply Last reply Reply Quote 0
        • S
          sullrich
          last edited by

          @BuddhaChu:

          Since I can't get the rules to load with a schedule associated with it, I can't test this so I'll ask it here…

          If a client on the LAN is using Squid in either normal or transparent mode, will they be able to surf the internet even if I have a rule in place to block them?  (This was an issue in ClarkConnect at one time when using the Squid proxy bypassed firewall block rules)

          Good question.  You'll have to test and let us know :)

          1 Reply Last reply Reply Quote 0
          • B
            BuddhaChu
            last edited by

            Suggestion: If the rules are limited to only 5 minute ranges allowed (00, 15, 30, 45, & 59), wouldn't a drop box be better then a text input box?  This would eliminate input errors.  Same for the hour section.

            I don't know if that fits into the pfSense "style" or not.

            1 Reply Last reply Reply Quote 0
            • S
              sullrich
              last edited by

              @BuddhaChu:

              Suggestion: If the rules are limited to only 5 minute ranges allowed (00, 15, 30, 45, & 59), wouldn't a drop box be better then a text input box?  This would eliminate input errors.  Same for the hour section.

              I don't know if that fits into the pfSense "style" or not.

              Yes, very good idea.  We'll look into it.

              1 Reply Last reply Reply Quote 0
              • B
                BuddhaChu
                last edited by

                After looking at the code in firewall_schedule_edit.php there looks to be a typo on line 581 ("td.innerHTML=" twice @ beginning of the line)

                td.innerHTML=td.innerHTML="

                1 Reply Last reply Reply Quote 0
                • B
                  BuddhaChu
                  last edited by

                  I'm full of suggestions tonight…

                  If you get rid of both the hour and minute text boxes and replaced them with one drop down box you could eliminate both the checkKeyEntry() and checkTimeLimits() Javascript functions.  Yes, the drop box would have 97 entries, but I think it would be worth it.

                  The way that's done in ClarkConnect is to build the < option value ="00:15" >00:15< /option > entries with two loops.

                  Pseudo code (I haven't coded in PHP since early 2003)

                  Hour loop - loop from 0 to 23
                    Minute loop - loop from 0 to 45
                        If hour= 0 then
                            Add a zero to the hour in the < option > entry (i.e. "00") $hour . "0:" . $minute
                        Elseif minute = 0
                            Add a zero to the minute in the < option > entry (i.e. "00") $hour . ":0" . $minute
                          Else
                            Output hour:minute to < option > entry
                        End if
                    Return minute loop
                  Return hour loop
                  Add < option > for 23:59

                  I hope I'm helping, not hindering when making these suggestions.

                  1 Reply Last reply Reply Quote 0
                  • B
                    BuddhaChu
                    last edited by

                    Reloaded with the 3-27 snapshot (built after issue #3 above was fixed). Something happened and now the Schedule column is missing for the two rules that are added with a checkbox (Block private & bogon networks).

                    pfsense.png
                    pfsense.png_thumb

                    1 Reply Last reply Reply Quote 0
                    • S
                      sullrich
                      last edited by

                      @BuddhaChu:

                      Reloaded with the 3-27 snapshot (built after issue #3 above was fixed). Something happened and now the Schedule column is missing for the two rules that are added with a checkbox (Block private & bogon networks).

                      That should be fixed.  Please try most recent snapshot.

                      1 Reply Last reply Reply Quote 0
                      • B
                        BuddhaChu
                        last edited by

                        Reloaded with the 3-27 snap with a timestamp of 2007-Mar-27 23:23:10 and the issue is still there.

                        The whole < td >< /td > section is missing for the Schedule column.  See attached pic for the HTML code relating to that page.

                        pfsense2.png_thumb
                        pfsense2.png

                        1 Reply Last reply Reply Quote 0
                        • S
                          sullrich
                          last edited by

                          Not sure if the snapshot server is broken, but the latest sources show me:

                          schedule.png_thumb
                          schedule.png

                          1 Reply Last reply Reply Quote 0
                          • Y
                            yoda715
                            last edited by

                            @BuddhaChu:

                            Reloaded with the 3-27 snapshot (built after issue #3 above was fixed). Something happened and now the Schedule column is missing for the two rules that are added with a checkbox (Block private & bogon networks).

                            I've duplicated this. Will fix shortly.

                            1 Reply Last reply Reply Quote 0
                            • H
                              heiko
                              last edited by

                              Good Morning,
                              i will test it in a few hours. Thanks
                              Greetings from Germany
                              heiko

                              1 Reply Last reply Reply Quote 0
                              • Y
                                yoda715
                                last edited by

                                @BuddhaChu:

                                Reloaded with the 3-27 snap with a timestamp of 2007-Mar-27 23:23:10 and the issue is still there.

                                The whole < td >< /td > section is missing for the Schedule column.  See attached pic for the HTML code relating to that page.

                                Fixed now.

                                1 Reply Last reply Reply Quote 0
                                • C
                                  Christian
                                  last edited by

                                  Hi,

                                  this looks like a really niceaddition, thanks to all involved (the programmers as well as the person paying the bill).

                                  I'm not sure how to test this, but do you have any ideas what will happen if a rule is scheduled for a time that doesn't exist?
                                  I'm refering to daylight saving time.
                                  What happens if something should be disabled at 2:30am every Sunday night, but there is no 2:30 on one Sunday a year?
                                  Also the other way, if a rule is only active between 2am and 2:30am on Sundays, will it be active twice when the extra hour is added?

                                  As I'm not paying for it, so I'm not asking for a special way to handle this, all I would like to know is what is the intendet way  daylight saving will be handled?

                                  Thanks for a cool addition to a cool firewall product,

                                  Christian

                                  1 Reply Last reply Reply Quote 0
                                  • B
                                    BuddhaChu
                                    last edited by

                                    Confirmed the missing schedule column is fixed.

                                    sdale: Nice fix for not hitting the "Add Time" button on the schedule page.  Even though I'm familiar with the interface now, I forgot to hit the Add Time button and the msgbox dialog helped me out.

                                    1 Reply Last reply Reply Quote 0
                                    • H
                                      heiko
                                      last edited by

                                      Hello,
                                      very special thanks BuddhaChu for testing it and very very special thanks to "Scott´s" for coding…great

                                      • Issue #1 #2 from BuddhaChu is open

                                      • when i choose multiple days, for example 10 days of month, i think, a line break is missing (Screenshot)

                                      • for me it would be nice, when the date/time picker starts with Monday at the left.... :)

                                      • Problem: a couple days brings "grimbelfixe" to the description, when you edit and save a second time

                                      • Problem: when you stay in the schedule maks and have more than one configured range, and you want to edit one, click this and click a second also without saving the first one, uups, then the logic is a little bit confused the a first range disappeared.

                                      I think, you should only one range to edit at the same time. A second edit is not allowed, before the first one are not saved.

                                      A litte bit more in a 1 or 2 hours, also a posting to the rule features.
                                      Greetings
                                      heiko

                                      line-break.jpg
                                      line-break.jpg_thumb
                                      schedule_multiple_days.jpg
                                      schedule_multiple_days.jpg_thumb
                                      schedule_grimbelfix_edit_second.jpg
                                      schedule_grimbelfix_edit_second.jpg_thumb
                                      ![multiple_configured _ranges.jpg](/public/imported_attachments/1/multiple_configured _ranges.jpg)
                                      ![multiple_configured _ranges.jpg_thumb](/public/imported_attachments/1/multiple_configured _ranges.jpg_thumb)

                                      1 Reply Last reply Reply Quote 0
                                      • P
                                        Perry
                                        last edited by

                                        In April and July i can't select the dates 1-7, bug?

                                        ![can't select.gif](/public/imported_attachments/1/can't select.gif)
                                        ![can't select.gif_thumb](/public/imported_attachments/1/can't select.gif_thumb)

                                        /Perry
                                        doc.pfsense.org

                                        1 Reply Last reply Reply Quote 0
                                        • H
                                          heiko
                                          last edited by

                                          I have the same behaviour

                                          1 Reply Last reply Reply Quote 0
                                          • H
                                            heiko
                                            last edited by

                                            Hello,

                                            1.) What is with time overlaps in the configured ranges?

                                            2.) I have created a passing rule "icmp allowed to WAN" from the schedule 15:30- 15:45. The Rule is created on 15:20 Uhr. At this time no schedule is set on the rule. The Ping is OK. Now, i disabled the Rule (green arrow), nothing happens… Then I kill the states and all works fine.

                                            At 15:25 i change the rule, enabled and a schedule with one configured range from 15:30 to 15:45. Save and all runs fine. At 15:30 +-/ one minute, the schedule runs active, but whe the time is over, nothings happens.

                                            I edit and save the rule without changes, so now time is really over and the ping is dead.....

                                            Greetings
                                            heiko

                                            1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post
                                            Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.