Problem with web uploads in new dansguardian 2.12.0.3

rjcrowder

Looked at the "diff" file for Patch 11 (the dg patch relating to maxuploadsize) and it seems obvious that something is amiss… I'm not sure why FOptionContainer.cpp isn't picking up the maxuploadsize from my group config (dansguardianf1.conf) file but it definitely is not...

BTW Marcelo, if you can get 2.12.0.3 working the diff makes it clear that you can remove maxuploadsize from the dansguardian.conf (and the limits screen). The code to read it in OptionContainer.cpp was removed!

As for me, I'm currently using the 2.12.0.2 dansguardian executable - although I'm a little nervous about the "memory leaks" that were supposedly fixed in 2.12.0.3.

marcelloc

Are you using package version 0.1.7_1?

rjcrowder

Yes. 0.1.7_1 Even tried uninstall/reinstall several times. Per my previous messages, I've tried every possible combination I can think of for setting the maxuploadsize value in both the limit and group settings. I also checked that the GUI was setting maxuploadsize correctly in dansguardian.conf and dansguardianf1.conf. Bottom line… everything is working fine from the GUI package perspective, but the 2.12.0.3 dansguardian executable doesn't seem to read the setting - no matter what I try. If I simply swap the dansguardian executable for the 2.12.0.2 or 2.12.0.0 version, everything works fine.

Also... like I said in my previous post, when/if we actually get 2.12.0.3 working - you can see from the patch diff file that the maxuploadsize setting in dansguardian.conf is no longer used. You could remove it from the "limits" page...

@marcelloc:

Are you using package version 0.1.7_1?

marcelloc

It's not working even if you set it to -1 on group options?

asterix

I had said the same last week when I installed the newly released version.

http://forum.pfsense.org/index.php/topic,43786.msg312070.html#msg312070

asterix

@marcelloc:

It's not working even if you set it to -1 on group options?

Tried that already. Does not work.

rjcrowder

Agreed…. it does not work with -1 in the group options... I also tried setting it to a value... doesn't work.

@asterix:

@marcelloc:

It's not working even if you set it to -1 on group options?

Tried that already. Does not work.

marcelloc

I've fixed the code. ;D

The patch 11 was malformed and broke up web upload check.

I did not pushed it to dansguardian devel or freebsd patch yet.

Test my dansguardian package and see if it works

I've also included the code to limit upload size(was not working on 2.12.0.2 AFAIK)

amd64
http://e-sac.siteseguro.ws/packages/amd64/8/All/dansguardian-2.12.0.3_1.tbz

i386
http://e-sac.siteseguro.ws/packages/8/All/dansguardian-2.12.0.3_1.tbz

Do not forget to kill dansguardian process before trying new packge binaries.

rjcrowder

Thanks Marcello… that's awesome! I'm currently traveling - so I won't be able to check it till Friday. Will let you know as soon as I do though...

@marcelloc:

I've fixed the code. ;D

The patch 11 was malformed and broke up web upload check.

I did not pushed it to dansguardian devel or freebsd patch yet.

Test my dansguardian package and see if it works

I've also included the code to limit upload size(was not working on 2.12.0.2 AFAIK)

amd64
http://e-sac.siteseguro.ws/packages/amd64/8/All/dansguardian-2.12.0.3_1.tbz

i386
http://e-sac.siteseguro.ws/packages/8/All/dansguardian-2.12.0.3_1.tbz

Do not forget to kill dansguardian process before trying new packge binaries.

samham

Marcello when will you push the patch?

marcelloc

@samham:

Marcello when will you push the patch?

I've pushed it to dansguardian sourceforge project.

But not for freebsd ports.

I'm waiting feedbacks to see if there are other bugs that I can help to fix.

rjcrowder

Seems to work. Thanks!

cirkit

I am a noob to freebsd but faced the same problem above, I downlaoded the new package (modified) extracted dansguardian from sbin and pasted it in sbin of my pfsense box and it worked
Is it necessary to replace the other files?

marcelloc

no, just dansguardian bin.

I've uploaded dansguardian bin to my personal repo :)

i386
killall dansguardian
cd /usr/local/sbin
fetch http://e-sac.siteseguro.ws/pfsense/8/dansguardian

amd64
killall dansguardian
cd /usr/local/sbin
fetch http://e-sac.siteseguro.ws/pfsense/8/amd64/dansguardian

dig1234

patched binary worked for me, Thanks!

awsiemieniec

ditto on the fix, thanks! ;D

neil

I have just set up Dansguardian for a large site and have experienced the same "web upload is banned" as reported in this thread.

Package Manager shows 2.12.0.3pkg v.0.1.7_3.

I've tried downloading the patched binary from http://e-sac.sitesguro.ws/pfsense/8/amd64/dansguardian
after killing dansguardian.
When I try to start the new binary I get the message:

/usr/local/sbin/dansguardian: 1: Syntax error: ")" unexpected
./dansguardian.sh WARNING: failed to start dansguardian

Are you able to help me here, and in particular what steps do I need to follow to resolve the "web upload is banned" problem - thanks

PS. to be able to save this post, I had to put an exception for forum.pfsense.org into the sites exception list, to avoid having this post blocked by the same error for which I am seeking help!

marcelloc

@neil:

I've tried downloading the patched binary from http://e-sac.sitesguro.ws/pfsense/8/amd64/dansguardian
after killing dansguardian.
When I try to start the new binary I get the message:

/usr/local/sbin/dansguardian: 1: Syntax error: ")" unexpected
./dansguardian.sh WARNING: failed to start dansguardian

If you copied only dansguardian binary, it should start as it does not touch dansguardian.sh file.

try to save dansguardian config again to recreate startup script.

neil

Thanks for the quick reply - I did as you suggested, made a change in DG/PFsense, and saved the change - presumably this recreates the dansguardian.sh script - unfortunately no change.

Just to recap all I did was:

1. killall dansguardian
2. cd /usr/local/sbin
3. mv dansguardian dansguardian.orig (ie backed up the old version)
4. fetch https://e-sac….....etc
This retrieved a file of size 994216 dated feb 8.
The permissions on this file did not match those on the old version and in particular were not executable.
So I typed chmod 555 dansguardian and the permissions then matched (ie -r-xr-xr-x)
5. cd /usr/local/etc/rc.d
6. ./dansguardian.sh start

This resulted in the error I reported.

When I copy the original dansguardian binary back again, the startup script runs without any error.

Any further thoughts?

marcelloc

@neil:

Any further thoughts?

No. :( Except for the mv dansguardian dansguardian.orig I've did it again here and it started up fine.