BOUNTY: Web GUI reprogramming

Supermule

In the video it looks like it reverts back to 2 columns in the end??

charlie0440

it becuase I change back to the pfsense_ng theme.

This is a new theme called full_screen. Its a theme so it doesn't touch much core code ie break anything else.

the widescreen package is quite hacky changing lots of files etc. this only changes the index.php slightly all the rest is part of the theme files (its still a hack tho)

charlie0440

if anyone wants to test it. Download it here: https://dl.dropboxusercontent.com/u/12367642/full_screen_theme.zip

extract the zip to a folder ie tmp

you need to place the files onto pfsense.

In linux from a terminal:
cd /location/of/folder/tmp
scp -r * root@192.168.0.50:/usr/local/www/

Remeber to change the ip address ;)

Then on the webgui select the theme full_screen

Edit for 2.1 only (not sure if it'll work with 2.0.x)

Clear-Pixel

@charlie0440:

Something like this ;) http://youtu.be/dYNSF3zIHlM

That is achieved using jQuery no changes have been made to pfsense's core, it is added as part of the theme (so far so good). The problem is, as I said before, I can't work out how the Ajax code is working with saving the states. So as soon as you navigate away from the dash we are back to 2 columns >:(

Not sure what type of database pfsense is utilizing, but a record would need to be created for this task, so the column count state can be stored and be retrieved when a page loads or a refresh occurs.

OR

Look for a jquery cookie plugin and store the column value there.

OR

Haven't had a need to arise yet to try this, but you might be able to rewrite the default variable value of the column count in the jquery file itself. File of course would have to be set to read & write which I don't really like but the security might not be a concern depending on the deployment.

Note:
There is a need for a enhanced Menu. It should be in a side bar and capable of expanding and collapsing! There is a template already with a side bar menu that can be modified! The problem with the exsiting it its not collapsible!

See my previous reply's

charlie0440

@clear-pixel Don't think you read the last few posts before posting. I solved that problem of storing the column number a few posts back.

I hear what your saying about the GUI. I think the way to go is to get all the css and as much js as we can out of the HTML/PHP pages and into .css & .js files. Then we can work on stuff like collapsible menus and fancy stuff. But until that is done, it would be a nightmare.

stephenw10

I would personally not want collapsible menus unless there was a very good reason for it. I can't think of one, but I'm open to suggestions. ;)

Steve

Supermule

I think the one we have now is fine like in the pfsense_ng theme.

Its just the number of columns, drag and drop and especially the save issue that bothers me.

Clear-Pixel

@stephenw10:

I would personally not want collapsible menus unless there was a very good reason for it. I can't think of one, but I'm open to suggestions. ;)

Steve

The majority want and understand the purpose of collapsible menus.

charlie0440

@supermule have you tried my theme?

stephenw10

Perhaps I've misunderstood. Like I said I'm open to suggestions.

Steve

Supermule

Not yet Charlie.

Been busy as fook!

@charlie0440:

@supermule have you tried my theme?

c0urier

@charlie0440:

if anyone wants to test it. Download it here: https://dl.dropboxusercontent.com/u/12367642/full_screen_theme.zip

extract the zip to a folder ie tmp

you need to place the files onto pfsense.

In linux from a terminal:
cd /location/of/folder/tmp
scp -r * root@192.168.0.50:/usr/local/www/

Remeber to change the ip address ;)

Then on the webgui select the theme full_screen

Edit for 2.1 only (not sure if it'll work with 2.0.x)

I tried the following and am able to create extra coloums, but I am not able to save them. As soon as I hit "Save Settings" it jumps back to default two coloums.
I have cleared cache/cookies etc. does not chance anything, any advice would be greatly appreciated.

Supermule

The columns are hard coded into PFSense. Unfortunately….

charlie0440

@Supermule:

The columns are hard coded into PFSense. Unfortunately….

This is easily amended without breaking or effecting any code. See my changes here especially the comments : https://github.com/CharlieMarshall/pfsense/commit/93916e320f6d0a7cfc1cf884a73e93cfe1c7f99c

@c0urier:

I tried the following and am able to create extra coloums, but I am not able to save them. As soon as I hit "Save Settings" it jumps back to default two coloums.
I have cleared cache/cookies etc. does not chance anything, any advice would be greatly appreciated.

Interesting it works perfect here. Are you trying to save with an empty column? What happens if you add a new column and add a widget to that columns so you have at least one widget in each columns and click save. Which version of pfsense are you using, 2.0 or 2.1?

Edit - I changed the zip file I linked to yesterday. The one you downloaded was it called full_screen.zip or full_screen_theme.zip ?

Edit 2 - Need more testers. Can anyone else try this ?

c0urier

I tried with and without Widgets, with 1 and 3 widgets - no Changes.

I'm Running 2.1-RC0.

~~full_screen.zip was the one I downloaded.~~ full_screen_theme.zip

charlie0440

re download from the link. It should be called full_screen_theme.zip and report back

c0urier

Tested again after having downloaded the package. It's the same result.

charlie0440

hmm i'll have to investigate further. Just downloading the latest snapshot to check there hasn't been a change that is affecting it. I am currently running a build from 17th May.

Again can anyone else test this out?

Edit - Works fine for me on 28th May snapshot

c0urier

My exact version is:
2.1-RC0 (amd64)
built on Thu May 23 20:43:32 EDT 2013
FreeBSD 8.3-RELEASE-p8

Clear-Pixel

@charlie0440:

@clear-pixel Don't think you read the last few posts before posting. I solved that problem of storing the column number a few posts back.

I hear what your saying about the GUI. I think the way to go is to get all the css and as much js as we can out of the HTML/PHP pages and into .css & .js files. Then we can work on stuff like collapsible menus and fancy stuff. But until that is done, it would be a nightmare.

Do you think, or do you know you fixed it?