BOUNTY: Web GUI reprogramming

charlie0440

The columns are hard coded into PFSense. Unfortunately….

This is easily amended without breaking or effecting any code. See my changes here especially the comments : https://github.com/CharlieMarshall/pfsense/commit/93916e320f6d0a7cfc1cf884a73e93cfe1c7f99c

@c0urier:

I tried the following and am able to create extra coloums, but I am not able to save them. As soon as I hit "Save Settings" it jumps back to default two coloums.
I have cleared cache/cookies etc. does not chance anything, any advice would be greatly appreciated.

Interesting it works perfect here. Are you trying to save with an empty column? What happens if you add a new column and add a widget to that columns so you have at least one widget in each columns and click save. Which version of pfsense are you using, 2.0 or 2.1?

Edit - I changed the zip file I linked to yesterday. The one you downloaded was it called full_screen.zip or full_screen_theme.zip ?

Edit 2 - Need more testers. Can anyone else try this ?

c0urier

I tried with and without Widgets, with 1 and 3 widgets - no Changes.

I'm Running 2.1-RC0.

~~full_screen.zip was the one I downloaded.~~ full_screen_theme.zip

charlie0440

re download from the link. It should be called full_screen_theme.zip and report back

c0urier

Tested again after having downloaded the package. It's the same result.

charlie0440

hmm i'll have to investigate further. Just downloading the latest snapshot to check there hasn't been a change that is affecting it. I am currently running a build from 17th May.

Again can anyone else test this out?

Edit - Works fine for me on 28th May snapshot

c0urier

My exact version is:
2.1-RC0 (amd64)
built on Thu May 23 20:43:32 EDT 2013
FreeBSD 8.3-RELEASE-p8

Clear-Pixel

@charlie0440:

@clear-pixel Don't think you read the last few posts before posting. I solved that problem of storing the column number a few posts back.

I hear what your saying about the GUI. I think the way to go is to get all the css and as much js as we can out of the HTML/PHP pages and into .css & .js files. Then we can work on stuff like collapsible menus and fancy stuff. But until that is done, it would be a nightmare.

Do you think, or do you know you fixed it?

charlie0440

~~Well it works fine on my setup but appears not to be working for c0urier. Perhaps you could test it too?~~

Edit - Yes it works

stephenw10

Maybe a 32bit/64bit issue? Is there anything compiled in there?

It works fine for me on a 32bit nano install, a few ~~days~~ weeks old though:

2.1-BETA1 (i386)
built on Wed May 15 13:19:07 EDT 2013

Looks good. :)

Steve

charlie0440

Thanks for testing Stephen.

~~Its odd it's not working for c0urier as the only changes are a few lines to the index.php and some added Jquery to a javascript file.

@c0urier I pm'd you~~

c0urier

The index.php file was located in /usr/local/www/themes for some reason.
But I can't explain why it ended there as it asked to overwrite index.php.

It works now, thanks!

charlie0440

Glad to here it! ;)

For anyone else trying this please make sure when copying you copy the files to the correct location you need to be copying from the root of the zip files ie if you extracted the zip to a folder called tmp you need to cd into tmp
cd /location/of/folder/tmp/
scp -r * root@192.168.0.50:/usr/local/www/

that will place index.php to /usr/local/www/index.php (overwrite)
and the full_screen folder to /usr/local/www/themes/full_screen

charlie0440

tiny bug fix to bring this inline with my github.

Found a bug a few days ago where it was adding the add/delete column buttons to the picture widget

If your updating it may be easier to make the change yourself (usr/local/www/themes/full_screen/loader.js line 111):

change

jQuery('form')

to:

jQuery('form[action="index.php"]')

as seen here: https://github.com/CharlieMarshall/pfsense/commit/0e94111d38c67d56901df3573e8af29afaf767d8

or download the whole theme from:

download link: https://dl.dropboxusercontent.com/u/12367642/full_screen_theme.zip
youtube video: http://youtu.be/irglXyn41Ys
Installation instructions: http://forum.pfsense.org/index.php/topic,48140.msg338715.html#msg338715

Supermule

Also working for 2.0.3?

charlie0440

@Supermule:

Also working for 2.0.3?

Afraid not, jQuery is a requirement which got added in 2.1.

I can try and hack one together for you.

Supermule

That would be awesome!

Then we could have a package for that if possible!

stephenw10

There seem to be some spurious add/delete column buttons on the RRD graph page.

Steve

charlie0440

See about 5 posts above. I think that will fix it. Let me know if not

stephenw10

Hmm, yes I saw that and made the change. Perhaps the old file is cached. I'll look again.
Edit: Yep, fixed. :)

Steve

c0urier

I can't get this working with current RC.
2.1-RC0 (amd64)
built on Wed Jun 12 06:19:17 EDT 2013

I've tried to redownload the package:
cd /usr/local/www
fetch https://dl.dropboxusercontent.com/u/12367642/full_screen_theme.zip
unzip full_screen_theme.zip

index.php source:
http://pastebin.com/0vZbd5qk