DHCPd with multiple ipv4 subnets outside of local interface network. (300US$)

[bennyc]

as already confirmed through pm  :)

I already updated my system with your code, and can confirm it works.

Test sequence:

• add device on the network
• obtained lease from additional pool
• go to the DHCP leases page, select "+" next to the address of interest
• arrived on the "Services: DHCP: Edit static mapping" page, where you can edit/save the mapping
• entry is added in the dhcpd.conf file as follows:

host s_lan_0 {
	hardware ethernet 3c:c2:43:ca:xx:xx;
	fixed-address 192.168.3.1;
	option host-name "Win8Phone";
}

• afterwards, this host shows as static in "Status: DHCP leases", and the "+" sign is red and inactive

[shade]

Marcelloc:

I have updated my PFsense with your patch, and can confirm that it works.

Now static leases on subnet and WOL works.

Looking forward to see it in upstream - Excellent work, two thumbs up :)

WetWilly: Have you tried it ?

[marcelloc]

Pull request sent. ;D

I had to change some parts for 2.2 but it's done again!

https://github.com/pfsense/pfsense/pull/816

[shade]

Marcelloc:

I have now added several "sub" scopes, and alot of static leases and everything works as excepted :)

It is first time I have tried a bounty and are also a "new" pfsense user, so I have a few mabee newbie questions:

• When 2.1.1 are leases, are the patch still active ? or shall it be reapplied ? or is it even compatible ?
• Will that be the same for each release up to 2.2 when is it included upstream ?
• I have read the guidelines about payment and are a little confused  ? Can I just sent you a paypal payment, or is that against policy ?

To the other creators of this bounty, I feel the bounty is solved, how about you ?

[marcelloc]

@shade:

• When 2.1.1 are leases, are the patch still active ? or shall it be reapplied ? or is it even compatible ?

If there is no changes to files I've modified between 2.1 and 2.1.1 it will work fine.

@shade:

• Will that be the same for each release up to 2.2 when is it included upstream ?

Since pull request is merged. It will be part of pfsense 2.2

@shade:

• I have read the guidelines about payment and are a little confused  ? Can I just sent you a paypal payment, or is that against policy ?

Just send to my paypal account. marcellocoutinho@gmail.com

[bennyc]

I agree with Shade, the bounty is completed I think. (though I'm not an autor)
If Marcelloc gets all his payments, the bounty can be moved to the "completed" section…

[marcelloc]

@bennyc:

If Marcelloc gets all his payments, the bounty can be moved to the "completed" section…

Not yet. I received only from you and shade.

Total bounty US$ 1.100 received US$ 550

[bennyc]

Hi Marcelloc,

I know it's already been a while, but I think I encountered  a couple of things we missed.
Sub-pools work fine… but when adding a static mapping for a client in a sub-pool, it does not hand out WINS/DNS: not the default, not the ones I put there. (not so good  ::) )
It also doesn't complain if I use an ip within the pool range? (can live with that)
When removing the static mapping (but leaving it in the sub-pool), the dhcp deamon hands out both fine.

So the issue is on the static mapping creation. (writing to the dhcpd.conf to be more precise, at least I think it is)

When looking to the dhcpd.conf, it gets written correctly except for the option "domain-name-server", that part is missing even if I update it in the static mapping (it does not add it to the part "host s_lan_0":

(partial code)

host s_lan_0 {
	hardware ethernet 00:50:56:ad:6f:c1;
	fixed-address 192.168.9.11;
	option host-name "REMOTE-7";
	option routers 192.168.9.254;
}
subnet 192.168.9.0 netmask 255.255.255.0 {
	pool {
		option domain-name-servers 192.168.1.254;
		option routers 192.168.9.254;
		range 192.168.9.1 192.168.9.10;
	}

Went through the code from services_dhcp.php (quickly) as I suspect the issue is there (might be wrong), but it seems my coding knowledge is still too limited, can't point it out yet  :-[

Can you still check this please?

tnx & br, Benny.

[marcelloc]

Sorry for the late response.
I'm really busy these days but I'll take a look as soon as possible.

[shade]

@marcelloc:

Not yet. I received only from you and shade.

Total bounty US$ 1.100 received US$ 550

Are BennyC and me still the only two who have paid you ?

[marcelloc]

@shade:

Are BennyC and me still the only two who have paid you ?

Unfortunately only you two. :(

[bennyc]

that's not very nice  ???
pm them I would say…

[Rerity9]

What I do to stay fit for me. Not need to be downloaded on the web too. I will get back with you.

[madstupid]

Hi All,

I would like to implement this solution to my FW running an updated version 2.1.1.(32bit)

What I did: I copied the files from Github " https://github.com/pfsense/pfsense/pull/816" and overwrote the ones on my system but then rebooted the FW and nothing worked.

How did you guys get it to work?

Thank you.

[bennyc]

By paying marcelloc  ;D

No seriously, you should. Get in contact with him, contribute. This bounty was never completed because some people did not pay, even though his solution works.
I have it working on 2.1 since beginning of bounty, stable, and serving addresses for 6 scopes. Currently porting from 2.1 -> 2.1.2, and on my 2.1.2 test system it's already working again with his mods. So it should work for your 2.1.1 also…

Otherwise you need to be patient, his work has been polled/merged for 2.2.

[madstupid]

I wish I could contribute but my situation is not good ATM. Can anyone help before v2.2 is released?

Thanks in advance.

[bennyc]

If you get a -posted here- agreement from Marcelloc (pm him, that's a "condicio sine qua non"), I'm willing to guide you through (invest my time in you).
Until publicly released/included in 2.2, the work is his…

(sorry, this sounds only fair to me)

-edit: removed typo-

[marcelloc]

sure bennyc, you paid for this code.

btw, i'll have to code it again and send for the third time the pull request…

[bennyc]

Yes, but technically the bounty is not complete  ::)
And I do respect your work -as it should-, so I thought it was only fair we got your approval for this  ;)
That being said, I sure hope you get that pull request working. (otherwise I would need to implement the feature manually each upgrade :( Not an impossible task, but would like to avoid that if possible)
If you ever should need help for testing this feature again, do not hesitate to contact me…

@madstupid, I will pm you the instructions I got from Marcelloc.

[va176thunderbolt]

How much of the bounty is still outstanding? I'd like to kick some funds.

Adam