2.1.5 widescreen patch - multiple columns on dashboard

Supermule

Just change the font in your browser to Tahoma or change the default size to .9

kcallis

Thanks, that fixed that problem…

Supermule

Youre welcome!

charlie0440

@kcallis

Go to system > patches and apply this commit:

https://github.com/CharlieMarshall/pfsense/commit/2b5c16b9c6ee3dcb9a1333b44949f48024eb3cd0

kcallis

It has been added…

AhnHEL

Charlie, is there a way to fix the picture widget using a 4 column dashboard? Using a picture that is 350 x 350, but the picture doesnt fill up the width of the column. Using a larger or smaller pic just causes the pic to zoom in or out respectively without filling up the column width.

This is only with 2.1.5. On my 2.2 Alpha box, the picture fills up the width of the column properly.

pfPic.jpg_thumb

charlie0440

Yes. As I said in my opening post. I have not included all he changes here which are in 2.2. If I have some spare time today, I'll back port the fix to 2.1.5 and upload it here

Supermule

AWESOME!

charlie0440

@AhnHEL - Was a super simple fix:

Apply via:

System patches using commit:
https://github.com/CharlieMarshall/pfsense/commit/7a775e8bf1a4771ee8d0217a2f66d415f9abc302
Or make the necessary changes yourself via GUI > edit file
Or paste the whole file into the broswer via GUI > edit file: https://raw.githubusercontent.com/CharlieMarshall/pfsense/7a775e8bf1a4771ee8d0217a2f66d415f9abc302/usr/local/www/widgets/widgets/picture.widget.php

Edit: You are not limited to 350 x 350, all images should hopefully now scale

Supermule

Would it be possible to get this a package for 2.1.5 since its ready and works fine??

Could it be done easily?

charlie0440

I read the documentation a while ago about packages and I got really confused :o

If someone wants to do it then i'll happily provide the files.

RonpfS

So could I get widescreen under 2.1.4 by just appling the patch https://github.com/CharlieMarshall/pfsense/commit/7a775e8bf1a4771ee8d0217a2f66d415f9abc302 ?

AhnHEL

@charlie0440:

Yes. As I said in my opening post. I have not included all he changes here which are in 2.2.

Totally missed that part.

Much appreciated for your fix, thank you sir. Works perfectly. 8)

KOM

So could I get widescreen under 2.1.4 by just appling the patch

Yes. I'm running it under 2.1.4.

RonpfS

@KOM:

So could I get widescreen under 2.1.4 by just appling the patch

Yes. I'm running it under 2.1.4.

I did a test and it says it can not be reverted ?

Patch can be applied cleanly (detail)

	Output of full patch apply test:

/usr/bin/patch --directory=/ -t -p1 -i /var/patches/54133c3584947.patch --check --forward --ignore-whitespace

Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|From 7a775e8bf1a4771ee8d0217a2f66d415f9abc302 Mon Sep 17 00:00:00 2001
|From: Charlie Marshall 
|Date: Thu, 11 Sep 2014 14:10:25 +0100
|Subject: [PATCH] Fix picture widget size & improve browse button
|
|---
| usr/local/www/widgets/widgets/picture.widget.php | 4 ++--
| 1 file changed, 2 insertions(+), 2 deletions(-)
|
|diff --git a/usr/local/www/widgets/widgets/picture.widget.php b/usr/local/www/widgets/widgets/picture.widget.php
|index 12aacae..40ecee8 100644
|--- a/usr/local/www/widgets/widgets/picture.widget.php
|+++ b/usr/local/www/widgets/widgets/picture.widget.php
--------------------------
Patching file usr/local/www/widgets/widgets/picture.widget.php using Plan A...
Hunk #1 succeeded at 73.
Hunk #2 succeeded at 81.
done

Patch can NOT be reverted cleanly (detail)

	Output of full patch revert test:

/usr/bin/patch --directory=/ -f -p1 -i /var/patches/54133c3584947.patch --check --reverse --ignore-whitespace

Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|From 7a775e8bf1a4771ee8d0217a2f66d415f9abc302 Mon Sep 17 00:00:00 2001
|From: Charlie Marshall 
|Date: Thu, 11 Sep 2014 14:10:25 +0100
|Subject: [PATCH] Fix picture widget size & improve browse button
|
|---
| usr/local/www/widgets/widgets/picture.widget.php | 4 ++--
| 1 file changed, 2 insertions(+), 2 deletions(-)
|
|diff --git a/usr/local/www/widgets/widgets/picture.widget.php b/usr/local/www/widgets/widgets/picture.widget.php
|index 12aacae..40ecee8 100644
|--- a/usr/local/www/widgets/widgets/picture.widget.php
|+++ b/usr/local/www/widgets/widgets/picture.widget.php
--------------------------
Patching file usr/local/www/widgets/widgets/picture.widget.php using Plan A...
Hunk #1 failed at 73.
Hunk #2 failed at 81.
2 out of 2 hunks failed--saving rejects to usr/local/www/widgets/widgets/picture.widget.php.rej
done

So I should backup picture.widget.php before in case something goes wrong .

I guess I have to get the tar file first !

KOM

I should have mentioned that I used to original method from the beginning of the thread:

fetch -o /tmp https://dl.dropboxusercontent.com/u/12367642/2.1.5_widescreen.tar.gz
tar -zxvf /tmp/2.1.5_widescreen.tar.gz -C /

RonpfS

I fetch your tar ball (couldn't fetch doktornotor's one from mega)
Then I applied the patch for picture.widget.php
Once the patch is applied, it show I can revert it … ;D

charlie0440

About patches in pfsense gui. Someone correct me if I'm wrong but I belive when you click test it will only show if it can be applied cleanly. Once applied it will show if it can now be reverted cleanly. It can't be both and you can't revert something which hasn't been changed.

I found this confusing at first because the message makes it look like you can apply a patch and not revert it.

Gerard64

@kcallis:

I have tried it and I am still getting an issue where the Help tab is right below the System tab. Is there any way that I could just remove help for the time being? This is preventing me from accessing option on the System menu.

Go to /etc/inc open globals.inc and find "disablehelpmenu" => false, and change it to "disablehelpmenu" => true,

Untitled-1.png_thumb

RonpfS

Did and upgrade from 2.1.4 to 2.1.5

Reinstall the tar ball, widescreen is back but there is no Add/Delete button, so I am stuck with 2 columns display