Alias

Gabri.91

Synced with master but it isn't completely fixed:

Alias as source host and source port -> Fine
Alias as source host and destination host -> Destination is not linked\editable
Alias as source host and destination port -> Fine
Alias as destination host and destination port -> Destination host alias shows port instead of host

I haven't tried to mix with 3 or 4 aliases.

Also, I've found another small bug: when you open for edit a rule that have a source port range different from any, advanced should be automatically open like in 2.2.X,
otherwise it will be possible to misunderstanding the rule..

Thanks

Steve_B

Thanks.

"advanced should be automatically open" is in progress under another ticket (Its the same for all pages)

I'll look at the others.

Steve_B

I cleared up a further bug which caused either src or dst aliases to be displayed, but not both.

Please give it a try and let me know how it works for you.

Thanks again.

Steve_B

FYI - I have removed the pencils. They just clutter up the display. Hover over an alias to view it's constituents, click it to edit.

Gabri.91

I confirm that now seems to working fine in all conditions.
Regarding pencils I agree.

PS: I've found that in 2.2.X hover shows also descriptions (both for main alias and for each sub-item) while in 2.3 isn't shown any description.
Personally I rarely use them but someone could notice this as a problem.

phil.davis

PS: I've found that in 2.2.X hover shows also descriptions (both for main alias and for each sub-item) while in 2.3 isn't shown any description.
Personally I rarely use them but someone could notice this as a problem.

Showing the entry descriptions would be good. I often have aliases that are for "special client systems" that are used in a rule to give them an exception for something. In that case the IP addresses in the alias are just some "random-looking" IP addresses in LAN subnet. In the description I put something useful for a human to read.

Steve_B

I'll see what I can do :)

Steve_B

Pop-up layout converted from a list to a table, and alias descriptions added.

BBcan177

Would be great if you could add a Sort option to the Aliases, or even an option to move the Lines (similar to the Firewall rules…)

Some Aliases can get unwieldy when adding/removing IPs over time..

Maybe a Sort option like this? With the option to either Sort by the IP/Description field. or Skip the sort function?


$alist = array(explode(' ', $alias['address']), explode('||', $alias['detail']));

array_multisort($alist[0], SORT_ASC, SORT_NUMERIC, $alist[1]);
$config['aliases']['alias'][$key]['address'] = implode(' ', $alist[0]);
$config['aliases']['alias'][$key]['detail'] = implode('||', $alist[1]);

Steve_B

We can add that as a feature request.