PPPoE IPV6 interface edit

maverick_slo

Guys this one is easy to replicate.

I just installed latest 2.3 then checked config as in screenshot and it produces this file: /var/etc/dhcp6c_lan.conf

interface pppoe0 {
	request domain-name-servers;
	request domain-name;
	script "/var/etc/dhcp6c_lan_script.sh"; # we'd like some nameservers please
};

So there is something very wrong with how interfaces.php or interfaces.inc generates this config file.

snip5.PNG_thumb

Steve_B

In my configuration I see:

<adv_dhcp6_id_assoc_statement_prefix_enable>yes</adv_dhcp6_id_assoc_statement_prefix_enable>

while David suggests it should be:

<adv_dhcp6_id_assoc_statement_prefix_enable>Selected</adv_dhcp6_id_assoc_statement_prefix_enable>

I can certainly change that.

maverick_slo

Ummm ok what about .conf file?
Is it irrelevant what is there if in xml is correct?

hda

Then it looks like an error due to the GUI change?
Tomorrow I will make a CF with 2.3 and test it, I use a same config as you but with a /48 now on 2.2.6 no problem.

Steve_B

I just pushed a change to make certain of the checkboxes have a value of "Selected" rather than "yes". In 2.2.x this was being done in Javascript and was missed when the file was converted.

Let's see if that helps.

maverick_slo

Will test tomorrow. Thanks!

maverick_slo

Just a question..
Gitsync or snapshot?

Br,G

David_W

@Steve_B:

In my configuration I see:

<adv_dhcp6_id_assoc_statement_prefix_enable>yes</adv_dhcp6_id_assoc_statement_prefix_enable>

while David suggests it should be:

<adv_dhcp6_id_assoc_statement_prefix_enable>Selected</adv_dhcp6_id_assoc_statement_prefix_enable>

I'd be surprised if that makes any difference, as the test used in DHCP6_Config_File_Advanced() is:
if ($wancfg['adv_dhcp6_id_assoc_statement_prefix_enable'] != '') {
…
}

In other words, anything that is not a null string should work. I posted "Selected" because that is what was in the working configuration I had to hand, which originated from 2.2.x.

I'm more of a back end person than a UI person - I know what is meant to happen in response to certain elements in $config or a configuration file. If maverick_slo can get a non-null string in $config['interfaces'][[i]interface]['adv_dhcp6_id_assoc_statement_prefix_enable'], the configuration should be generated correctly.

Hopefully you and others who are more familiar with the user interface can figure out what is going wrong, Steve!

Steve_B

"I'd be surprised if that makes any difference,"

Yeah, me too, but you never know :)

Unfortunately, I m still unable to reproduce the error, making it very hard to trouble-shoot.

In particular, I don't understand how the "Apply" action is changing the config file or the /var/etc/dhcp6_xxx.conf file, but I understand that is what is happening.

Click "Save" and things look good. Then click apply and the config(s) are no longer correct. Right maverick_slo?

As another test, I put:

if ($_POST) {
print_r($_POST);
exit;
}

at about line 447 of interfaces.php (just above "if ($_POST['apply']) {" so that I can see what is being posted. I did this on pfSense 2.2.5 as well an saw that the results are identical.

Of course since I can't reproduce the error, this may mean nothing.

maverick_slo

Well well weeeell :)
Gitsynced and bam:

/var/etc/dhcp6c_opt2.conf looks like:

interface pppoe0 {
	send ia-pd 0;
	request domain-name-servers;
	request domain-name;
	script "/var/etc/dhcp6c_opt2_script.sh";
};
id-assoc pd 0 { };

And now everything works just as expected.

Also tested on my vanilla setup and it works (it didn`t before).

I think that some other pages might also require attention but haven`t found one yet.

Thanks all!

Steve_B

Yay!

Thank you so much everyone. The time you took to help track this down is very much appreciated.