Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Consistency of panel-heading

    Scheduled Pinned Locked Moved 2.3-RC Snapshot Feedback and Issues - ARCHIVED
    5 Posts 2 Posters 1.5k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • P
      phil.davis
      last edited by

      Various GUI forms have different panel-heading, e.g.

      firewall_rules.php

      firewall_aliases.php

      Forms like firewall_nat and firewall_nat_npt are also different like this. The size difference of the panel heading is noticeable when changing between forms.

      Which is the way it is supposed to be? "h2" or not?

      I someone sets the policy then I am happy to make it all consistent.

      As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
      If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

      1 Reply Last reply Reply Quote 0
      • S
        Steve_B Netgate
        last edited by

        Is used by the Form_* framework, so we should use the same style when creating panels "by hand".

        On inspecting the HTML source of a PHP created panel, you will see something like this:

        
## General DNS Forwarder Options

        Als ik kan

        1 Reply Last reply Reply Quote 0
        • P
          phil.davis
          last edited by

          OK, that's what I expected. Where it is missing, I will adjust panel-heading div's to also have the

          stuff - PR to come.

          As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
          If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

          1 Reply Last reply Reply Quote 0
          • P
            phil.davis
            last edited by

            PR https://github.com/pfsense/pfsense/pull/2440

            As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
            If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

            1 Reply Last reply Reply Quote 0
            • S
              Steve_B Netgate
              last edited by

              Merged.

              Thanks Phil

              Als ik kan

              1 Reply Last reply Reply Quote 0
              • First post
                Last post
              Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.