Firewall rules hitcount for pfSense 2.1.5 and 2.2.4

[BBcan177]

@marcelloc:

The trackerid is used to count rules match.
If it get merged one day we will need to change the way pfblocker get his rules.

pfBlockerNG is already using tracker IDs…

The issue with the current "Rule Count" code, is that its modifying the Description field in certain coditions which removes the human-readable text.... So I don't think the code in the pfBNG package needs to be changed. Let me know if you see it differently and I will consider making changes to the pfBNG code.

Thanks

[marcelloc]

Great. But first the code merge :)

[RonpfS]

@marcelloc:

The trackerid is used to count rules match.
If it get merged one day we will need to change the way pfblocker get his rules.

But the patches changes things in "Status: System logs: Firewall" and "pftop/Label", not the pfBlockerNG tabs.

[loos]

I'm working to merge this request, but in a way it doesn't break any of existing code.

We'll have this for 2.3.

Thanks for this great contribution.

[bennyc]

@loos:

I'm working to merge this request, but in a way it doesn't break any of existing code.

We'll have this for 2.3.

Thanks for this great contribution.

Sounds great, thanks !  :) :)

[marcelloc]

It's close to get merged  8) after loos-br function added to 2.3

https://github.com/pfsense/pfsense/pull/1901

[brandur]

Exciting ;D
(fingers crossed)

[JackL]

Congrats Marcelloc!

Ou did an excellent work with the hitcount. I look forward to see the feature in pfSense 2.3! ;)

[]`s
Jack

[Valex]

Great work marcelloc!
Hope this feature will be in 2.3 because it is so useful.
Last idea of Renato seems to be great too because you have dynamic counters without reloading the page.

Edit: Seems like Renato is merging it ;)

[jimp]

2.3 does now have a hit counter on the rules view, though it was reworked a bit in the process.

[JackL]

@jimp:

2.3 does now have a hit counter on the rules view, though it was reworked a bit in the process.

Great!

Congrats for all! ;-)

[]`s
Jack