Unsticky separators

Steve_B

If you obtained the latest code via gitsync, a reboot would have restored correct separator position.

NOYB

A follow on to what Steve said.

If you realigned the separators prior to doing a post gitsync reboot, you can expect them to be out of order again after the next reboot (I think, maybe).

brianc69

I've been updating from the web gui when I notice a new update. Sometimes I skip it and do it the next day rather than updating two or three times a day.

Steve_B

I have just completed another round of testing on the rules and separators and all seems to be well.

We did discover that the upgrade script could break things under certain circumstances, and I have just pushed a fix for that.

(NOYB: If all separators on a tab are removed, then <separators><tab>is no longer an array, so foreach() barfs)

If you continue to have a problem and are comfortable editing the config.xml file, I would completely remove both <separator>sections from that file (nat and filter)</separator></tab></separators>

NOYB

Great. Thanks for the fix.

By the way is it normal expected behavior to require a reboot after gitsync in order for the config rev to take effect?

I get this in syslog as expected.
pfSsh.php: Start Configuration upgrade at 17:24:13, set execution timeout to 15 minutes

but only on very rare occasion it is followed by this:
pfSsh.php: Ended Configuration upgrade at 17:24:13

iamzam

All separator issues seem fixed for me now, except one case where if I add two separators and move them into place before clicking save (before apply), only one is retained and I think it moves the remaining separator down one rule as well.

I also note for the first time that moving rules/separators around the page is very snappy now on OSX Firefox 44.0.1 which is great!

Thanks for the help!

NOYB

@iamzam:

… if I add two separators and move them into place before clicking save (before apply), only one is retained and I think it moves the remaining separator down one rule as well.

Earlier I was able to reproduce this. Now I cannot. I know some changes were made today but nothing I would expect to affect this.

"Nobody said this was going to be easy"
https://www.youtube.com/watch?v=qSHxHlRwmcI

NOYB

@iamzam:

I also note for the first time that moving rules/separators around the page is very snappy now on OSX Firefox 44.0.1 which is great!

Glad you noticed and like it. That was the reason for the change. To be more efficient by not loading all the other interface rules and hiding them. This necessitated re-indexing the separators to just the rules of each interface.

A lot of work, and a few bumps. But think it was well worth it. And it's nice to see that you noticed.

"I love it when a plan comes together"
https://www.youtube.com/watch?v=FPQlXNH36mI

athurdent

Found a new way to unintentionally reorder separators on my setup.
I have LAN and DMZ rules with separators. When I copy a LAN rule and change the interface to DMZ, separators move where they should not.

NOYB

Looks like the edit/dup/copy needs some logic to grab the interface from the rule settings being submitted so it updates the separators of that interface. The logic could be a bit tricky since the float rule separators need to use the selected interface (FloatingRules). Pretty sure it can be resolved though.

If someone else doesn't get to it sooner I'll look at it in day or two.

In the meantime:

You should open a bug report. Select Bug Database from the Help menu.
Follow the doctors advice. If that hurts then don't do that. ;)

NOYB

Pull request submitted:

https://github.com/pfsense/pfsense/pull/2684

Steve_B

Merged/tested. Thank you.