Bug mineur dans le widget "Captive Portal Status"

Gertjan

When you use the "Captive Portal Status" widget - and you delete an active connection, a strange 'interface' effect will happen.
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/widgets/widgets/captive_portal_status.widget.php#L96

$showact will be "0" on first call, but after deleting a active connection, $showact will be set as showact=0 and thus
$showact = isset($_GET['showact']) ? 1 : 0;
will be "1" (because 'showact' is "set" (to "0" ;)))

This works for me:

$showact = isset($_GET['showact']) ? ($showact = intval($_GET['showact'],2)) : 0;

Btw : I'm using 2.2.6-RELEASE (amd64) and as far as I could find out, the new 2.3 Beta has the same issue ….
Should I 'redmine' this ?

jimp

If you can replicate it on 2.3, it should definitely get a ticket on redmine.pfsense.org

Gertjan

I'm not using "2.3".

If this https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/widgets/widgets/captive_portal_status.widget.php#L96 IS 2.3, then the (small !) bug is definitely there.

Opening a ticket on redmine without actually using the version 2.3 where I post a ticket for, euh, noop, sorry.

Knowing it's a really minor issue, it can wait (when I shift to 2.3 beta …).