PfSense 2.2.1 - Captive portal bug?

Derelict

https://redmine.pfsense.org/issues/3124

XanderVR

https://redmine.pfsense.org/issues/3124

I can confirm this was the solution to the double forms.
However, the other issues still stand: the wrong error message: Invalid credentials specified.

Gertjan

With the patch proposed above, this:
@XanderVR:

However, the other issues still stand: the wrong error message: Invalid credentials specified.

(which is the second instance of error-login-page)
shouldn't show up any more ….

I deducted this from reading the code.

XanderVR

@Gertjan:

With the patch proposed above, this:
@XanderVR:

However, the other issues still stand: the wrong error message: Invalid credentials specified.

(which is the second instance of error-login-page)
shouldn't show up any more ….

I deducted this from reading the code.

Unfortunately this is not the case.
I changed the lines as was specified in the bug report.
This solved the case of the second form showing up.

When I now enter a voucher code that has been used by someone esle, AND is currently active, I get the message that the voucher is already activated by someone else.
When I enter an invalid voucher code, I get the error message: "Invalid credentials specified" and not "Invalid voucher"
When I enter a voucher code that has already expired, I get the error message: "Invalid credentials specified", and not "Voucher expired"

So where does it go wrong?
This is just a plain install of pfSense 2.2.1
No plugins/addons/etc, the only change is the one mentioned in the bugreport.

Gertjan

@XanderVR:

So where does it go wrong?

Guess what ?

Its a bug ….
I'll put a patch up.

Derelict

So what?

Captive portal needs a complete rewrite. Looks like it'll be in python.

Until then, it's working generally correctly. I'm sure patches making the messages saner would be graciously accepted.

Gertjan

It's a simple one.

Use the "System Patches" package to to apply it (or do it by hand):
https://github.com/Gertjanpfsense/pfsense/commit/4828d672b1fbb06e45c272b329aafcfa9b9a8e20.patch

https://github.com/Gertjanpfsense/pfsense/commit/4828d672b1fbb06e45c272b329aafcfa9b9a8e20

The trouble was: $config['voucher'][$cpzone]['msgexpired'] (and $config['voucher'][$cpzone]['msgnoaccess']) do not exist - the default error message $errormsg ( = "Invalid credentials specified."; ) is always shown.

I applied the parch on my own copy of pfSense. Looking good so far.
Expired vouchers are signaled as should be.
The more general error 'msgnoaccess' also.

XanderVR

That made sense :)

Just changed the code and indeed it works now :)
Thank you very much

Gertjan

I did some research about side-effect. Found none.

Pull request against 'master' posted : https://github.com/pfsense/pfsense/pull/1587

(twisting my fingers for that my SLA agreement is still valid, etc)

edit: Pull accepted. Thanks XanderVR for bringing this up :)

bmginn

@Gertjan:

I did some research about side-effect. Found none.

Pull request against 'master' posted : https://github.com/pfsense/pfsense/pull/1587

(twisting my fingers for that my SLA agreement is still valid, etc)

edit: Pull accepted. Thanks XanderVR for bringing this up :)

It seems these prefixes are present in 2.3.2, but I'm still experiencing the same issue as OP; the double login boxes with double errors. Any ideas?

Gertjan

@bmginn and @th112211 compare your pfSense version with the one mentioned in subject of this thread.

I advise you to open a new thread and detail what you found out.

Btw : I'm not using vouchers.