2.3.3 generate gui cert caused crash

grandrivers

amd64
10.3-RELEASE-p12
FreeBSD 10.3-RELEASE-p12 #414 d20b991(RELENG_2_3): Wed Dec 28 15:55:28 CST 2016 root@ce23-amd64-builder:/builder/pfsense/tmp/obj/builder/pfsense/tmp/FreeBSD-src/sys/pfSense
pfSense shell: generateguicert
pfSense shell: exec

Parse error: syntax error, unexpected end of file in /usr/local/sbin/pfSsh.php(396) : eval()'d code on line 6

Call Stack:
0.0038 214832 1. {main}() /usr/local/sbin/pfSsh.php:0
58.8670 1232664 2. playback_text() /usr/local/sbin/pfSsh.php:294

Crash report details:

PHP Errors:
[31-Dec-2016 10:08:54 America/New_York] PHP Parse error: syntax error, unexpected end of file in /usr/local/sbin/pfSsh.php(396) : eval()'d code on line 6
[31-Dec-2016 10:08:54 America/New_York] PHP Stack trace:
[31-Dec-2016 10:08:54 America/New_York] PHP 1. {main}() /usr/local/sbin/pfSsh.php:0
[31-Dec-2016 10:08:54 America/New_York] PHP 2. playback_text() /usr/local/sbin/pfSsh.php:294

Filename: /var/crash/minfree
2048

phil.davis

I just tried that on a VM that is up-to-date with 2.3.3-DEVELOPMENT and it worked fine.

Do you have some odd text in /etc/phpshellsessions/generateguicert
https://github.com/pfsense/pfsense/blob/RELENG_2_3/src/etc/phpshellsessions/generateguicert

grandrivers

heres contents of file

/*

generateguicert
part of pfSense (https://www.pfsense.org)
Copyright 2016 Rubicon Communications, LLC (Netgate)
All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in
* the documentation and/or other materials provided with the
* distribution.
3. All advertising materials mentioning features or use of this software
* must display the following acknowledgment:
* "This product includes software developed by the pfSense Project
* for use in the pfSense software distribution. (http://www.pfsense.org/).
4. The names "pfSense" and "pfSense Project" must not be used to
* endorse or promote products derived from this software without
* prior written permission. For written permission, please contact
* coreteam@pfsense.org.
5. Products derived from this software may not be called "pfSense"
* nor may "pfSense" appear in their names without prior written
* permission of the Electric Sheep Fencing, LLC.
6. Redistributions of any form whatsoever must retain the following
* acknowledgment:
"This product includes software developed by the pfSense Project
for use in the pfSense software distribution (http://www.pfsense.org/).
THIS SOFTWARE IS PROVIDED BY THE pfSense PROJECT ``AS IS'' AND ANY
EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE pfSense PROJECT OR
ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
OF THE POSSIBILITY OF SUCH DAMAGE.
*/

require_once("system.inc");

echo gettext("Generating a new self-signed SSL certificate for the GUI...");
$cert = system_webgui_create_certificate();
echo gettext("Done.\n");
echo gettext("Restarting webConfigurator...");
send_event("service restart webgui");
echo gettext("Done.\n");

phil.davis

That looks fine.

Is there anyone else who can reproduce this?

grandrivers

ok bumped to latest snapshot and it appears to have worked

jimp

Neither that file nor pfSsh.php have changed in months, and when it did it was just the license. Something fishy might be going on with your disk. Might want to reboot into single user mode and run "fsck -y /" a few times to make sure it's clean.