Temperature Fahrenheit /Celsius Option and Alarms
-
I'll kick in $20 just for the Fahrenheit option.
[Edited to Add: $20 USD sent via PayPal on 12/22/17 after code was successfully merged into pfSense master branch.]
I looked at the code, but I'm a noob with PHP (looks similar to JavaScript though) and a noob with building pfSense. The conversion from C to F is simple. I think what looks challenging (to me, as a noob) is to update the GUI System Preferences (maybe in Advanced? where would the Celsius/Fahrenheit setting look best?) as well as updating the Dashboard with the new F temperature(s) and all the Temp widgets. Plus that colored meter goes from 0 - 100 degrees C = 0 - 100% so it'd have to be tuned to Fahrenheit as well….so 32 - 212 F?
-
-
Is this still wanted? I've put something together but cant find a way to test the package installing. Don't want it released for public consumption without more testing.
-
Very interested in this will this even happen??
-
The OP has never responded to me. The work is done but I've still not found any way to test the install process.
-
If Fahrenheit is selected, I'd like to only see Fahrenheit in the UI, not both.
-
If Fahrenheit is selected, I'd like to only see Fahrenheit in the UI, not both.
That's a heck of a lot more complicated to achieve because the system uses Celsius internally. This is a very minor modification to the UI files that does the conversion live and displays the result
-
https://github.com/pfsense/pfsense/pull/3891
This patch adds a preference to the thermal sensors widget, which is also read by the system information widget.
Notification is the job of a network monitoring system, not pfSense. (Your pfSense can't email you about high temperatures if its CPU is a puddle of molten slag!)
-
https://github.com/pfsense/pfsense/pull/3891
This patch adds a preference to the thermal sensors widget, which is also read by the system information widget.
Notification is the job of a network monitoring system, not pfSense. (Your pfSense can't email you about high temperatures if its CPU is a puddle of molten slag!)
Looks awesome, sir! Hope they merge the PR.
Was curious, maybe a quick Find & Replace:
- getCelciusValue() –> getCelsiusValue()
- celc --> cels
-
https://github.com/pfsense/pfsense/pull/3891
This patch adds a preference to the thermal sensors widget, which is also read by the system information widget.
Notification is the job of a network monitoring system, not pfSense. (Your pfSense can't email you about high temperatures if its CPU is a puddle of molten slag!)
Looks awesome, sir! Hope they merge the PR.
Was curious, maybe a quick Find & Replace:
- getCelciusValue() –> getCelsiusValue()
- celc --> cels
LOL I was paying too much attention to spelling Fahrenheit correctly that I messed up the easy one!
-
And since this is the bounty forum, if any of the original requesters want to step up, it would be accepted gratefully.
https://www.paypal.me/miken32
or if you're Canadian, email money transfer works better; my username at eire.ca.
-
Looks awesome, sir! Hope they merge the PR.
Until then, here's how to apply it. The changed files are saved with an "orig" suffix:
curl https://patch-diff.githubusercontent.com/raw/pfsense/pfsense/pull/3891.diff | patch -b -d / -p 2 -u -
And since this is the bounty forum, if any of the original requesters want to step up, it would be accepted gratefully.
https://www.paypal.me/miken32
or if you're Canadian, email money transfer works better; my username at eire.ca.
I did the work before you arrived and nobody ever responded to me. I suspect the less than friendly responses to the original request put people off.
-
And since this is the bounty forum, if any of the original requesters want to step up, it would be accepted gratefully.
https://www.paypal.me/miken32
or if you're Canadian, email money transfer works better; my username at eire.ca.
I did the work before you arrived and nobody ever responded to me. I suspect the less than friendly responses to the original request put people off.
I wouldn't call it "less than friendly" just someone pointing out the likely reason that this work wasn't done as part of the original product (i.e. nobody uses Fahrenheit except Americans; though it's also used in Belize and Bahamas as well as a few other small island nations.)
I think it is a fairly common (though certainly not universal) pattern on this board. Random people show up and make requests, someone does the work and then the OP is never heard from again. I'm not in it for the money anyway, else I wouldn't have posted my code on Github. Just wanted to contribute to the project that helps me earn a living. If someone finds enough value in it to reward me personally, so much the better!
-
Just noticed this thread.
I'm game. I'd be interested in throwing in another $20 to see this implemented. It's critical to know that your equipment isn't cooking. -
Just noticed this thread.
I'm game. I'd be interested in throwing in another $20 to see this implemented. It's critical to know that your equipment isn't cooking.The pull request got merged back in December 2017. I'm seeing the new code in 2.4.3 Development branch. I assume this will also hit 2.4.3 Release once it comes out.
-
Nice! Well thank you for the update. I think it'll be a handy addition to PfSense. Getting alerts your stuff is hot is just as important as getting alerts that your stuff is crashing.
-
Nice! Well thank you for the update. I think it'll be a handy addition to PfSense. Getting alerts your stuff is hot is just as important as getting alerts that your stuff is crashing.
My patch only adds the option for changing the unit of measurement displayed. Adding alerting is beyond the scope of what a firewall is supposed to do; that's what network monitoring systems are for!
-
After reading GitHub, I read that the option is changed on the Dashboard under "Thermal Sensors" widgit while before reading this I was wasting time looking at "System Information" widgit. Thank YOU!!!
@miken32 Here's a different map to look at when deciding to use Fahrenheit.
-
Bump.