PfBlockerNG-devel 2.1.2

BBcan177

@netgate-james said in PfBlockerNG-devel 2.1.2:

@netgate-james Also this in Alerts
PHP ERROR: Type: 1, File: /usr/local/pkg/pfblockerng/pfblockerng.inc, Line: 3958, Message: Call to a member function bindValue() on boolean @ 2018-07-05 13:11:20

I have only seen this on a few systems. So far the solution has been to change the SQLite3 PRAGMA journal_mode from "wal" to "delete". I haven't had much time to investigate the reason. Before I post a fix, I want to do some additional testing, however; you can test the following:

If you can edit the file:

/usr/local/pkg/pfblockerng/pfblockerng.inc

and change the following line 3842
https://github.com/pfsense/FreeBSD-ports/blob/devel/net/pfSense-pkg-pfBlockerNG-devel/files/usr/local/pkg/pfblockerng/pfblockerng.inc#L3842

From:

$db_handle->exec("PRAGMA journal_mode = wal;");

To:

$db_handle->exec("PRAGMA journal_mode = delete;");

A Former User

@bbcan177 patch applied, will follow-up with results. Thank you BBcan177!!

A Former User

@BBcan177 been looking good since applying the change. Apparently this popped up

Crash report begins. Anonymous machine information:

amd64
11.2-RELEASE
FreeBSD 11.2-RELEASE #28 5bbe95e97b4(factory-RELENG_2_4_4): Thu Jul 5 00:38:07 EDT 2018 root@buildbot3:/builder/crossbuild-master/pfSense/tmp/obj/builder/crossbuild-master/pfSense/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[06-Jul-2018 10:41:38 America/New_York] PHP Warning: SQLite3::exec(): database is locked in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3842

No FreeBSD crash data found.

No adverse behavior observed thus far.

Edit: Had another two of these same crash reports generate.

Edit: make that three .. still no adverse side-effects though.

vladimirlind

Pfsense (latest dev snap) keeps crashing with this warning on "Update" webgui tab :

Warning: Use of undefined constant pfb_status - assumed 'pfb_status' (this will throw an Error in a future version of PHP) in /usr/local/www/pfblockerng/pfblockerng_update.php on line 385 Warning: Use of undefined constant pfb_output - assumed 'pfb_output' (this will throw an Error in a future version of PHP) in /usr/local/www/pfblockerng/pfblockerng_update.php on line 392

vladimirlind

Here is the crashreport I caught:

Crash report begins. Anonymous machine information:

arm
11.2-RELEASE
FreeBSD 11.2-RELEASE #2 3f33035c36f(factory-RELENG_2_4_4): Tue Jul 10 15:36:43 EDT 2018 root@buildbot3:/builder/crossbuild-master/obj/armv6/C5dYt69Q/arm.armv6/builder/crossbuild-master/pfSense/tmp/FreeBSD-src/sys/pfSense-SG-3100

Crash report details:

PHP Errors:
[11-Jul-2018 15:33:20 Europe/Moscow] PHP Warning: Illegal string offset 'vip' in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 1128
[11-Jul-2018 15:33:21 Europe/Moscow] PHP Warning: Illegal string offset 'vtype' in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 6320
[11-Jul-2018 15:33:21 Europe/Moscow] PHP Warning: Illegal string offset 'key' in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 6321
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 6995
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 6995
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 6995
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 7000
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 7000
[11-Jul-2018 15:33:23 Europe/Moscow] PHP Warning: count(): Parameter must be an array or an object that implements Countable in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 7000

No FreeBSD crash data found.

RonpfS

https://forum.netgate.com/topic/132659/php-warning-illegal-string-offset-vip-in-usr-local-pkg-pfblockerng-pfblockerng-inc-on-line-1128

Okijames

@bbcan177

amd64
11.1-RELEASE-p10
FreeBSD 11.1-RELEASE-p10 #13 r313908+293707af843(RELENG_2_4): Thu May 10 15:09:24 CDT 2018 root@buildbot2.netgate.com:/builder/ce-243/tmp/obj/builder/ce-243/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[11-Jul-2018 17:37:26 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 4053
[11-Jul-2018 17:37:28 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3958
[11-Jul-2018 17:37:28 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3958

No FreeBSD crash data found.

Details: This is on an APU2 and corresponds with (Jul 11 17:37:23 kernel pid 41538 (php), uid 0 inumber 6266 on /var: filesystem full) . I used default pfsense partitioning during installation and /var is 58MB. This on a 256GB mSATA SSD with >200GB free in /. Good times! :)

@netgate-james Did changing wal to delete fix the issue for you?

A Former User

@okijames said in PfBlockerNG-devel 2.1.2:

@bbcan177

amd64
11.1-RELEASE-p10
FreeBSD 11.1-RELEASE-p10 #13 r313908+293707af843(RELENG_2_4): Thu May 10 15:09:24 CDT 2018 root@buildbot2.netgate.com:/builder/ce-243/tmp/obj/builder/ce-243/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[11-Jul-2018 17:37:26 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 4053
[11-Jul-2018 17:37:28 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3958
[11-Jul-2018 17:37:28 America/Los_Angeles] PHP Fatal error: Call to a member function bindValue() on boolean in /usr/local/pkg/pfblockerng/pfblockerng.inc on line 3958

No FreeBSD crash data found.

Details: This is on an APU2 and corresponds with (Jul 11 17:37:23 kernel pid 41538 (php), uid 0 inumber 6266 on /var: filesystem full) . I used default pfsense partitioning during installation and /var is 58MB. This on a 256GB mSATA SSD with >200GB free in /. Good times! :)

@netgate-james Did changing wal to delete fix the issue for you?

See: https://forum.netgate.com/post/775962

The crashes are fewer and farther between, on a recent (not current) 2.4.4 snap (before php56 went to php72).

BBcan177

@okijames said in PfBlockerNG-devel 2.1.2:

@netgate-james Did changing wal to delete fix the issue for you?

If you have already changed "wal" to "delete" and are still experiencing those issues, can you try the following:

Delete the sqlite dbs and run a Force Reload - All to rebuild them.

rm /var/db/pfblockerng/dnsbl.sqlite*
rm /var/db/pfblockerng/dnsbl_cache.sqlite*
rm /var/db/pfblockerng/dnsbl_levent.sqlite*

Okijames

I have 4GB RAM so increasing /var RAMDISK to see what happens.

Okijames

Holding strong and working great at 26% of 250GB on /var.

bbrendon

@bbrendon said in PfBlockerNG-devel 2.1.2:

Any idea when this new version is going to be a "non-devel" version?

I ask because 2.1 has some really annoying bugs. I'm trying to decide how long I should hold out or just install the devel version.

jacotec

@bbrendon said in PfBlockerNG-devel 2.1.2:

I ask because 2.1 has some really annoying bugs. I'm trying to decide how long I should hold out or just install the devel Version

Same here, I went for the devel 2 weeks ago and I'm happy so far.
Take care to switch the update branch to "unstable" first and grab the devel from there, then you can switch the update branch back to stable (no need to go to unstable with pfSense itself).

Uninstall the 2.1 first, your settings will be preserved. I made a snapshot of my pfSense VM first so I felt really safe ;-)

4ROMANY

I've been having similar issues with this error:
/usr/local/pkg/pfblockerng/pfblockerng.inc: New alert found: PHP ERROR: Type: 1, File: /usr/local/pkg/pfblockerng/pfblockerng.inc, Line: 3958, Message: Call to a member function bindValue() on boolean.

Been happening for some time - not sure when it started - but I'm currently running 2.4.4-Dev. I made the change that was suggested - changing "wals" to "delete" - so I'll try to report back in a few days. When this PHP issue occurred CPU load for the PHP process would be very high - to the point you could not log in even via serial console. Most of the time you could log in but could not do anything - even reboot seems to hang.

4ROMANY

@4romany

So been about a week now and changing "journal_mode = delete" seems to have fixed my issue.

BBcan177

@4romany

Thanks for the feedback. I still can figure out why the "wal" setting is fine for most users, but not others....

Okijames

Just a follow up from last month.

Still working fine with stock "wal" setting after I increased /var RAMDISK from 60MB to 250MB. FWIW /var is currently showing about 75MB used so I am assuming the "filesystem full" issue would have continued to trigger the aforementioned PfBlocker crashes.

Guessing that "delete" consumes less /var space?

BBcan177

@okijames said in PfBlockerNG-devel 2.1.2:

Just a follow up from last month.
Still working fine with stock "wal" setting after I increased /var RAMDISK from 60MB to 250MB. FWIW /var is currently showing about 75MB used so I am assuming the "filesystem full" issue would have continued to trigger the aforementioned PfBlocker crashes.
Guessing that "delete" consumes less /var space?

These SQL db's are tiny and shouldn't take much space:

ls -lah /var/db/pfblockerng/dnsbl*.*

Would be great if others chimed in on their pfSense version/Hardware/etc...

Okijames

You're right the dbs are tiny. Other files in the referenced dir really add some bulk. I'm probably overdoing it with the number of feeds. :) See du -ch ouput below.

For reference, running 2.4.3 on APU2 with 4GB RAM and 250GB MSATA drive. Default /var was 60MB and encountered the crashes noted above coincident with /var full messages. Expanded /var to 250MB, presently running at 75MB used, and having no further crashes.

ls -lah /var/db/pfblockerng/dnsbl*.*
-rw-r--r-- 1 root wheel 8.0K Aug 2 21:16 /var/db/pfblockerng/dnsbl.sqlite
-rw-r--r-- 1 root wheel 8.0K Aug 2 21:13 /var/db/pfblockerng/dnsbl_cache.sqlite
-rw-r--r-- 1 root wheel 12K Aug 2 21:16 /var/db/pfblockerng/dnsbl_levent.sqlite

du -ch /var/db/pfblockerng/
4.0K /var/db/pfblockerng/match
4.0K /var/db/pfblockerng/ET
348K /var/db/pfblockerng/original
4.0K /var/db/pfblockerng/native
348K /var/db/pfblockerng/deny
4.0K /var/db/pfblockerng/permit
6.5M /var/db/pfblockerng/dnsbl
9.6M /var/db/pfblockerng/dnsblorig
6.2M /var/db/pfblockerng/dnsblalias
24M /var/db/pfblockerng/
24M total

4ROMANY

@bbcan177

2.4.4-DEVELOPMENT (amd64)
built on Fri Jul 27 07:50:35 EDT 2018
FreeBSD 11.2-RELEAS

Intel(R) Celeron(R) CPU 3215U @ 1.70GHz
2 CPUs: 1 package(s) x 2 core(s)
AES-NI CPU Crypto: No

I started having the PHP error issue when up upgraded to DEV - some weeks back. At the same time I redid the way I had PFBLOCKERNG set up (also upgraded that to pfBlockerNG-devel). So far with the "delete" set I've been stable since July 26th...