haproxy-devel 0.59_1 net and haproxy 0.58_5 crash on install

PiBa

Whats your starting point? A fresh pfSense install? Or a existing config? I presume the second..
I can uninstall/reinstall on 2.4.4 here without this specific issue popping up... It seems configuration specific.?.

Would it be possible to share the configuration with me? the <haproxy> part that is.. and then still look over it for private info..

amassi

@piba said in haproxy-devel 0.59_1 net and haproxy 0.58_5 crash on install:

<haproxy>

<haproxy>
<configversion>00.57</configversion>
<ha_backends>
<item>
<name>fqdn</name>
<desc>fqdn</desc>
<status>active</status>
<secondary></secondary>
<primary_frontend></primary_frontend>
<type>http</type>
<forwardfor></forwardfor>
<httpclose>http-keep-alive</httpclose>
<extaddr></extaddr>
<backend_serverpool>pclocal</backend_serverpool>
<max_connections></max_connections>
<client_timeout></client_timeout>
<port></port>
<advanced_bind></advanced_bind>
<ssloffloadcert>5a00e091d8a11</ssloffloadcert>
<dcertadv></dcertadv>
<ssloffload></ssloffload>
<ssloffloadacl></ssloffloadacl>
<ssloffloadacl_an>yes</ssloffloadacl_an>
<ssloffloadacladditional></ssloffloadacladditional>
<ssloffloadacladditional_an></ssloffloadacladditional_an>
<sslclientcert-none></sslclientcert-none>
<sslclientcert-invalid></sslclientcert-invalid>
<sslocsp></sslocsp>
<socket-stats></socket-stats>
<dontlognull></dontlognull>
<dontlog-normal></dontlog-normal>
<log-separate-errors></log-separate-errors>
<log-detailed></log-detailed>
<advanced></advanced>
<ha_acls>
<item>
<name>Backend1acl</name>
<expression>host_matches</expression>
<not></not>
<value>fqdn</value>
<url_parameterparameter></url_parameterparameter>
<backendservercountbackend></backendservercountbackend>
<_index></_index>
</item>
</ha_acls>
<ha_certificates></ha_certificates>
<clientcert_ca></clientcert_ca>
<clientcert_crl></clientcert_crl>
<a_extaddr>
<item>
<extaddr>wan_ipv4</extaddr>
<extaddr_custom></extaddr_custom>
<extaddr_port>443</extaddr_port>
<extaddr_ssl>yes</extaddr_ssl>
<extaddr_advanced></extaddr_advanced>
<_index></_index>
</item>
</a_extaddr>
<a_actionitems></a_actionitems>
<a_errorfiles></a_errorfiles>
</item>
</ha_backends>
<ha_pools>
<item>1</item>
<item>
<ha_servers>
<item>
<status>active</status>
<name>pclocal</name>
<forwardto></forwardto>
<address>myip</address>
<port>80</port>
<ssl></ssl>
<weight></weight>
<sslserververify></sslserververify>
<verifyhost></verifyhost>
<ssl-server-ca></ssl-server-ca>
<ssl-server-crl></ssl-server-crl>
<ssl-server-clientcert></ssl-server-clientcert>
<cookie></cookie>
<maxconn></maxconn>
<advanced></advanced>
<_index></_index>
<id>103</id>
</item>
</ha_servers>
<a_acl></a_acl>
<a_actionitems></a_actionitems>
<advanced></advanced>
<advanced_backend></advanced_backend>
<name>pclocal</name>
<balance></balance>
<balance_urilen></balance_urilen>
<balance_uridepth></balance_uridepth>
<balance_uriwhole></balance_uriwhole>
<transparent_clientip></transparent_clientip>
<transparent_interface>lan</transparent_interface>
<check_type>HTTP</check_type>
<checkinter></checkinter>
<log-health-checks></log-health-checks>
<httpcheck_method>OPTIONS</httpcheck_method>
<monitor_uri></monitor_uri>
<monitor_httpversion></monitor_httpversion>
<monitor_username></monitor_username>
<monitor_domain></monitor_domain>
<monitor_agentport>pclocal</monitor_agentport>
<agent_check></agent_check>
<agent_port></agent_port>
<agent_inter></agent_inter>
<connection_timeout></connection_timeout>
<server_timeout></server_timeout>
<retries></retries>
<stats_enabled></stats_enabled>
<stats_username>admin</stats_username>
<stats_password>ml123sd45t</stats_password>
<stats_uri></stats_uri>
<stats_scope></stats_scope>
<stats_realm></stats_realm>
<stats_admin></stats_admin>
<stats_node></stats_node>
<stats_desc></stats_desc>
<stats_refresh></stats_refresh>
<persist_stick_expire></persist_stick_expire>
<persist_stick_tablesize></persist_stick_tablesize>
<persist_stick_length></persist_stick_length>
<persist_stick_cookiename></persist_stick_cookiename>
<persist_sticky_type>none</persist_sticky_type>
<persist_cookie_enabled></persist_cookie_enabled>
<persist_cookie_name></persist_cookie_name>
<persist_cookie_mode>passive</persist_cookie_mode>
<persist_cookie_cachable></persist_cookie_cachable>
<strict_transport_security></strict_transport_security>
<cookie_attribute_secure></cookie_attribute_secure>
<email_level></email_level>
<email_to></email_to>
<errorfiles></errorfiles>
<id>102</id>
</item>
</ha_pools>
<email_mailers></email_mailers>
<dns_resolvers></dns_resolvers>
<files>
<item></item>
</files>
<enable></enable>
<maxconn>10</maxconn>
<logfacility>local0</logfacility>
<loglevel>info</loglevel>
<localstats_refreshtime></localstats_refreshtime>
<localstats_sticktable_refreshtime></localstats_sticktable_refreshtime>
<log-send-hostname></log-send-hostname>
<ssldefaultdhparam>2048</ssldefaultdhparam>
<email_level></email_level>
<email_myhostname></email_myhostname>
<email_from></email_from>
<email_to></email_to>
<resolver_retries></resolver_retries>
<resolver_timeoutretry></resolver_timeoutretry>
<resolver_holdvalid></resolver_holdvalid>
</haproxy>

amassi

hi,
some news :
I clear my configuration backup from <haproxy></haproxy>
restore configuration
install haproxy-devel who make me error because there are some information empty
restore my old configuration with all configuration...
haproxy is running ... one more time i had error. But when i check interface configuration i find an backend line with nothink...
Now haproxy-devel is working... lets see the next upgrade

PiBa

@amassi
Hmm yap, seems this is a strange 'item 1' in the config, not sure where that can come from, might be some old history? (have you been using haproxy for a long time?) or perhaps a 'config upgrade' that did something weird.:

<ha_pools>
	<item>1</item>

Ill try and make the function that failed on it a bit more resistant to such things now that i know what to look for :).

amassi

i think it s an old heritage.. Lets see later after next upgrade

BN82

I know get an error with haproxy-devel-0.59_5 on pfsense 2.4.4.a.20180728.1912

PHP errors

PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy.inc, Line: 1476, Message: Uncaught Error: Cannot create references to/from string offsets in /usr/local/pkg/haproxy/haproxy.inc:1476
Stack trace:
#0 /usr/local/pkg/haproxy/haproxy.inc(2385): haproxy_writeconf('/var/etc/haprox...')
#1 /usr/local/pkg/haproxy/haproxy.inc(653): haproxy_check_run(1)
#2 /etc/inc/pkg-utils.inc(760) : eval()'d code(1): haproxy_custom_php_install_command()
#3 /etc/inc/pkg-utils.inc(760): eval()
#4 /etc/inc/pkg-utils.inc(847): eval_once('haproxy_custom_...')
#5 /etc/rc.packages(74): install_package_xml('haproxy-devel')
#6 {main}
thrown @ 2018-07-29 14:58:30

Rgds,
BN

PiBa

@bn82
sry.. 0.59_6 coming up. (well once its pulled and compiled..)

amassi

hello , tried update trouble is back again ;-)

Crash report begins. Anonymous machine information:

amd64
11.2-RELEASE
FreeBSD 11.2-RELEASE #33 cd0e4c8cf25(RELENG_2_4_4): Thu Jul 26 14:30:12 EDT 2018 root@buildbot3:/builder/crossbuild-ce-master/obj/amd64/FWJoMRHc/builder/crossbuild-ce-master/pfSense/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[30-Jul-2018 10:01:06 Europe/Madrid] PHP Fatal error: Uncaught Error: Cannot create references to/from string offsets in /usr/local/pkg/haproxy/haproxy.inc:1476
Stack trace:
#0 /usr/local/pkg/haproxy/haproxy.inc(2385): haproxy_writeconf('/var/etc/haprox...')
#1 /usr/local/pkg/haproxy/haproxy.inc(653): haproxy_check_run(1)
#2 /etc/inc/pkg-utils.inc(748) : eval()'d code(1): haproxy_custom_php_install_command()
#3 /etc/inc/pkg-utils.inc(748): eval()
#4 /etc/inc/pkg-utils.inc(835): eval_once('haproxy_custom_...')
#5 /etc/rc.packages(74): install_package_xml('haproxy')
#6 {main}
thrown in /usr/local/pkg/haproxy/haproxy.inc on line 1476

No FreeBSD crash data found.

maverick_slo

Same here treid today...

PiBa

@amassi @maverick_slo

Indeed 0.59_6 is not there yet.. The PR for it is still 'open' : https://github.com/pfsense/FreeBSD-ports/pull/545
try again once its available.

q54e3w

@piba thank you, 0.59_6 fixed the issue for me.

amassi

@piba said in haproxy-devel 0.59_1 net and haproxy 0.58_5 crash on install:

PR

hank you, 0.59_6 fixed the issue for me too !

BN82

On latest snapshot (Thu Aug 23 07:20:11 EDT 2018) I got the following error :

Fatal error: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402) in /usr/local/pkg/haproxy/haproxy_utils.inc on line 105
PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)Starting CRON... done.
Aug 23 20:56:31 php-fpm[334]: /rc.newwanip: rc.newwanip: Info: starting on ovpns1.
Aug 23 20:56:31 php-fpm[334]: /rc.newwanip: rc.newwanip: on (IP address: 172.17.8.1) (interface: OPENVPN_INT[opt2]) (real interface: ovpns1).
Aug 23 20:56:32 php-fpm[334]: /rc.newwanip: PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)
Aug 23 20:56:32 php-fpm[334]: /rc.newwanip: New alert found: PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)
Aug 23 20:56:32 php-fpm[335]: /rc.start_packages: Restarting/Starting all packages.
 Starting package LADVD...done.
 Starting package haproxy-devel...
Fatal error: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402) in /usr/local/pkg/haproxy/haproxy_utils.inc on line 105
Aug 23 20:56:33 php-fpm[335]: /rc.start_packages: PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)
Aug 23 20:56:33 php-fpm[335]: /rc.start_packages: New alert found: PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)
PHP ERROR: Type: 1, File: /usr/local/pkg/haproxy/haproxy_utils.inc, Line: 105, Message: Cannot redeclare getarraybyref() (previously declared in /etc/inc/pfsense-utils.inc:3402)pfSense 2.4.4-DEVELOPMENT amd64 Thu Aug 23 07:20:11 EDT 2018
Bootup complete

Rgds,
BN

PiBa

@bn82
yup.. that function was added to base. now needs to be removed from the package

zwck

same problem on the latest nightly as well 2.4.4.a.20180826.0538 with haproxy_devel 59_9

PiBa

@zwck
indeed.. PR is still pending: https://github.com/pfsense/FreeBSD-ports/pull/555
hoped that would have been pulled a bit faster..

zwck

@piba maybe tomorrow

zwck

maybe the day after tomorrow :*(

PiBa

@zwck
Today it is
please give haproxy-devel 0.59_10 a try, if it installs properly AND no other issues are found i'm going to make the same changes for 'haproxy' package probably tomorrow. And then hopefully that to will get pulled before this week ends.

zwck

@piba I'll give you an update in approx 7hours!