Pfsense, No internet when it is said "You are connected".
-
@stephenw10 yes..kind of.
I originally faced the issue as a regular pfSense user. I am part of a network/infra team for an IT university, we are running pfSense captive portal for LAN events. We encountered the issue during one of these events.
Few weeks/month after the event, I tried to reproduce the bug using lab environment/VM (the idea was to check vaguely what caused this issue, was it reproducible?). I created the redmine ticket at that time.
I tried to understand the root cause ("when and what introduced this bug?") only few month later (for those interested, the root cause is explained at the end of this post)
-
Update :
I re applied the patch https://github.com/pfsense/pfsense/pull/4042.diff (this is the "patch ID" I used).
/etc/inc/captiveportal.inc was complaing with one chunck (the 12th one) because in "master" there is a new function :
function captiveportal_reserve_ruleno($ruleno)
so I decides to make a backup of my /etc/inc/captiveportal.inc and and replace it with the master version ( https://raw.githubusercontent.com/pfsense/pfsense/master/src/etc/inc/captiveportal.inc ).Now, the patch applies perfectly well.
Great work !
Again : applied against "2.4.4-p3" with updated (current Master) /etc/inc/captiveportal.inc
-
Ok, great.
@Gertjan I assume you are seeing this fix the issue that locks users out if you edit the captive portal?
@MTNet Can you test this patch to confirm it fixes the variant you're seeing? I'm not sure anyone else is seeing this without editing the config. If anyone else is though please test this patch against 2.4.4p3.
Steve
-
@stephenw10 said in Pfsense, No internet when it is said "You are connected".:
@Gertjan I assume you are seeing this fix the issue that locks users out if you edit the captive portal?
Yep.
It's all here : https://github.com/pfsense/pfsense/pull/4042 ^^@stephenw10 said in Pfsense, No internet when it is said "You are connected".:
I'm not sure anyone else is seeing this without editing the config.
Oh, they will. It's a valid for every captive portal setup.
- Your portal is used.
- You edit the portal config page : ipfw firewall rules are flushed, but database contains still the logged in user.
- You win : you'll see the "You are already logged in" text.
But .... because there are close to none-admins that edit their captive portal settings page after an initial system setup,, the error isn't really known - doesn't show up ...
I could see the error because I actually was looking for it.Btw : I borrowed the latest version /etc/inc/captiveportal.inc from "Master" so I might benefit other pull requests.
-
Right exactly. That patch was proven against p2 to fix the issue after editing. I would expect it to work against p3 also.
The question is; is anyone else, other than @MTNet, seeing this issue without editing the config?
If they are it needs testing against that situation.Steve
-
Why should we need any testing? MTNet has 100 deployments and its happening on all of them ;) <rolleyes>
And the overwhelming amount of technical info provided should be enough... I mean it could be put into a book its so detailed..
-
@Gertjan said in Pfsense, No internet when it is said "You are connected".:
Update :
I re applied the patch https://github.com/pfsense/pfsense/pull/4042.diff (this is the "patch ID" I used).
/etc/inc/captiveportal.inc was complaing with one chunck (the 12th one) because in "master" there is a new function :
function captiveportal_reserve_ruleno($ruleno)
so I decides to make a backup of my /etc/inc/captiveportal.inc and and replace it with the master version ( https://raw.githubusercontent.com/pfsense/pfsense/master/src/etc/inc/captiveportal.inc ).Now, the patch applies perfectly well.
Great work !
Again : applied against "2.4.4-p3" with updated (current Master) /etc/inc/captiveportal.inc
tried this steps in 2.4.4-p3. patched works but the problem is the users who are logged already in captive portal are not displaying in the captive portal status (active users)? and in the services for captive portal users, numbers of users is 0. Have you encountered this?
right now I am using 2.3.2 version. waiting for the fix to the latest version of pfsense.
thanks!
-
Please be specific about what circumstances you are seeing that under. As far as I'm aware with that patch applied in 2.4.4p3 editing the captive portal and re-saving no-longer results in users logged in but unable to connect.
However there seems to be another set of reports here for the case in which users are falling into that situation without the captive portal having been edited. If that is happening the patch would likely not address that.Steve
-
( https://raw.githubusercontent.com/pfsense/pfsense/master/src/etc/inc/captiveportal.inc ).
what i did to fix the issue is i replace the original captiveportal.inc with the captiveportal.inc from "master" w/o patching using winSCP.
sorry for my english
-
@jurhein said in Pfsense, No internet when it is said "You are connected".:
( https://raw.githubusercontent.com/pfsense/pfsense/master/src/etc/inc/captiveportal.inc ).
what i did to fix the issue is i replace the original captiveportal.inc with the captiveportal.inc from "master" w/o patching using winSCP.
sorry for my english
can you check the captive portal status (active users), if connected users are showing and in the service for captive portal users, if numbers of users is 0. thanks!
-
So are you seeing that just happen spontaneously without editing the captive portal?
Steve
-
@dyobetem
yes the connected users are showing and in the service for captive portal users the number is not 0, again i did not run the patch using system patches [package] what i did is replacing the captiveportal.inc using winSCP.. im on latest version 2.4.4 p3, and im using a shellcmd package [captiveportal_disconnect_all.php] so that when you restart the pfsense all users disconnect and then re-login
sorry my english is not good
-
@jurhein said in Pfsense, No internet when it is said "You are connected".:
@dyobetem
yes the connected users are showing and in the service for captive portal users the number is not 0, again i did not run the patch using system patches [package] what i dead is replacing the captiveportal.inc using winSCP.. im on latest version 2.4.4 p3, and im using a shellcmd package [captiveportal_disconnect_all.php] so that when you restart the pfsense all users disconnect and then re-login
sorry my english is not good
care to share that shellcmd package [captiveportal_disconnect_all.php] nad how to use that?. I want to try this also. as of now I am using 2.3.2 version of pfsense and I want to try the latest for my captive portal. thanks!
-
How is it we have people still on the 2.3 line - and not even the latest in that line?? That whole 2.3 line has been EOL and was warned about it for well over a year.
if anything why are you not on 2.3.5p2 ?
-
yeah its true that it has been EOL. maybe its just a personal preference for some of us to used that version (users using 2.3.2) and maybe some users don't want to upgrade :)
-
using the shellcmd and script is working perfectly after pfsense reboot. all connected users in captive portal are disconnected and need to login again. (this is for 2.4.4 p3 without replacing the captiveportal.inc (from master)
when i tried to replaced the captiveportal.inc it and reboot my pfsense and login again my voucher. voucher login success but its not diplaying the voucher i am using in my captive portal status and number of users connected is 0.
-
- proof that may captiveportal fix [pfsense 2.4.4 p3]
- edit captiveportal while users are login
- reboot pfsense and re-login [captive portal status and number of users connected is not 0]
- credits to @Gertjan
https://www.youtube.com/watch?v=ffZYJ3iBS10
-
that fix is using the php file (captiveportal_disconnect_all.php), and yes that is perfectly working after rebooting the pfsense.
how about the file (captiveportal.inc) that you replaced using the captiveportal.inc(master) in this link: https://raw.githubusercontent.com/pfsense/pfsense/master/src/etc/inc/captiveportal.inc
when i tried that replacing via winscp. logged in captive portals is not showing in the captive portal status and no. of users is 0. you've post in this thread that you replaced it with a new captiveportal.inc from the said link.
-
-
Hey the patch work but when we have power cycle like if we manually take off the power and do power on than again its says that "You are connected"
