One Voucher Per Device

[Gertjan]

@colleytech said in One Voucher Per Device:

@Gertjan i am still battling with this... is there a way i could use this and stil not get my two connected devices disconnected when a third login attempt is done..
the goal is to get two devices per user, then a third login will be dropped instead of it, disconnecting an already connected device..

That what's I'm doing right now. With FreeRadius.
Without it : I guess not.

[colleytech]

@Gertjan

@Gertjan said in One Voucher Per Device:

@colleytech said in One Voucher Per Device:

@Gertjan i am still battling with this... is there a way i could use this and stil not get my two connected devices disconnected when a third login attempt is done..
the goal is to get two devices per user, then a third login will be dropped instead of it, disconnecting an already connected device..

That what's I'm doing right now. With FreeRadius.
Without it : I guess not.

@Gertjan ,
kindly indulge me, whenever i do it with freeradius, two devices will connect, but a third device attempting to log in will always disconnect one of the already logged in devices, thats what i am trying to avoid,,, if there is any additional setting or line of code to be added, kindly point me to it,

[Gertjan]

@colleytech said in One Voucher Per Device:

whenever i do it with freeradius, two devices will connect, but a third device attempting to log in will always disconnect one of the already logged in devices

??
That's not my experience.

The " Simultaneous-Use := 2 " statement will not allow a third login.
It doesn't kick out one of the two already logged in users.

Example :

Room number (== uiser) 116 : 2 parents and 3 kids.
2 iPads, 3 iPhones, some Samsung device, a Kindle and some other wifi device (a portable PC ?).

The first two logins for user "116" work fine, a third one get authenticated (same user = "116" and password) but gets thrown out a couple of seconds during the REAUTHENTICATION process : the max user threshold was reached.

[colleytech]

@Gertjan said in One Voucher Per Device:

@colleytech said in One Voucher Per Device:

whenever i do it with freeradius, two devices will connect, but a third device attempting to log in will always disconnect one of the already logged in devices

??
That's not my experience.

The " Simultaneous-Use := 2 " statement will not allow a third login.
It doesn't kick out one of the two already logged in users.

Example :

Room number (== uiser) 116 : 2 parents and 3 kids.
2 iPads, 3 iPhones, some Samsung device, a Kindle and some other wifi device (a portable PC ?).

The first two logins for user "116" work fine, a third one get authenticated (same user = "116" and password) but gets thrown out a couple of seconds during the REAUTHENTICATION process : the max user threshold was reached.

@Gertjan i must be missing something,,,
i have restored the box to factory and setup captive portal fresh, with no concurrent checked, and Simultaneous-Use := 3 placed in the freeRad user, i can get just one user connected, other subsequent users disconnects the first user "not what i want"..............

no concurrent unchecked and Simultaneous-Use := 3 placed in the freeRad user, i can log in with multiple devices, "not what i want"

applying your patch to select
1.many
2. only last
3. only first
and Simultaneous-Use := 3 placed in the freeRad user, doesnt still get the job done,,,,
what can i post here for you to check

[Gertjan]

@colleytech said in One Voucher Per Device:

applying your patch to select
1.many
2. only last
3. only first

That patch has nothing to do with FreeRadius.

@colleytech said in One Voucher Per Device:

her subsequent users disconnects the first user "not what i want"..............

I have to check things tomorrow, when I'm on site.
Look at my image = log again.
See (bottom) the oldest login. Just above (log is reverse) some OTHER 116 user is disconnected ... etc.

[colleytech]

That patch has nothing to do with FreeRadius.
@Gertjan maybe u didn't test the patch,, that patch overrides every setting, anything u apply on freeRadius doesnt reflect, as far as the patch is there.. the patch is so powerful

I have to check things tomorrow, when I'm on site.
Look at my image = log again.
See (bottom) the oldest login. Just above (log is reverse) some OTHER 116 user is disconnected ... etc.

@Gertjan please do,, i wil be so grateful if i accomplish my goal

[colleytech]

@Gertjan said in One Voucher Per Device:

I have to check things tomorrow, when I'm on site.

@Gertjan , any luck?

[rayyanthameem]

This post is deleted!

[rayyanthameem]

@Gertjan said in One Voucher Per Device:

Captive portal users get message you are connected but there is no internet

I was trying to apply this patch and I'm getting below error:

Patch can NOT be applied cleanly (detail)
Patch can NOT be reverted cleanly (detail)

I can apply the patch by editing the below files,

src/etc/inc/captiveportal.inc
src/etc/inc/system.inc
src/usr/local/captiveportal/index.php

but I'm using your version of 'src/etc/inc/captiveportal.inc'

What is the solution for this?

Thanks in advance

[Gertjan]

@rayyanthameem said in One Voucher Per Device:

I was trying to apply this patch and I'm getting below error:
Patch can NOT be applied cleanly (detail)
Patch can NOT be reverted cleanly (detail)

So :

@Gertjan said in One Voucher Per Device:

See the 'other' thread that handles that subject.
See also here : https://github.com/pfsense/pfsense/pull/4042 the solution is in feedback stage. The patch can be imported 'official' (again, see other other thread for details how to do so).

This thread handles an entire other issue.

[rayyanthameem]

@Gertjan Thanks for your help, I hope this is the patch I've to apply: https://patch-diff.githubusercontent.com/raw/pfsense/pfsense/pull/4042.diff

[Gertjan]

@rayyanthameem said in One Voucher Per Device:

https://patch-diff.githubusercontent.com/raw/pfsense/pfsense/pull/4042.diff

That's the one.
As you noticed, the patch can't be applied against a 2.4.4-p3 on your device.
This is because the actual version of pfSense on github is more recent (like a 2.4.4-p4) then the version you have (2.4.4-p3).
So, first, you have to retrieve from github the most recent files for :
/etc/inc/captiveportal.inc
/usr/local/captiveportal/index.php
/etc/inc/system.inc

Then the patch can be applied.

I using it right now :

[rayyanthameem]

@Gertjan said in One Voucher Per Device:

Here we go:
This is the new /etc/inc/captiveportal.inc file:
https://pastebin.com/V6uWHNz5

Now I am using your version of 'captiveportal.inc'

Are you suggesting except 'captiveportal.inc' use everything els and apply patch?

[Gertjan]

@rayyanthameem said in One Voucher Per Device:

Now I am using your version of 'captiveportal.inc'

That won't (probably) work with the 4042 patch.

The issue of this thread, the "One Voucher use" is something different.
Because I didn't publish a patch on github (== a pull request) there is only one way to make my patch work : you have to distil yourself the modifications out of the two files mentioned above (the pastbin ones).

I made a case-study of the issue because it pops up often : limiting a voucher to ONE device.
A fact is : when some one proposes a patch against github, the patch should be supported by the author during the entire implementation time and test phase.
I'm not using vouchers myself .... and lack the time to support such an issue.

[rayyanthameem]

Basically, I want to fix both problems, I need to use the One voucher per device and also fix the 4042 issue.

by distil you mean to compare two codes and do the changes?

I've tried to do it, but there is some extra code in github version(Line 228). Please see the attached screenshot.

[Gertjan]

@rayyanthameem said in One Voucher Per Device:

by distil you mean to compare two codes and do the changes?

Exact.

@rayyanthameem said in One Voucher Per Device:

I've tried to do it, but there is some extra code in github version(Line 228). Please see the attached screenshot.

I advise you to take the latest version from github, include the patch "4042" and then, if you feel up to it, implement the voucher issue.
There are two patches :
Some updates for the GUI captive portal settings page :
https://pastebin.com/QLhNhgAW

Several lines have to be taken from
https://pastebin.com/V6uWHNz5 ( /etc/inc/captiveportal.inc )

[Iahmad]

hi all,
i started this thread but now seems alot of people have same problem so i am requesting management to add this function one voucher per device or for two devices in official release.

thanks @ajmaltms @Derelict @free4 @Gertjan @wazim4u @colleytech @rayyanthameem

[rayyanthameem]

@Gertjan Do you have the original captiveportal.inc file? then I can compare to your modification and do that modification in github version.

[Gertjan]

Noop.

The pastebin files are what's left.
I went back to version stock version.

[free4]

@rayyanthameem the stock 2.4.4-p3 file : https://github.com/pfsense/pfsense/blob/RELENG_2_4_4/src/etc/inc/captiveportal.inc