Captive portal manual logout page address

Gertjan

Yes, I'm still here.

You are using Radius -I'm not. So you tell me if everything works with your setup.

This https://github.com/pfsense/pfsense/blob/master/src/usr/local/captiveportal/index.php#L167 should probably be checked out.

Btw :

File: /usr/local/captiveportal/index.php : http://pastebin.com/scYuKTyw - index.php - compare and modify last ~ 15 lines
Basically, this parted gets inserted:

This is wrong. The cookie is laso destoyed at line 124 (see pastebin link).

dpsapao

@Gertjan:

Yes, I'm still here.

You are using Radius -I'm not. So you tell me if everything works with your setup.

This https://github.com/pfsense/pfsense/blob/master/src/usr/local/captiveportal/index.php#L167 should probably be checked out.

I also have that line sir. Here's my index link: http://pastebin.com/ZU2TNYeZ - index.php and my inc file: http://pastebin.com/1sD9iZb3
Hope you don't mind checking it out. I'm a bit lost. :'( :'( :-[

[quote]
Btw :

File: /usr/local/captiveportal/index.php : http://pastebin.com/scYuKTyw - index.php - compare and modify last ~ 15 lines
Basically, this parted gets inserted:

This is wrong. The cookie is laso destoyed at line 124 (see pastebin link).

Should i remove that part in my code?

By the way, im in the part when i clicked the "LOGOUT" i am redirected in "Disconnecting" but im still connected.
??? :o

amitaussie

Hi Gertjan,

Hope you are doing great!

I have tried this in 2.3 but its not working, any modification to make logout working in 2.3

Gertjan

Going well here :)

2.3 isn't really different when it concerns the captive portal code.

I guess the patches can be applied when you know that you have to patch the intelligent way : line numbers have changed, some code changes have been made, etc.
You have to know what you patch in, what it does - en what the actual code does.

What different is : Knowing that the "lookup-session-with-cookie" method doesn't work (most BOYD devices use bare-bone navigators that do not store the cookie) the "logout"
Added to that : Here in France "Internet" costs about nothing, so I sell it using the same price to my clients (visitors). This implies that people aren't looking to disconnect anymore.

So, you can understand that I 'm not looking anymore to have users disconnecting themselves.
(although I have a "disconnect-for-inactivity" very low : 30 minutes).

amitaussie

Thanks Dear,

I'll try to work it out.

brinch

@Gertjan
Hello Gertjan,

I read all the thread with attention.
I'm real bad in coding, i'm a network lad.

You look to know very well php, and pfsense captive portal auth and co management.
Sorry to dig out this old topic, but i have diffilculties to find the simple solution i'm looking for.

So i ask for your help sir..

All i need is a simple logout php or html page that send directly a logout command to the server and logs out the client that start that page. No action needed by the client (no click, nothing)

I tried with the examples you gave but no success, i know sh** in php..

Your help would be very much apreciated

Regards

free4

when @brinch enjoy digging up burried threads a bit too much
alt text

could you please create a new thread ?

brinch

:D
I've done it already.
But that guy mentioned is the one! @Gertjan

Gertjan

Portal logout page :

The thing is : browser got smarter these days.
Cookies aren't stored or accisble by default any more.
Browser do NOT accept popup, pages (any more) .....

So, the logout page you push out when the user logs in doesn't get show up on the user's screen as a windows or tab where the user can logout.
And you can not control the users browser settings ...

When time is money : explain the user while he is logging in that the soft-timeout is set to a very low value, which means that without user activity, the user gets disconnected fast.
Also : inform the user that he should de activated his Wifi connection on his side when he is done using your resources. If not : his credit time will get used .... So, when the user disconnects, the idle (soft) time will handle everything for you without any coding.

brinch

Ok, i understand.

But there me be a very easy way to write a simple php page that directly log out the user who launches it. No pop up, no confirmation button.

http://mypfsense:8004/logout.php

Just a function that get the session id and kill the current session.

I tried to code something with the elements you gave, but it didn't work ...

Gertjan

@brinch said in Captive portal manual logout page address:

I tried to code something with the elements you gave, but it didn't work ...

You should :
Obtain user's IP and MAC (see /usr/local/captiveportal/index.php how to get the, it's easy.

Use this to get the session ID :

Use https://github.com/pfsense/pfsense/blob/fb249aefa378172d6c246e62d15a8da40d80c5b6/src/etc/inc/captiveportal.inc#L2834 to get the session entry.

$cpentry[5] should contain the session ID.

Now call https://github.com/pfsense/pfsense/blob/fb249aefa378172d6c246e62d15a8da40d80c5b6/src/etc/inc/captiveportal.inc#L1214 using this session ID.

brinch

This post is deleted!

Gertjan

This worked for me :

<?php

require_once("captiveportal.inc");
require_once("auth.inc");
require_once("functions.inc");

global $g, $config, $cpzone, $cpzoneid;

/* Are there any portals  ? */
if (is_array($config['captiveportal'])) {
	/* For every portal (cpzone), do */
	foreach ($config['captiveportal'] as $cpkey => $cp)
		/* Sanity check */
		if (is_array($config['captiveportal'][$cpkey])) 
			/* Is zone enabled ? */
			if (array_key_exists('enable', $config['captiveportal'][$cpkey])) {
				$cpzone = $cpkey;
				$cpzoneid = $cp['zoneid'];
				$client_ip = $_SERVER['REMOTE_ADDR'];
				$cpentry = array();
				$cpentry = captiveportal_isip_logged($client_ip);
				if ( array_key_exists(5, $cpentry) ) {
				captiveportal_disconnect_client($cpentry[5], 1, "USER LOGOUT");
				}
			}
	}
?>

~~Note : the $cpzone should be set to the actual captive portal zone instance name !~~
~~( I'll update this post later on so the code will scan over all active captive portal zone instances )~~

When I visited this /logout.php page, I was logged out.

edit : code updated.

brinch

@Gertjan

Thank you very much, it does the trick.

Have a good day

Gertjan

I just updated the code ^^

netx34

any tutorial process to input this code? or edit and add
thanks in advance ive got this issue with my client users for how many months.

Gertjan

@netx34 said in Captive portal manual logout page address:

any tutorial process to input this code? or edit and add

Yep.

Place (create) it here : /usr/local/captiveportal
Call the file "logout.php".

Note : this is NOT a file you can upload into the pfSense Captive Pprtal's file manager !!

Now you can use
http://portal.mypfsense.tld:8004/logout.php
or
http://192.168.2.1:8004/logout.php

( if 192.168.2.1 is the IP address of the captive portal's interface - or your set "portal.mypfsense.tld" as the FQDN to this IP using the Resolver.
"8004" is just an example, your port number might be different. )

netx34

@Gertjan thank you,
im now test it before i deploy it to my exact pf serve,
great work and update.

update later after work.

netx34

btw only the logout.php can apply FQDN for the domain name

Gertjan

@netx34 said in Captive portal manual logout page address:

btw only the logout.php can apply FQDN for the domain name

What do you mean ?