Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    [SOLVED] Firewall Log Dynamic does not update

    Scheduled Pinned Locked Moved
    2.3-RC Snapshot Feedback and Issues - ARCHIVED
    2
    4
    982
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • P
      phil.davis
      last edited by

      There is no "dynamic" to Firewall Log Dynamic view.
      diag_logs_filter_dynamic.php refers to /javascript/filter_log.js
      But master branch no longer has a "javascript" folder. I can't see filter_log.js anywhere in master. This seems to remove any hope of the various bits of PHP and JavaScript working together to provide dynamic updates.

      This makes it hard to test other stuff about the dynamic view and dynamically updated rows, because I can't get any dynamic update to happen at all.

      As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
      If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

      1 Reply Last reply Reply Quote 0
      • S
        Steve_B Netgate
        last edited by

        Dynamism has been restored.

        etc/inc/filter_log.inc has been updated to use fa icon, but still needs work similar to you recent PR

        Als ik kan

        1 Reply Last reply Reply Quote 0
        • P
          phil.davis
          last edited by

          https://github.com/pfsense/pfsense/pull/2019 to get the icon cross/tick and the popup rule display working.
          I also made a couple of other PRs to minimize some code duplication in other diag_log_filter* when selecting the block/pass icons to use.

          As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
          If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

          1 Reply Last reply Reply Quote 0
          • S
            Steve_B Netgate
            last edited by

            PRs tested and merged. I made a small change after merging to support moving the action icon to the left of the dynamic page. Everything seems to work very nicely now.

            Thanks again for the help.

            Als ik kan

            1 Reply Last reply Reply Quote 0
            • First post
              Last post