2.4 snap no default gateway

BBcan177

I noticed the following with 2.4 DEV, I was always getting a no route to host (try to ping 8.8.8.8 )

2.4.0-DEVELOPMENT (amd64)
built on Thu Sep 15 21:39:59 CDT 2016
FreeBSD 11.0-RC2

I found that system_gateways.php "Apply" errs when its not in the table… the only way to fix it, is to manually run the route add default command.... Then all worked as expected.

route change -inet default x.x.x.x

route: route has not been found
change net default: gateway x.x.x.x fib 0: not in table

route add default x.x.x.x

add net default: gateway x.x.x.x

JorgeOliveira

@jimp:

I believe we had a patch for FreeBSD 10.x that changed the behavior of "route change" so that it would add if it did not exist. A stock FreeBSD 10.3 produces the same error you see there, but pfSense 2.3 does not, so there must be something that needs carried forward into our FreeBSD 11 code yet.

Ah! This is it:
https://github.com/pfsense/FreeBSD-src/commit/346b289d245fd8fd2013fb5624a9287c9ae4a49d

Needs to be adapted to fit on FreeBSD 11 as code had slight changes.

Maybe something like this could be pushed there:

--- route.c
+++ route.c
@@ -1524,6 +1524,7 @@
 		print_rtmsg(&rtm, l);
 	if (debugonly)
 		return (0);
+testagain:
 	if ((rlen = write(s, (char *)&m_rtmsg, l)) < 0) {
 		switch (errno) {
 		case EPERM:
@@ -1531,6 +1532,10 @@
 			break;
 		case ESRCH:
 			warnx("route has not been found");
+			if (rtm.rtm_type == RTM_CHANGE) {
+				rtm.rtm_type = RTM_ADD;
+				goto testagain;
+			}
 			break;
 		case EEXIST:
 			/* Handled by newroute() */

Please issue new snapshots after a change on this matter is applied, so we can test. Thanks! :)

Edit:
I just rebuilt the "route" on FreeBSD 11 with this patch applied. Replaced the stock version on pfSense and it works! :D

phil.davis

Also, there is a serial number displayed (a UUID), is that new, and if so, what for, and where does it get pulled from? EFI UUID var?

That was added in this commit https://github.com/pfsense/pfsense/commit/e093cb8e75acb6950a89d45c3fcd583b0c8fba2e which uses system_get_serial() from https://github.com/pfsense/pfsense/blob/master/src/etc/inc/system.inc

It tries for the output of:

/bin/kenv smbios.system.serial

and if that does not meet a few criteria, it goes for:

get_single_sysctl('kern.hostuuid')

which gets whatever UUID FreeBSD thinks it is.

jimp

I opened https://redmine.pfsense.org/issues/6828 for the "route change" issue though it looks like we're seeking out an alternate fix. The old patch was not coded in a way that we feel comfortable continuing to include, so we're looking at correcting the behavior in other ways.

jimp

That's what we're thinking, but there are numerous calls that rely on this change behavior (over 20, last I saw), so the current thinking is we'll make a pfSense module function in C that handles the heavy lifting of doing the check and then modify/change as needed where possible, so it will be faster and easier to address if the mechanism has to change in the future.

jimp

It wouldn't do shell/exec style calls it could manipulate the routing table directly (or closer to directly).

And as for removing duplication of route logic, that's the point of adding the function to the module, so other places can use that call and not duplicate the logic.

The module is already there for other functions, this is just likely to be added to it.

JorgeOliveira

In my opinion the following workaround could be applied:
https://forum.pfsense.org/index.php?topic=118859.msg658300#msg658300

And when the improved logic on pfSense module is implemented, the workaround could be removed.
It would be helpful for those running this developement version and "move" testing to other areas as this one is still work in progress.

jimp

That proposal was shot down right away – better to fix it right the first time.

2.4 is still alpha, it's not supposed to be used in production in any capacity yet, there are still missing features. It's not a place that would (or should) require temporary solutions yet. There are other manual workarounds if someone needs connectivity in the meantime.

NOYB

@jimp:

2.4 is still alpha, it's not supposed to be used in production in any capacity yet, there are still missing features. It's not a place that would (or should) require temporary solutions yet. There are other manual workarounds if someone needs connectivity in the meantime.

I'll second that.

jimp

@johnkeates:

PHP module is the way to go. I had a quick browse on GitHub/pfSense but couldn't find it there, is the current module hosted elsewhere?

https://github.com/pfsense/FreeBSD-ports/tree/devel/devel/php56-pfSense-module/files