Squid won't save Changes in General

spanguel

I have 2 pfsense boxes. Both are running the same Version:

pfsense Version:

2.3.2-RELEASE-p1 (amd64)
built on Tue Sep 27
FREEBSD 10.3-RELEASE-p9

Package Versions:

The first Box (wich is functional –> at least with Squid/ClamAV)
Squid: 0.4.26
squidGuard: 1.14_4
Lightsqui: 3.0.4_1

The second Box
Squid: 0.4.33
squidGuard: 1.14_4
Lightsquid: 3.0.4_3

The second Box ignores changes in the General Tab of "Services –> Squid Proxy Server"
Disabling "Services --> Squid Proxy Server --> Antivirus --> Enable AV" resolves the Problem.

I couldn't verify it as a Bug since I don't want to upgrade my first Box.

Reinstall was attempted. Can someone verify? (logs will be posted if I'm not the only one and it is indeed a general bug)

mrE

After upgrade to version 0.4.33 I have the same issue:
Can't change/save settings anymore.

I'm looking how to edit some settings in "Headers Handling, Language and Other Customizations" any clue?

Thanks

judgefred

Me too. It won't save the setting in General but it does saved in other tab . For example, I checked box the Transparent HTTP Proxy and Enable Access Logging then click Save, then after it reload, those box got uncheck.

Here what I have tried but no success:

remove squid and squidguard package then reinstall
manually deleted the squid folder
updated pfsense from 2.3.2 to 2.3.3-RELEASE-p1
reboot each time when remove/reinstall package
stop the squid service, it did stop, checked the Transparent HTTP Proxy –> Save --> it got unchecked again
stop the squid service, it did stop, unchecked the Enable Squid Proxy --> Save --> got checked again
Tried disabled Antivirus (it works) then enable Transparent HTTP Proxy (not working)

I'm noob here, 3rd days with pfsense. Anyone got any ideas?
Running Squid version 0.4.33

Thanks

doktornotor

This broke it - https://github.com/pfsense/FreeBSD-ports/pull/254

Why? NFC. Will get that reverted, plus filed a bug about install_cron_job().

jimp

I can't seem to reproduce this on 2.4, can someone try editing /usr/local/pkg/squid_antivirus.inc and adding this just under the install_cron_job on line 83?

parse_config(true);

So this:

		install_cron_job("{$freshclam_cmd}", true, "{$minutes}", "*/{$hours}", "*", "*", "*", "clamav");

Becomes this:


		install_cron_job("{$freshclam_cmd}", true, "{$minutes}", "*/{$hours}", "*", "*", "*", "clamav");
		parse_config(true);

jimp

I was able to reproduce it on 2.3.3 finally but I found that it was running squid_resync() twice back-to-back which caused the odd behavior.

I removed this from squid.xml and it works fine:

	 <custom_add_php_command>squid_resync();</custom_add_php_command>

I don't see any reason for that to be there on squid.xml either, unless I'm really missing something…

doktornotor

@jimp:

I was able to reproduce it on 2.3.3 finally but I found that it was running squid_resync() twice back-to-back which caused the odd behavior.

I removed this from squid.xml and it works fine:
	 <custom_add_php_command>squid_resync();</custom_add_php_command> 
I don't see any reason for that to be there on squid.xml either, unless I'm really missing something…

Thanks, seems to fix it as well… I guess there should be some locking or whatnot in place to prevent similar things?

spanguel

I appreciate the quick responses :)

@doktornotor: Thanks for the action on github too

For everyone:
First Thread: https://github.com/pfsense/FreeBSD-ports/pull/254
Fixed Thread: https://github.com/pfsense/FreeBSD-ports/pull/261

Its fixed in Version 0.4.34

judgefred

It's working after updated to 0.4.34.

Thank you all.
:)