[FIXED] - traffic shaping stopped working



  • on 2.3 and lower i had a set of rules in floating rules tab with match action which used to put traffic to queues so just today i noticed everything goes in the p2p default queue, is traffic shaping broken or has any changes been made that all of my rules stopped working in 2.4?

    my queues r as below

    pfTop: Up Queue 1-14/14, View: queue, Cache: 10000                      19:50:05
    
    QUEUE               BW SCH  PR  PKTS BYTES DROP_P DROP_B QLEN BORR SUSP P/S  B/S
    root_pppoe1      3500K hfsc  0     0     0      0      0    0             0    0
     qInternet       3500K hfsc        0     0      0      0    0             0    0
      qACK            700K hfsc        0     0      0      0    0             0    0
      qOthersDefault  700K hfsc        0     0      0      0    0             0    0
      qP2P            175K hfsc    24363 2761K      0      0    0           110 9198
      qVoIP           945K hfsc        0     0      0      0    0             0    0
      qOthersHigh     980K hfsc        0     0      0      0    0             0    0
    root_igb0          12M hfsc  0     0     0      0      0    0             0    0
     qInternet         12M hfsc        0     0      0      0    0             0    0
      qACK           1800K hfsc        0     0      0      0    0             0    0
      qOthersDefault 4800K hfsc        0     0      0      0    0             0    0
      qP2P           1200K hfsc    26985   23M      0      0    0           193 264K
      qVoIP          1200K hfsc        0     0      0      0    0             0    0
      qOthersHigh    3000K hfsc        0     0      0      0    0             0    0
    


  • Its broken in 2.4 for a while.. https://redmine.pfsense.org/issues/7116
    Workaround is far as you can call it that is to create regular pass rules with the gateway set..



  • I searched earlier on redmine but wasn't able to find this bug so posted here, thanks for the info but it seems the bug is there since long, shouldn't this be on a critical category considering many ppl use match rules and converting them to pass wouldn't be a work around but would mess other things up a lot.



  • @PiBa:

    Its broken in 2.4 for a while.. https://redmine.pfsense.org/issues/7116
    Workaround is far as you can call it that is to create regular pass rules with the gateway set..

    in the bug comments its mentioned patches for match rules are not present, would this be kernel patches or just php code?



  • That should be kernel patches, as the php does write the proper rules to the rules.config the problem is inside the binary pf code.

    There is probably something changed in FreeBSD that makes this patch nolonger work as it used to. https://github.com/pfsense/FreeBSD-src/commit/ffc6c6baf65df91e11cd127af9ec2683167f8cff

    I couldn't find other related patches..(by commit description) in the 2.3 branche, but maybe/probably i missed something..



  • so i guess we are at the mercy of pfsense devs to fix this, till then no traffic shaping, i doubt this issue will get some love soon considering its pending since long  :(



  • @xbipin:

    so i guess we are at the mercy of pfsense devs to fix this, till then no traffic shaping, i doubt this issue will get some love soon considering its pending since long  :(

    No, actually, we are not at their mercy… this does at least point us in the direction of where the bug originates from. Apparently this is a FreeBSD issue and any one of us can go and start working on it. HOWEVER this means that someone with the knowledge, ability, and time to work in the FreeBSD kernel patch needs to work on it…

    So, to be fair, we are at the mercy of whoever can work on this. Sadly, at this moment, it's not me either, but I may get desperate enough to pitch in some time for the effort!



  • Well the issue is with floating match rules which don't work, the shaper itself works with pass rules and as far as I remember pfsense has it's own patches for floating match rules which fell dead hence it's dead for now, this was already mentioned earlier I  guess.



  • Seeing bug 7116 again with squid.  Cannot place squid into any kind of shaper with match or pass rules.

    pfSense 2.4.0.r.20170927.1221

    squid 0.4.39


Log in to reply