Did captive portal view button behavior change ?

[deajan]

Hello,

I'm using pfSense 2.3.4 (also tested with 2.3.3) and it seems that the captive portal doesn't work like before.
I've created a test file containing a copy paste from the basic form:

When viewing the page via the GUI view button, the link is https://192.168.10.254/services_captiveportal.php?zone=test&act=viewhtml
Missing port 8002 in the URL too.
Validating user and password redirects to https://192.168.10.254/$PORTAL_ACTION$ without evaluating $PORTAL_ACTION$

Also, my php code from captive portal doesn't get executed anymore when using the view button.
I've created a simple test file containing:

echo "php";

?>

html

Uploading this as captive portal file and testing gives the following output

html

with the php code being presented in the source.

Anything totally stupid I missed since some previous upgrades ? Seems to happen since pfSense 2.3.3+.

Thanks.

[jimp]

In the past it did connect you to the captive portal daemon directly.

Looks like it changed with https://redmine.pfsense.org/issues/6391
I'm not sure the change was the most effective way to fix that issue, however. Viewing the source of the page is less useful than connecting to the portal daemon directly, but both could be useful tasks. We may need to add another button so both ways can function.

[jimp]

Opened https://redmine.pfsense.org/issues/7646 and just pushed a fix.

[deajan]

Wow, thanks for the quick reply and fix :)