Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    IPv6 lease files needed; Working on a patch for #7413

    Scheduled Pinned Locked Moved
    2.4 Development Snapshots
    3
    12
    1.8k
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • ?
      Guest
      last edited by

      Tried adding the patch using system patches and get Patch Fetch failed.

      1 Reply Last reply Reply Quote 0
      • A
        al
        last edited by

        Hi marjohn56,

        I wait for feedback re. the patch - I have not sent an official pull request yet, but mentioned where my github repo is with the files:
        https://github.com/al-right/pfSense-dhcpv6-gui-leases-patch

        The reason is that there are many changes and the patch rather big, but if I get time this weekend I will
        make a patch where I move most of the files into a sub directory of /usr/local/www/ and also make a smaller
        amend to one of the files.

        But thanks for your interest - I'll update this forum thread once there is news.

        1 Reply Last reply Reply Quote 0
        • ?
          Guest
          last edited by

          It's not a requirement to have issued a PR to use the pfSense patches system. As long as the commit you have issued is complete.

          1 Reply Last reply Reply Quote 0
          • MikeV7896M
            MikeV7896
            last edited by

            If there's some way to apply this through the System Patches package, I'd be happy to do so… but I don't see an actual patch file, commit ID, or whatever is needed to be able to apply it that way. I'm not one to go through and just replace files.

            The S in IOT stands for Security

            1 Reply Last reply Reply Quote 0
            • ?
              Guest
              last edited by

              It's not been done as a patch, all separate complete files. It looks interesting, but a pain if it's not a patch that can be added/removed at the click of a button.

              I'll not have time today, but tomorrow I may have time to go through them and create a patch commit.

              1 Reply Last reply Reply Quote 0
              • A
                al
                last edited by

                Hi marjohn56 and virgiliomi,

                I'll make the patch this weekend.
                I have a couple of smaller amends that need to go in e.g.
                with respect to the license in one of the files
                and make a sub folder for all but the status lease file.
                Patience - I promise I'll make it ;)

                1 Reply Last reply Reply Quote 0
                • A
                  al
                  last edited by

                  Hi all,

                  I have made the PR and you can find it here:
                  https://github.com/pfsense/pfsense/pull/3892/commits/c56471a75ac8cb7c573280022575ffdf0a92cf09
                  I have also tested it via System / Patches.

                  Feel free to try it out and comment.

                  Thanks :)

                  1 Reply Last reply Reply Quote 0
                  • MikeV7896M
                    MikeV7896
                    last edited by

                    Looks to be working well! It went through my leases and showed all the hosts that I would expect it to. The comparison to the NDP table to show MAC address seems to work as well. Not that MAC address has much to do with DHCPv6 like it does with DHCPv4, but if paired with the OUI file (placed wherever NMAP places it), you can at least see who made the device or network adapter. :)

                    dhcpv6-leases.png_thumb
                    dhcpv6-leases.png

                    The S in IOT stands for Security

                    1 Reply Last reply Reply Quote 0
                    • ?
                      Guest
                      last edited by

                      Looking good here too.

                      Nice work.

                      1 Reply Last reply Reply Quote 0
                      • A
                        al
                        last edited by

                        Hi all,

                        I have updated the PR with a second patch.
                        https://github.com/pfsense/pfsense/pull/3892/commits/f95579a6c42ab6bce1a103b8277c0cee93302b16

                        There are among other things a couple of visual changes
                        which intention is to give a better overview, because the
                        space in the tables are limited. You might want to read
                        the commit log message for further details.

                        Applying the newest patch with System Patches
                        won't work.                         I guess it is because of the files
                        that moved.

                        You will have to copy the files to their target
                        locations manually when testing.

                        Thanks :)

                        1 Reply Last reply Reply Quote 0
                        • First post
                          Last post