New 502 Bad Gateway

Corbinm3

We were also having issues with 502 Bad Gateway, 2.4.0 release, PFBlockerNG, Snort, OpenVPN Exporter…I noticed our issues after enabling DNS Resolver. Maybe it is just a coincidence but not even 30 minutes after turning that on and we got 502 errors. Rebooted, disabled PFBlockerNG, same problem the following day. Rebooted again, switched back to DNS forwarder and uninstalled PFBlockerNG, been stable since. Without the DNS resolver enabled we were stable with PFBlockerNG installed for over a week. After enabling the DNS Resolver, we went down quick. I'll keep this forum up to date if we do go down again and I have to rule out the DNS Resolver as the culprit, but for now, that's what it looks like from our end.

Edit: Forgot to post this is on Netgate hardware, can't remember which one though and I'm not in the office.

PiBa

For those willing to give some new code a try i have made a few changes to the 'file locking' code of pfBlockerNG.. :)
Could some of you try if the changes made improve things?

https://github.com/PiBa-NL/FreeBSD-ports/commit/1766713b26c8f388ad6e7909b2e971f7d74cdfea

Changes are as following:

include globals.inc so the /tmp/ folder is know to be used for placing lock files instead of the root /
dont try and lock a resource handle with try_lock as a 'resource-(descriptive)-name' is expected
use 1 lock around the stats file re-writing code, having 2 locks for the same piece of code is not needed.
remove the force_unlock called on a 'Resource #10' which wasn't used to create a lock anyhow..

It should be possible to apply the patch with systempatches package.
To add a new patch that way press add then fill in:
Description: pfBlocker_dnsbl_statsfile_locking
File: https://github.com/PiBa-NL/FreeBSD-ports/commit/1766713b26c8f388ad6e7909b2e971f7d74cdfea.patch
PathStrip: 4
Base: /
IgnoreWhitespace: Checked
AutoApply: Unchecked

Save, Fetch, Apply

A message should show "Patch applied successfully".

To revert it should be possible to just press 'Revert' which appears after the patch is applied.. If all fails, reinstall pfBlocker package "pkg install -f pfSense-pkg-pfBlockerNG"

Edit :
FYI: pfBlocker 2.1.2_2 includes this patch.

dstroot

Hmm… test output is not inspiring confidence. Patch test output:

/usr/bin/patch --directory=/ -f -p4 -i /var/patches/5a17809ef2593.patch --check --reverse --ignore-whitespace

Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|From 1766713b26c8f388ad6e7909b2e971f7d74cdfea Mon Sep 17 00:00:00 2001
|From: PiBa-NL
|Date: Fri, 24 Nov 2017 01:37:34 +0100
|Subject: [PATCH] pfBlockerNG, implement proper locking of dnsbl_info file to
| avoid possible corruption
|
|–-
| .../usr/local/pkg/pfblockerng/pfblockerng.inc      | 30 ++++++++-----------
| .../files/usr/local/www/pfblockerng/www/index.php  | 35 ++++++++++------------
| 2 files changed, 27 insertions(+), 38 deletions(-)
|
|diff --git a/net/pfSense-pkg-pfBlockerNG/files/usr/local/pkg/pfblockerng/pfblockerng.inc b/net/pfSense-pkg-pfBlockerNG/files/usr/local/pkg/pfblockerng/pfblockerng.inc
|index 0fddd745065b..c6379b8dab38 100644
|--- a/net/pfSense-pkg-pfBlockerNG/files/usr/local/pkg/pfblockerng/pfblockerng.inc
|+++ b/net/pfSense-pkg-pfBlockerNG/files/usr/local/pkg/pfblockerng/pfblockerng.inc
--------------------------
Patching file usr/local/pkg/pfblockerng/pfblockerng.inc using Plan A...
Hunk #1 failed at 2500.
1 out of 1 hunks failed while patching usr/local/pkg/pfblockerng/pfblockerng.inc
Hmm...  The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|diff --git a/net/pfSense-pkg-pfBlockerNG/files/usr/local/www/pfblockerng/www/index.php b/net/pfSense-pkg-pfBlockerNG/files/usr/local/www/pfblockerng/www/index.php
|index 0b864797146e..8992f4a0342f 100644
|--- a/net/pfSense-pkg-pfBlockerNG/files/usr/local/www/pfblockerng/www/index.php
|+++ b/net/pfSense-pkg-pfBlockerNG/files/usr/local/www/pfblockerng/www/index.php
--------------------------
Patching file usr/local/www/pfblockerng/www/index.php using Plan A...
Hunk #1 failed at 28.
Hunk #2 failed at 71.
2 out of 2 hunks failed while patching usr/local/www/pfblockerng/www/index.php
done

PiBa

dstroot, are you running latest/unmodified pfBlockerNG 2.1.2_1 version? On that version, the patch above should apply cleanly.

dstroot

Yes, see attached. Cheers!

firewall_home_lan_-_System__Package_Manager__Installed_Packages.png

PiBa

Wierd, can you reinstall it? 'pkg install -f pfSense-pkg-pfBlockerNG'
Same patch applies without issue on my 2.1.2_1, you havn't replaced anything with one of the previous files from bbcan's links or manually changed any part?

Or did you check the 'revert' test results? Below would be the expected test result:

Patch can be applied cleanly (detail)
Patch can NOT be reverted cleanly (detail)

Revert only works after the patch is applied already.

dstroot

I think the "Can NOT be reverted cleanly" through me off. I just checked and mine and got the results you show so I applied the patch and it applied successfully. I will report if the 502s go away. Cheers!

fortrash

Same error here. It is quite annoying as my pfsense installation ran smoothly. Since 2.4 I have to schedule reboots.
Any workaround except commenting out the code?
Are the developer working on it? Otherwise I do test the competitor product.

Thanks,

PiBa

Fortrash, please try the patch: https://forum.pfsense.org/index.php?topic=137103.msg767259#msg767259

fortrash

Thanks any chance to help the developer?

PiBa

@fortrash:

Thanks any chance to help the developer?

How do you mean?

Patches are made by developers.. Testing if it indeed fixes the issue would help, but thats something 'you' (users that experience the actual issue) have to do..

fortrash

Thanks, I am testing the patch.

chrcoluk

guys check my post here

https://forum.pfsense.org/index.php?topic=110515.msg766964#msg766964

PatPend

Running pfsense 2.4.1-RELEASE with pfBlockerNG on 2.1.2_1 installed and also running OpenVPN server. When the Bad Gateway error happened, OpenVPN clients couldn't connect as well. Rebooting fixed it for now. Any news on when the patch might be rolled into an update? Thanks, Russ

PiBa

PatPend, any news on if the patch helps? ::) may i presume your running with pfBlocker dns blocklists enabled as well?

If there is no positive feedback on its results then there is no need to commit it right? I hope there are no new problems reported by the people that applied the patch, and that they can confirm the problem did not return or at the very least took longer to re-appear.. Would be nice that in a week time they could say it has been running stable..

In the mean time please feel free to apply the patch to your own installation and test it out as well.

PatPend

@PiBa:

PatPend, any news on if the patch helps? ::) may i presume your running with pfBlocker dns blocklists enabled as well?

If there is no positive feedback on its results then there is no need to commit it right? I hope there are no new problems reported by the people that applied the patch, and that they can confirm the problem did not return or at the very least took longer to re-appear.. Would be nice that in a week time they could say it has been running stable..

In the mean time please feel free to apply the patch to your own installation and test it out as well.

I applied the patch today, so far so good. I'm running with easylist and easylist privacy plus 28 custom entries to block smart TV traffic. Last time it took about 10 days before hitting the 502 (of course when it did I was out of town when it also took out OpenVPN ::) ).

BBcan177

@PiBa:

For those willing to give some new code a try i have made a few changes to the 'file locking' code of pfBlockerNG.. :)

Thanks PiBa, hopefully we get some feedback to see if this resolves this issue… and we can get it merged!

fortrash

Hello,

I had to restart my pfsense box again. The patch has already been installed. Should I enable any logging?
Let me know how and what I can provide to resolve the problem.

Regards,

PiBa

Hmm ok thanks..

Could you create a file /root/testpfb.sh with following content?
The 'on-mobi.com' is one of the websites mentioned in my /var/db/pfblockerng/dnsblalias/DNSBL_adverts file, change it to something your blocking..:

#!/usr/local/bin/php -f
error_reporting(E_ERROR | E_PARSE);
global $_SERVER;
$_SERVER['HTTP_HOST'] = "on-mobi.com";
echo "\nTEST-START\n";
for($i=0;$i<$argv[1];$i++){
	if ($i % 100 == 1)
		echo ".";
	include('pfblockerng/www/index.php');
}
echo "\nTEST-END\n";

Make it executable:

chmod +x /root/testpfb.sh

And create a logfile executing it, this 'should' also hang..:

truss -Haedf -s 100 -o /root/truss_pfblocker_test.log /root/testpfb.sh 1

Preferably create 2 logfiles, 1 while webgui is unresponsive, and one when everything still works. That makes it easier to compare the two.. Also when webgui is unresponsive double check that the culprit still looks like it might be coming from pfBlockerNG..
Below command should return a number above 100..

/usr/bin/sockstat | grep lighttpd | wc -l

Or actually it might just be waiting for php-fpm which is 'bussy'…

#####################################################
Other separate request, apply the patch below, restart both php-fpm and webgui from the console options 11 and 16.
https://patch-diff.githubusercontent.com/raw/pfsense/pfsense/pull/3769.patch
Then every once in a while run the following on the pfSense box, preferably before everything is already broken or asap after, as it needs a socket available to itself as well it might not work once the problem is presenting itself..:

curl -k https://localhost/status

This should show some output on what php-fpm is busy with.. And might show if some/what script is taking more time than it should..

bgbird03

Is there an "easy button" for this fix? Maybe just disable pfBlockerNG? I'm pretty uninitiated…just happy I found out "why" it is happening because I had no clue. I'm assuming this will be fixed in 2.4.3 or an update to the extension?