Portal Captive problem after upgrade to 2.4.3

[mogaeng]

Dear all

after upgrade from 2.4.2 to 2.4.3 i can not disconnect user manual from status/captive portal .

please Help

[jimp]

Any errors in your browser, maybe in its javascript console? Or in the logs somewhere?

Disconnecting works for me here, for users and vouchers.

[altep]

When a user turn off internet through the Logout window in captiveportal,  IP not removed from the IPFW tables
(pfsense 2.4.3-RELEASE (amd64))
When a user press the disconnect button, in /usr/local/captiveportal/index.php (line 151) calls the captiveportal_disconnect_client function. This function first removes the information about the session from the captive portal database (file /etc/inc/captiveportal.inc line 1098), then the function captiveportal_disconnect (line 1104) is called. In captiveportal_disconnect, before removing an ip from the ipfw tables (lines 1038-1041), it is checked (lines 1035, 1036) whether this ip is logged. Because the information about the session is removed from the database, it bypass lines 1037-1041. As a result of this disconnection from the Internet does not occur.
I commented the lines 1035, 1036, 1042. The Captiva portal began to disconnect users.

[jimp]

OK, I was able to reproduce that now. I opened a ticket: https://redmine.pfsense.org/issues/8441