PHP Crash during new installation wizard 2.4.4 snapshot 20180904-1004

mrzaz

Hello,
Did a new fresh installation and got the following during installation wizard that crashed out the session.
pfSense-CE-memstick-2.4.4-DEVELOPMENT-amd64-20180904-1004.iso

I had only WAN and LAN interface defined.
re0 = WAN
ue0 = LAN (USB-LAN interface)

Crash report begins.  Anonymous machine information:

amd64
11.2-RELEASE-p2
FreeBSD 11.2-RELEASE-p2 #109 b0703dcab3c(RELENG_2_4_4): Tue Sep  4 10:05:18 EDT 2018     root@buildbot3:/builder/crossbuild-ce-master/obj/amd64/FWJoMRHc/builder/crossbuild-ce-master/pfSense/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[11-Sep-2018 19:02:49 Europe/Stockholm] PHP Warning:  Illegal string offset 'lan' in /usr/local/www/wizard.php(114) : eval()'d code on line 47
[11-Sep-2018 19:02:49 Europe/Stockholm] PHP Fatal error:  Uncaught Error: Cannot use string offset as an array in /usr/local/www/wizard.php(114) : eval()'d code:47
Stack trace:
#0 /usr/local/www/wizard.php(114): eval()
#1 {main}
  thrown in /usr/local/www/wizard.php(114) : eval()'d code on line 47


No FreeBSD crash data found.

Dan Lundqvist
Stockholm, Sweden

jimp

Are you certain you had that USB interface set at the LAN? Or was there some other LAN that was there, plus the USB, and then the original LAN was removed?

The error in the wizard implies the firewall has no LAN interface. While it could be handled more gracefully, the wizard only supports systems with at least a WAN and LAN interface.

jimp

OK, I see how to reproduce that.

If you delete the LAN interface and then re-add the LAN interface it doesn't have any DHCP settings, which breaks the wizard. I'll open a ticket to look into it after 2.4.4-RELEASE. That isn't a very common scenario so it's not worth holding back 2.4.4-RELEASE at this time.

EDIT: https://redmine.pfsense.org/issues/8889

mrzaz

@jimp

You are right... I did not have the USB Interface connected when I first started it up (only WAN).
I attached that at a later stage. I think the Wizard should be able to handle this anyway and at least just stop and say that a LAN interface must be inserted for it to continue and not bomb out.

//Dan Lundqvist

jimp

It actually does behave fine for that, what it didn't like was that the dhcp settings were gone, PHP 7.2 choked on the array reference. It will be fixed in 2.4.4-RELEASE

mrzaz

@jimp

Aha ok.. Just to clarify. I did not remove the interface. it was not installed in the first place as I only had RE0 available at startup and hadn't connected the USB adapter yet. I had defined the static IP on WAN but no interface on LAN.
Then I started the web and it started the wizard that then bombed out.
But good that you found the issue and has fixed it. :-)

//Danne