New PHP Warning

tquade

Crash report begins. Anonymous machine information:

amd64
12.2-STABLE
FreeBSD 12.2-STABLE devel-12-n226634-bdf0424cb2b5 pfSense

Crash report details:

PHP Errors:
[25-May-2021 12:36:27 America/Regina] PHP Warning: Use of undefined constant wg_ - assumed 'wg_' (this will throw an Error in a future version of PHP) in /usr/local/www/wg/status_wireguard.php on line 86
[25-May-2021 12:38:59 America/Regina] PHP Warning: Use of undefined constant wg_ - assumed 'wg_' (this will throw an Error in a future version of PHP) in /usr/local/www/wg/status_wireguard.php on line 86
[25-May-2021 15:36:20 America/Regina] PHP Warning: Use of undefined constant wg_ - assumed 'wg_' (this will throw an Error in a future version of PHP) in /usr/local/www/wg/status_wireguard.php on line 86

No FreeBSD crash data found.

Ted

JeGr

@tquade That don't look like errors per se, but warnings because of PHP changed handling/syntax of defining constants. That's the "assumed..." part. Looks like @theonemcdonald has to adapt the status/UI PHP code a bit (in that case seems like putting the wg_ in simple quotes) to fit the change in PHP. Likely caused by new PHP version from upstream pulled into 2.6 devs.

Also for reference: what version of the package are your running? I checked line 86 and can't find a constant defined there in the current codebase.

Cheers
\jegr

cmcdonald

@jegr that bug was an oversight, it's fixed. Will be in the next build

yon 0

amd64
12.2-STABLE
FreeBSD 12.2-STABLE devel-12-n226637-10439d5c8a53 pfSense

Crash report details:

PHP Errors:
[01-Jun-2021 09:15:32 Etc/GMT+8] PHP Warning: flock() expects parameter 1 to be resource, null given in /usr/local/pkg/wireguard/wg_service.inc on line 324
[01-Jun-2021 09:15:32 Etc/GMT+8] PHP Warning: fclose() expects parameter 1 to be resource, null given in /usr/local/pkg/wireguard/wg_service.inc on line 327

No FreeBSD crash data found.

cmcdonald

@yon-0 thanks, this will be fixed in next build which I hope to have submitted to Netgate soon